You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by "Nicolas Trésegnie (JIRA)" <ji...@apache.org> on 2013/02/12 01:29:12 UTC

[jira] [Comment Edited] (THRIFT-1846) Restore socket.h header to support builds with Android NDK

    [ https://issues.apache.org/jira/browse/THRIFT-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13576247#comment-13576247 ] 

Nicolas Trésegnie edited comment on THRIFT-1846 at 2/12/13 12:27 AM:
---------------------------------------------------------------------

Patch added: socket-include-moved-back-to-cpp.patch

This patch move the <sys/socket.h> include from the .h to the .cpp to minimize the risk of hidden dependencies.

In the .cpp, the include is placed before the <sys/un.h> include to allow thrift to compile with the Android NDK
                
      was (Author: nicolastr):
    This patch move the <sys/socket.h> include from the .h to the .cpp to minimize the risk of hidden dependencies.

In the .cpp, the include is placed before the <sys/un.h> include to allow thrift to compile with the Android NDK
                  
> Restore socket.h header to support builds with Android NDK
> ----------------------------------------------------------
>
>                 Key: THRIFT-1846
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1846
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>    Affects Versions: 0.9
>         Environment: Building with Android Linux NDK R8D (and, it looks like, all previous NDKs)
>            Reporter: Nate Rosenblum
>             Fix For: 0.9
>
>         Attachments: 0001-Restore-socket.h-include-to-support-Android-builds.patch, socket-include-moved-back-to-cpp.patch
>
>
> Unlike every other rational un.h that I've seen, the sys/un.h (actually linux/un.h) distributed with the Android NDK doesn't define sa_family_t or include another header that does. Removal of socket.h in THRIFT-1740 broke the Android build.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira