You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/12/04 08:07:42 UTC
[GitHub] [airflow] Taragolis opened a new pull request, #28092: Rewrite kerberos security integration and unit tests
Taragolis opened a new pull request, #28092:
URL: https://github.com/apache/airflow/pull/28092
This PR rewrite almost all `tests/security/test_kerberos.py`:
1. Migrate to `pytest`
2. Rename `TestKerberos` to `TestKerberosIntegrity` and add `@pytest.mark.integration("kerberos")` decorator
3. Rename `TestKerberosUnit` to `TestKerberos`
Seems like previously kerberos integrity test not run for a long period because it contain something which never pass in current airflow environment, for example if `[kerberos] include_ip` or `[kerberos] forwardable ` set to `""` and test actually run than an error should be raised - `conf.getboolean` couldn't parse empty string and convert it to boolean.
---
Local breeze result
```
================================================== test session starts ==================================================
platform linux -- Python 3.7.15, pytest-6.2.5, py-1.11.0, pluggy-1.0.0 -- /usr/local/bin/python
cachedir: .pytest_cache
rootdir: /opt/airflow, configfile: pytest.ini
plugins: cov-4.0.0, rerunfailures-9.1.1, instafail-0.4.2, anyio-3.6.2, timeouts-1.2.1, requests-mock-1.10.0, flaky-3.7.0, xdist-3.0.2, httpx-0.21.2, asyncio-0.20.2
asyncio: mode=strict
setup timeout: 0.0s, execution timeout: 0.0s, teardown timeout: 0.0s
collected 15 items
tests/security/test_kerberos.py::TestKerberosIntegration::test_renew_from_kt[default-config] PASSED [ 6%]
tests/security/test_kerberos.py::TestKerberosIntegration::test_renew_from_kt[explicit-include-ip] PASSED [ 13%]
tests/security/test_kerberos.py::TestKerberosIntegration::test_renew_from_kt[explicit-not-include-ip] PASSED [ 20%]
tests/security/test_kerberos.py::TestKerberosIntegration::test_renew_from_kt[explicit-forwardable] PASSED [ 26%]
tests/security/test_kerberos.py::TestKerberosIntegration::test_renew_from_kt[explicit-not-forwardable] PASSED [ 33%]
tests/security/test_kerberos.py::TestKerberosIntegration::test_args_from_cli[exit-on-fail] PASSED [ 40%]
tests/security/test_kerberos.py::TestKerberosIntegration::test_args_from_cli[return-code-of-fail] PASSED [ 46%]
tests/security/test_kerberos.py::TestKerberos::test_renew_from_kt[kerberos_config0-expected_cmd0] PASSED [ 53%]
tests/security/test_kerberos.py::TestKerberos::test_renew_from_kt[kerberos_config1-expected_cmd1] PASSED [ 60%]
tests/security/test_kerberos.py::TestKerberos::test_renew_from_kt[kerberos_config2-expected_cmd2] PASSED [ 66%]
tests/security/test_kerberos.py::TestKerberos::test_renew_from_kt_without_workaround PASSED [ 73%]
tests/security/test_kerberos.py::TestKerberos::test_renew_from_kt_failed PASSED [ 80%]
tests/security/test_kerberos.py::TestKerberos::test_renew_from_kt_failed_workaround PASSED [ 86%]
tests/security/test_kerberos.py::TestKerberos::test_run_without_keytab PASSED [ 93%]
tests/security/test_kerberos.py::TestKerberos::test_run PASSED [100%]
================================================== 15 passed in 7.96s ===================================================
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #28092: Rewrite kerberos security integration and unit tests
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #28092:
URL: https://github.com/apache/airflow/pull/28092
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #28092: Rewrite kerberos security integration and unit tests
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #28092:
URL: https://github.com/apache/airflow/pull/28092#issuecomment-1336663991
NAAAAJS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org