[GitHub] [spark] HyukjinKwon commented on a change in pull request #35082: [SPARK-37677][PYTHON] Decompress the ZIP file and grant the executable permission to the file

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #35082:
URL: https://github.com/apache/spark/pull/35082#discussion_r776997605



##########
File path: core/src/main/scala/org/apache/spark/util/Utils.scala
##########
@@ -605,6 +606,18 @@ private[spark] object Utils extends Logging {
     }
   }
 
+  def setExec(dest: File): Unit = {
+    val files = dest.listFiles()
+    for (i <- files) {
+      if (i.isDirectory) {
+        setExec(i)
+      }
+      else {
+        i.setExecutable(true)

Review comment:
       No.. I think we shouldn't just change file permissions to be all executable blindly. Some of them might be intentionally not executable to prevent users mistakenly run. Is there any way to keep and restore the original file permissions?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org