You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Sanjay Tripathi <sa...@citrix.com> on 2013/08/01 13:27:40 UTC
Re: Review Request 11626: Automation: Memory limits tests from Resource
Limits Tests
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11626/#review24360
-----------------------------------------------------------
test/integration/component/memory_limits/test_domain_limits.py
<https://reviews.apache.org/r/11626/#comment48217>
"domain" object is same as parent "domain" object, should use a different name.
test/integration/component/memory_limits/test_domain_limits.py
<https://reviews.apache.org/r/11626/#comment48352>
Use the listResourceLimit API to get the limit set for account. If you fetch the limit from the configuration, you will not get the limit set by using updateResourceLimit API.
test/integration/component/memory_limits/test_domain_limits.py
<https://reviews.apache.org/r/11626/#comment48353>
use listAccounts to get the resource count, also use assert to verify the count with the expected count.
test/integration/component/memory_limits/test_domain_limits.py
<https://reviews.apache.org/r/11626/#comment48354>
again, use listAccounts and assert
test/integration/component/memory_limits/test_domain_limits.py
<https://reviews.apache.org/r/11626/#comment48355>
use listAccounts and assert.
test/integration/component/memory_limits/test_domain_limits.py
<https://reviews.apache.org/r/11626/#comment48356>
Migration of a VM to another host will not affect/update any count because VM still belongs to the same account; instead of doing migration test, you should test assignVM to other account in which VM get assigned to other account and affects/updates the count for both the accounts.
test/integration/component/memory_limits/test_domain_limits.py
<https://reviews.apache.org/r/11626/#comment48357>
Use listAccounts to get the count.
test/integration/component/memory_limits/test_domain_limits.py
<https://reviews.apache.org/r/11626/#comment48358>
again, use listResourceLimits to get the limit set for this account.
test/integration/component/memory_limits/test_domain_limits.py
<https://reviews.apache.org/r/11626/#comment48359>
"Update" should be "List"
test/integration/component/memory_limits/test_domain_limits.py
<https://reviews.apache.org/r/11626/#comment48360>
I doubt if this test runs successfully because you are reaching the limit after the deployment of 1st VM itself.
test/integration/component/memory_limits/test_domain_limits.py
<https://reviews.apache.org/r/11626/#comment48361>
use listAccounts and assert to verify count.
- Sanjay Tripathi
On July 27, 2013, 1:21 p.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11626/
> -----------------------------------------------------------
>
> (Updated July 27, 2013, 1:21 p.m.)
>
>
> Review request for cloudstack, sailaja mada, Sanjay Tripathi, and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding resource limit tests related to Memory. Changes suggested in CPU resource limit tests which are applicable here are incorporated too.
>
> Updated test plan is available here: https://cwiki.apache.org/confluence/download/attachments/30757590/LimitResourcesTestPlanUpdate5.xlsx?version=1&modificationDate=1366952352000
>
>
> Diffs
> -----
>
> test/integration/component/memory_limits/test_domain_limits.py PRE-CREATION
> test/integration/component/memory_limits/test_maximum_limits.py PRE-CREATION
> test/integration/component/memory_limits/test_memory_limits.py PRE-CREATION
> test/integration/component/memory_limits/test_project_limits.py PRE-CREATION
> tools/marvin/marvin/integration/lib/base.py 8d9a25d
> tools/marvin/marvin/integration/lib/common.py 4f5acef
>
> Diff: https://reviews.apache.org/r/11626/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 11626: Automation: Memory limits tests from Resource
Limits Tests
Posted by Gaurav Aradhye <ga...@clogeny.com>.
> On Aug. 1, 2013, 4:57 p.m., Sanjay Tripathi wrote:
> > test/integration/component/memory_limits/test_domain_limits.py, line 302
> > <https://reviews.apache.org/r/11626/diff/2/?file=328254#file328254line302>
> >
> > Migration of a VM to another host will not affect/update any count because VM still belongs to the same account; instead of doing migration test, you should test assignVM to other account in which VM get assigned to other account and affects/updates the count for both the accounts.
Will add separate test for assigning vm. This test case is targeted at migrate scenario.
- Gaurav
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11626/#review24360
-----------------------------------------------------------
On Aug. 9, 2013, 1:21 p.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11626/
> -----------------------------------------------------------
>
> (Updated Aug. 9, 2013, 1:21 p.m.)
>
>
> Review request for cloudstack, sailaja mada, Sanjay Tripathi, and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding resource limit tests related to Memory. Changes suggested in CPU resource limit tests which are applicable here are incorporated too.
>
> Updated test plan is available here: https://cwiki.apache.org/confluence/download/attachments/30757590/LimitResourcesTestPlanUpdate5.xlsx?version=1&modificationDate=1366952352000
>
>
> Diffs
> -----
>
> test/integration/component/memory_limits/test_domain_limits.py PRE-CREATION
> test/integration/component/memory_limits/test_maximum_limits.py PRE-CREATION
> test/integration/component/memory_limits/test_memory_limits.py PRE-CREATION
> test/integration/component/memory_limits/test_project_limits.py PRE-CREATION
> tools/marvin/marvin/integration/lib/base.py 695edf7
> tools/marvin/marvin/integration/lib/common.py 4f5acef
>
> Diff: https://reviews.apache.org/r/11626/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 11626: Automation: Memory limits tests from Resource
Limits Tests
Posted by Sanjay Tripathi <sa...@citrix.com>.
> On Aug. 1, 2013, 11:27 a.m., Sanjay Tripathi wrote:
> > test/integration/component/memory_limits/test_domain_limits.py, line 429
> > <https://reviews.apache.org/r/11626/diff/2/?file=328254#file328254line429>
> >
> > use listAccounts and assert to verify count.
Also, can you close the issues opened in this request once you resolve them.
- Sanjay
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11626/#review24360
-----------------------------------------------------------
On July 27, 2013, 1:21 p.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11626/
> -----------------------------------------------------------
>
> (Updated July 27, 2013, 1:21 p.m.)
>
>
> Review request for cloudstack, sailaja mada, Sanjay Tripathi, and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding resource limit tests related to Memory. Changes suggested in CPU resource limit tests which are applicable here are incorporated too.
>
> Updated test plan is available here: https://cwiki.apache.org/confluence/download/attachments/30757590/LimitResourcesTestPlanUpdate5.xlsx?version=1&modificationDate=1366952352000
>
>
> Diffs
> -----
>
> test/integration/component/memory_limits/test_domain_limits.py PRE-CREATION
> test/integration/component/memory_limits/test_maximum_limits.py PRE-CREATION
> test/integration/component/memory_limits/test_memory_limits.py PRE-CREATION
> test/integration/component/memory_limits/test_project_limits.py PRE-CREATION
> tools/marvin/marvin/integration/lib/base.py 8d9a25d
> tools/marvin/marvin/integration/lib/common.py 4f5acef
>
> Diff: https://reviews.apache.org/r/11626/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gaurav Aradhye
>
>