You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Uma Maheswara Rao G (Created) (JIRA)" <ji...@apache.org> on 2012/03/18 02:46:40 UTC
[jira] [Created] (HBASE-5598) Analyse and fix the findbugs
reporting by QA and add invalid bugs into findbugs-excludeFilter file
Analyse and fix the findbugs reporting by QA and add invalid bugs into findbugs-excludeFilter file
--------------------------------------------------------------------------------------------------
Key: HBASE-5598
URL: https://issues.apache.org/jira/browse/HBASE-5598
Project: HBase
Issue Type: Bug
Components: scripts
Affects Versions: 0.92.1, 0.94.0, 0.96.0
Reporter: Uma Maheswara Rao G
Priority: Minor
There are many findbugs errors reporting by HbaseQA. HBASE-5597 is going to up the OK count.
This may lead to other issues when we re-factor the code, if we induce new valid ones and remove invalid bugs also can not be reported by QA.
So, I would propose to add the exclude filter file for findbugs for the invalid bugs. If we find any valid ond we can fix under this JIRA.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5598) Analyse and fix the findbugs
reporting by QA and add invalid bugs into findbugs-excludeFilter file
Posted by "Uma Maheswara Rao G (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uma Maheswara Rao G updated HBASE-5598:
---------------------------------------
Attachment: findbugs-gui-report.jpg
> Analyse and fix the findbugs reporting by QA and add invalid bugs into findbugs-excludeFilter file
> --------------------------------------------------------------------------------------------------
>
> Key: HBASE-5598
> URL: https://issues.apache.org/jira/browse/HBASE-5598
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.92.1, 0.94.0, 0.96.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Priority: Minor
> Attachments: HBASE-5598.patch, findbugs-gui-report.jpg
>
>
> There are many findbugs errors reporting by HbaseQA. HBASE-5597 is going to up the OK count.
> This may lead to other issues when we re-factor the code, if we induce new valid ones and remove invalid bugs also can not be reported by QA.
> So, I would propose to add the exclude filter file for findbugs(for the invalid bugs). If we find any valid ones, we can fix under this JIRA.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5598) Analyse and fix the findbugs
reporting by QA and add invalid bugs into findbugs-excludeFilter file
Posted by "Uma Maheswara Rao G (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239512#comment-13239512 ]
Uma Maheswara Rao G commented on HBASE-5598:
--------------------------------------------
{quote}
Uma, good stuff. Please take a look at this thread from the mailing list if you haven't seen it yet.
http://mail-archives.apache.org/mod_mbox/hbase-dev/201203.mbox/browser
{quote}
Thanks Jon. Yes, I have seen that discussion in mailing lists.
{quote}
I'd suggest updating the findbugs warning count in dev-support/test-patch.properties. Mind moving it over to HBASE-5642? We can keep this on as the umbrella is
{quote}
Sure, I will update the patch in HBASE-5642. But regarding updating the count, I am not agreeing. I am planning to use exclude filter file to exclude the invalid bugs. Please see the discussion in HBASE-5597 about updating the count. Please correct me if i understood wrongly your question. Thanks a lot.
{quote}
You can run findbugs locally via 'mvn findbugs:findbugs'. I thought we auto gen'ed the file for the website – making findbugs run and generate html when 'mvn site'
{quote}
Alternatively you can also use 'mvn findbugs:gui'. This command will generate the report in UI. Updated the samplke report in this JIRA.
Thanks
Uma
> Analyse and fix the findbugs reporting by QA and add invalid bugs into findbugs-excludeFilter file
> --------------------------------------------------------------------------------------------------
>
> Key: HBASE-5598
> URL: https://issues.apache.org/jira/browse/HBASE-5598
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.92.1, 0.94.0, 0.96.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Priority: Minor
> Attachments: HBASE-5598.patch, findbugs-gui-report.jpg
>
>
> There are many findbugs errors reporting by HbaseQA. HBASE-5597 is going to up the OK count.
> This may lead to other issues when we re-factor the code, if we induce new valid ones and remove invalid bugs also can not be reported by QA.
> So, I would propose to add the exclude filter file for findbugs(for the invalid bugs). If we find any valid ones, we can fix under this JIRA.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5598) Analyse and fix the findbugs
reporting by QA and add invalid bugs into findbugs-excludeFilter file
Posted by "Uma Maheswara Rao G (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239658#comment-13239658 ]
Uma Maheswara Rao G commented on HBASE-5598:
--------------------------------------------
Thanks a lot, Jon. I got your point. Make sense to me. I will update the patch accordingly in HBASE-5642.
> Analyse and fix the findbugs reporting by QA and add invalid bugs into findbugs-excludeFilter file
> --------------------------------------------------------------------------------------------------
>
> Key: HBASE-5598
> URL: https://issues.apache.org/jira/browse/HBASE-5598
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.92.1, 0.94.0, 0.96.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Priority: Minor
> Attachments: HBASE-5598.patch, findbugs-gui-report.jpg
>
>
> There are many findbugs errors reporting by HbaseQA. HBASE-5597 is going to up the OK count.
> This may lead to other issues when we re-factor the code, if we induce new valid ones and remove invalid bugs also can not be reported by QA.
> So, I would propose to add the exclude filter file for findbugs(for the invalid bugs). If we find any valid ones, we can fix under this JIRA.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5598) Analyse and fix the findbugs
reporting by QA and add invalid bugs into findbugs-excludeFilter file
Posted by "Uma Maheswara Rao G (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uma Maheswara Rao G updated HBASE-5598:
---------------------------------------
Release Note:
Developers can generate the findbugs report for analysing the findbugs violations.
Execute this maven command for running and generating the findbugs report: mvn findbugs:gui
This generates the report in GUI, by which will directly show the code instances where exactly the issue is reported.
If the developer finds any invalid bug, then that bug pattern can be updated in dev-support/findbugs-exclude.xml file.
example:
<Match>
<Class name="org.apache.hadoop.hbase.regionserver.HRegion" />
<Method name="getRecentFlushInfo" />
<Bug pattern="UL_UNRELEASED_LOCK_EXCEPTION_PATH" />
</Match>
> Analyse and fix the findbugs reporting by QA and add invalid bugs into findbugs-excludeFilter file
> --------------------------------------------------------------------------------------------------
>
> Key: HBASE-5598
> URL: https://issues.apache.org/jira/browse/HBASE-5598
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.92.1, 0.94.0, 0.96.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Priority: Minor
> Attachments: HBASE-5598.patch, findbugs-gui-report.jpg
>
>
> There are many findbugs errors reporting by HbaseQA. HBASE-5597 is going to up the OK count.
> This may lead to other issues when we re-factor the code, if we induce new valid ones and remove invalid bugs also can not be reported by QA.
> So, I would propose to add the exclude filter file for findbugs(for the invalid bugs). If we find any valid ones, we can fix under this JIRA.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5598) Analyse and fix the findbugs
reporting by QA and add invalid bugs into findbugs-excludeFilter file
Posted by "Uma Maheswara Rao G (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uma Maheswara Rao G updated HBASE-5598:
---------------------------------------
Attachment: HBASE-5598.patch
> Analyse and fix the findbugs reporting by QA and add invalid bugs into findbugs-excludeFilter file
> --------------------------------------------------------------------------------------------------
>
> Key: HBASE-5598
> URL: https://issues.apache.org/jira/browse/HBASE-5598
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.92.1, 0.94.0, 0.96.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Priority: Minor
> Attachments: HBASE-5598.patch
>
>
> There are many findbugs errors reporting by HbaseQA. HBASE-5597 is going to up the OK count.
> This may lead to other issues when we re-factor the code, if we induce new valid ones and remove invalid bugs also can not be reported by QA.
> So, I would propose to add the exclude filter file for findbugs(for the invalid bugs). If we find any valid ones, we can fix under this JIRA.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5598) Analyse and fix the findbugs
reporting by QA and add invalid bugs into findbugs-excludeFilter file
Posted by "Uma Maheswara Rao G (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238820#comment-13238820 ]
Uma Maheswara Rao G commented on HBASE-5598:
--------------------------------------------
Who ever wants to generate the findbugs html report locally, follow the below steps.
1) add the below target in pom.xml. Already there is one transformationSet available in pom.xml. just we can place this after that transformationSet.
<transformationSet>
<dir>${basedir}/target/</dir>
<includes>
<include>findbugsXml.xml</include>
</includes>
<stylesheet>E:/SoftWares/findbugs-1.3.9/findbugs-1.3.9/src/xsl/default.xsl</stylesheet>
<outputDir>${basedir}/target/</outputDir>
</transformationSet>
2) Make sure to update the above findbugs xsl path correctly referring to your local path of findbugs.
3) run 'mvn findbugs:findbugs'
4) run 'mvn site'
now ${basedir}/target/findbugsXml.xml will be replaced with html report. rename to ${basedir}/target/findbugsXml.html and open.
> Analyse and fix the findbugs reporting by QA and add invalid bugs into findbugs-excludeFilter file
> --------------------------------------------------------------------------------------------------
>
> Key: HBASE-5598
> URL: https://issues.apache.org/jira/browse/HBASE-5598
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.92.1, 0.94.0, 0.96.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Priority: Minor
>
> There are many findbugs errors reporting by HbaseQA. HBASE-5597 is going to up the OK count.
> This may lead to other issues when we re-factor the code, if we induce new valid ones and remove invalid bugs also can not be reported by QA.
> So, I would propose to add the exclude filter file for findbugs(for the invalid bugs). If we find any valid ones, we can fix under this JIRA.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5598) Analyse and fix the findbugs
reporting by QA and add invalid bugs into findbugs-excludeFilter file
Posted by "Jonathan Hsieh (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239639#comment-13239639 ]
Jonathan Hsieh commented on HBASE-5598:
---------------------------------------
bq. Sure, I will update the patch in HBASE-5642. But regarding updating the count, I am not agreeing. I am planning to use exclude filter file to exclude the invalid bugs. Please see the discussion in HBASE-5597 about updating the count. Please correct me if i understood wrongly your question. Thanks a lot.
Here's what I'm suggesting. Eventually we set the number to 0 due to the excludes files. Meanwhile, as we commit exclude/fix these warnings patches, we update the count to the number you expect to see after the patch. Patches in flight would just see the same number of new warnings it introduced instead of warnings from disappearing as you mentioned in HBASE-5597.
> Analyse and fix the findbugs reporting by QA and add invalid bugs into findbugs-excludeFilter file
> --------------------------------------------------------------------------------------------------
>
> Key: HBASE-5598
> URL: https://issues.apache.org/jira/browse/HBASE-5598
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.92.1, 0.94.0, 0.96.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Priority: Minor
> Attachments: HBASE-5598.patch, findbugs-gui-report.jpg
>
>
> There are many findbugs errors reporting by HbaseQA. HBASE-5597 is going to up the OK count.
> This may lead to other issues when we re-factor the code, if we induce new valid ones and remove invalid bugs also can not be reported by QA.
> So, I would propose to add the exclude filter file for findbugs(for the invalid bugs). If we find any valid ones, we can fix under this JIRA.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5598) Analyse and fix the findbugs
reporting by QA and add invalid bugs into findbugs-excludeFilter file
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239382#comment-13239382 ]
Hadoop QA commented on HBASE-5598:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12520103/findbugs-gui-report.jpg
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1320//console
This message is automatically generated.
> Analyse and fix the findbugs reporting by QA and add invalid bugs into findbugs-excludeFilter file
> --------------------------------------------------------------------------------------------------
>
> Key: HBASE-5598
> URL: https://issues.apache.org/jira/browse/HBASE-5598
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.92.1, 0.94.0, 0.96.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Priority: Minor
> Attachments: HBASE-5598.patch, findbugs-gui-report.jpg
>
>
> There are many findbugs errors reporting by HbaseQA. HBASE-5597 is going to up the OK count.
> This may lead to other issues when we re-factor the code, if we induce new valid ones and remove invalid bugs also can not be reported by QA.
> So, I would propose to add the exclude filter file for findbugs(for the invalid bugs). If we find any valid ones, we can fix under this JIRA.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5598) Analyse and fix the findbugs
reporting by QA and add invalid bugs into findbugs-excludeFilter file
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13243037#comment-13243037 ]
Hudson commented on HBASE-5598:
-------------------------------
Integrated in HBase-TRUNK-security #155 (See [https://builds.apache.org/job/HBase-TRUNK-security/155/])
HBASE-5598 [findbugs] Exclude Protobuf warnings from wire compat patches (Revision 1307656)
Result = SUCCESS
jmhsieh :
Files :
* /hbase/trunk/dev-support/findbugs-exclude.xml
> Analyse and fix the findbugs reporting by QA and add invalid bugs into findbugs-excludeFilter file
> --------------------------------------------------------------------------------------------------
>
> Key: HBASE-5598
> URL: https://issues.apache.org/jira/browse/HBASE-5598
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.92.1, 0.94.0, 0.96.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Priority: Minor
> Attachments: HBASE-5598.patch, findbugs-gui-report.jpg
>
>
> There are many findbugs errors reporting by HbaseQA. HBASE-5597 is going to up the OK count.
> This may lead to other issues when we re-factor the code, if we induce new valid ones and remove invalid bugs also can not be reported by QA.
> So, I would propose to add the exclude filter file for findbugs(for the invalid bugs). If we find any valid ones, we can fix under this JIRA.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5598) Analyse and fix the findbugs
reporting by QA and add invalid bugs into findbugs-excludeFilter file
Posted by "Uma Maheswara Rao G (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238849#comment-13238849 ]
Uma Maheswara Rao G commented on HBASE-5598:
--------------------------------------------
Also another case to use exclude filter is, we have many findbugs reported from generated code (from thrift).
We can just add that package to the filter file.
ex:
{code}
<FindBugsFilter>
<Match>
<Package name="org.apache.hadoop.hbase.thrift.generated" />
</Match>
</FindBugsFilter>
{code}
> Analyse and fix the findbugs reporting by QA and add invalid bugs into findbugs-excludeFilter file
> --------------------------------------------------------------------------------------------------
>
> Key: HBASE-5598
> URL: https://issues.apache.org/jira/browse/HBASE-5598
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.92.1, 0.94.0, 0.96.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Priority: Minor
>
> There are many findbugs errors reporting by HbaseQA. HBASE-5597 is going to up the OK count.
> This may lead to other issues when we re-factor the code, if we induce new valid ones and remove invalid bugs also can not be reported by QA.
> So, I would propose to add the exclude filter file for findbugs(for the invalid bugs). If we find any valid ones, we can fix under this JIRA.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5598) Analyse and fix the findbugs
reporting by QA and add invalid bugs into findbugs-excludeFilter file
Posted by "Uma Maheswara Rao G (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238924#comment-13238924 ]
Uma Maheswara Rao G commented on HBASE-5598:
--------------------------------------------
As a initial start I updated the patch with filter file.
1) added filter file
2) excluded generated packges.
org.apache.hadoop.hbase.thrift2.generated, org.apache.hadoop.hbase.thrift.generated, org.apache.hadoop.hbase.rest.protobuf.generated
This reduces the findbugs count from 772 to 601.
{quote}
[WARNING]
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] Building HBase 0.95-SNAPSHOT
[INFO] ------------------------------------------------------------------------
[INFO]
[INFO] --- findbugs-maven-plugin:2.4.0:findbugs (default-cli) @ hbase ---
[INFO] Fork Value is true
[java] Warnings generated: 601
[INFO] Done FindBugs Analysis....
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 3:19.270s
[INFO] Finished at: Tue Mar 27 03:56:20 IST 2012
[INFO] Final Memory: 13M/55M
[INFO] ------------------------------------------------------------------------
{quote}
note: currently we have already increased the count of findbugs in test-patch.properties. While verifying, I just reverted back to 0 for testing.
> Analyse and fix the findbugs reporting by QA and add invalid bugs into findbugs-excludeFilter file
> --------------------------------------------------------------------------------------------------
>
> Key: HBASE-5598
> URL: https://issues.apache.org/jira/browse/HBASE-5598
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.92.1, 0.94.0, 0.96.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Priority: Minor
> Attachments: HBASE-5598.patch
>
>
> There are many findbugs errors reporting by HbaseQA. HBASE-5597 is going to up the OK count.
> This may lead to other issues when we re-factor the code, if we induce new valid ones and remove invalid bugs also can not be reported by QA.
> So, I would propose to add the exclude filter file for findbugs(for the invalid bugs). If we find any valid ones, we can fix under this JIRA.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5598) Analyse and fix the findbugs
reporting by QA and add invalid bugs into findbugs-excludeFilter file
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239040#comment-13239040 ]
Hadoop QA commented on HBASE-5598:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12520025/HBASE-5598.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The applied patch generated 13 javac compiler warnings (more than the trunk's current 5 warnings).
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1313//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1313//console
This message is automatically generated.
> Analyse and fix the findbugs reporting by QA and add invalid bugs into findbugs-excludeFilter file
> --------------------------------------------------------------------------------------------------
>
> Key: HBASE-5598
> URL: https://issues.apache.org/jira/browse/HBASE-5598
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.92.1, 0.94.0, 0.96.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Priority: Minor
> Attachments: HBASE-5598.patch
>
>
> There are many findbugs errors reporting by HbaseQA. HBASE-5597 is going to up the OK count.
> This may lead to other issues when we re-factor the code, if we induce new valid ones and remove invalid bugs also can not be reported by QA.
> So, I would propose to add the exclude filter file for findbugs(for the invalid bugs). If we find any valid ones, we can fix under this JIRA.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5598) Analyse and fix the findbugs
reporting by QA and add invalid bugs into findbugs-excludeFilter file
Posted by "Jonathan Hsieh (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237582#comment-13237582 ]
Jonathan Hsieh commented on HBASE-5598:
---------------------------------------
Currently we are somewhere around the 770 warnings/errors mark. We should chop this into subtasks to break down the work and knock out related issues.
For this to last, once this we get the findbugs warnings to 0, committers need to enforce a no-new-findbugs errors policy on reviews. Agreed?
> Analyse and fix the findbugs reporting by QA and add invalid bugs into findbugs-excludeFilter file
> --------------------------------------------------------------------------------------------------
>
> Key: HBASE-5598
> URL: https://issues.apache.org/jira/browse/HBASE-5598
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.92.1, 0.94.0, 0.96.0
> Reporter: Uma Maheswara Rao G
> Priority: Minor
>
> There are many findbugs errors reporting by HbaseQA. HBASE-5597 is going to up the OK count.
> This may lead to other issues when we re-factor the code, if we induce new valid ones and remove invalid bugs also can not be reported by QA.
> So, I would propose to add the exclude filter file for findbugs(for the invalid bugs). If we find any valid ones, we can fix under this JIRA.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5598) Analyse and fix the findbugs
reporting by QA and add invalid bugs into findbugs-excludeFilter file
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237668#comment-13237668 ]
stack commented on HBASE-5598:
------------------------------
Propose up on dev list I'd say Jon. More folks will see your question.
> Analyse and fix the findbugs reporting by QA and add invalid bugs into findbugs-excludeFilter file
> --------------------------------------------------------------------------------------------------
>
> Key: HBASE-5598
> URL: https://issues.apache.org/jira/browse/HBASE-5598
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.92.1, 0.94.0, 0.96.0
> Reporter: Uma Maheswara Rao G
> Priority: Minor
>
> There are many findbugs errors reporting by HbaseQA. HBASE-5597 is going to up the OK count.
> This may lead to other issues when we re-factor the code, if we induce new valid ones and remove invalid bugs also can not be reported by QA.
> So, I would propose to add the exclude filter file for findbugs(for the invalid bugs). If we find any valid ones, we can fix under this JIRA.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5598) Analyse and fix the findbugs
reporting by QA and add invalid bugs into findbugs-excludeFilter file
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239037#comment-13239037 ]
stack commented on HBASE-5598:
------------------------------
I'm good w/ this patch. We should add your instruction on how to gen the findbugs report to the release notes for this issue and to the reference guide (I can add it there if you add it to the release notes). I thought we were building the findbugs report when we generated the site but we are not doing this it seems. Findbugs is being generated by the hadoopqa builds.
> Analyse and fix the findbugs reporting by QA and add invalid bugs into findbugs-excludeFilter file
> --------------------------------------------------------------------------------------------------
>
> Key: HBASE-5598
> URL: https://issues.apache.org/jira/browse/HBASE-5598
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.92.1, 0.94.0, 0.96.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Priority: Minor
> Attachments: HBASE-5598.patch
>
>
> There are many findbugs errors reporting by HbaseQA. HBASE-5597 is going to up the OK count.
> This may lead to other issues when we re-factor the code, if we induce new valid ones and remove invalid bugs also can not be reported by QA.
> So, I would propose to add the exclude filter file for findbugs(for the invalid bugs). If we find any valid ones, we can fix under this JIRA.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5598) Analyse and fix the findbugs
reporting by QA and add invalid bugs into findbugs-excludeFilter file
Posted by "Uma Maheswara Rao G (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uma Maheswara Rao G updated HBASE-5598:
---------------------------------------
Description:
There are many findbugs errors reporting by HbaseQA. HBASE-5597 is going to up the OK count.
This may lead to other issues when we re-factor the code, if we induce new valid ones and remove invalid bugs also can not be reported by QA.
So, I would propose to add the exclude filter file for findbugs(for the invalid bugs). If we find any valid ones, we can fix under this JIRA.
was:
There are many findbugs errors reporting by HbaseQA. HBASE-5597 is going to up the OK count.
This may lead to other issues when we re-factor the code, if we induce new valid ones and remove invalid bugs also can not be reported by QA.
So, I would propose to add the exclude filter file for findbugs for the invalid bugs. If we find any valid ond we can fix under this JIRA.
> Analyse and fix the findbugs reporting by QA and add invalid bugs into findbugs-excludeFilter file
> --------------------------------------------------------------------------------------------------
>
> Key: HBASE-5598
> URL: https://issues.apache.org/jira/browse/HBASE-5598
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.92.1, 0.94.0, 0.96.0
> Reporter: Uma Maheswara Rao G
> Priority: Minor
>
> There are many findbugs errors reporting by HbaseQA. HBASE-5597 is going to up the OK count.
> This may lead to other issues when we re-factor the code, if we induce new valid ones and remove invalid bugs also can not be reported by QA.
> So, I would propose to add the exclude filter file for findbugs(for the invalid bugs). If we find any valid ones, we can fix under this JIRA.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5598) Analyse and fix the findbugs
reporting by QA and add invalid bugs into findbugs-excludeFilter file
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242915#comment-13242915 ]
Hudson commented on HBASE-5598:
-------------------------------
Integrated in HBase-TRUNK #2702 (See [https://builds.apache.org/job/HBase-TRUNK/2702/])
HBASE-5598 [findbugs] Exclude Protobuf warnings from wire compat patches (Revision 1307656)
Result = SUCCESS
jmhsieh :
Files :
* /hbase/trunk/dev-support/findbugs-exclude.xml
> Analyse and fix the findbugs reporting by QA and add invalid bugs into findbugs-excludeFilter file
> --------------------------------------------------------------------------------------------------
>
> Key: HBASE-5598
> URL: https://issues.apache.org/jira/browse/HBASE-5598
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.92.1, 0.94.0, 0.96.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Priority: Minor
> Attachments: HBASE-5598.patch, findbugs-gui-report.jpg
>
>
> There are many findbugs errors reporting by HbaseQA. HBASE-5597 is going to up the OK count.
> This may lead to other issues when we re-factor the code, if we induce new valid ones and remove invalid bugs also can not be reported by QA.
> So, I would propose to add the exclude filter file for findbugs(for the invalid bugs). If we find any valid ones, we can fix under this JIRA.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5598) Analyse and fix the findbugs
reporting by QA and add invalid bugs into findbugs-excludeFilter file
Posted by "Uma Maheswara Rao G (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239384#comment-13239384 ]
Uma Maheswara Rao G commented on HBASE-5598:
--------------------------------------------
@Stack, Thanks a lot for taking a look.
Actually I have given the steps which i followed for generating the findbugs locally in comment https://issues.apache.org/jira/browse/HBASE-5598?focusedCommentId=13238820&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13238820
Also I found better command to view the findbugs in UI directly.
This command would be better to update in notes.
{quote}
E:\Repositories\Hbase>mvn findbugs:gui
{quote}
This is giving all the findbug comments by reffering code snippets directly. This should help the developers to generate the reports in their envs.
Also attached the sample screenshot of the report.
> Analyse and fix the findbugs reporting by QA and add invalid bugs into findbugs-excludeFilter file
> --------------------------------------------------------------------------------------------------
>
> Key: HBASE-5598
> URL: https://issues.apache.org/jira/browse/HBASE-5598
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.92.1, 0.94.0, 0.96.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Priority: Minor
> Attachments: HBASE-5598.patch, findbugs-gui-report.jpg
>
>
> There are many findbugs errors reporting by HbaseQA. HBASE-5597 is going to up the OK count.
> This may lead to other issues when we re-factor the code, if we induce new valid ones and remove invalid bugs also can not be reported by QA.
> So, I would propose to add the exclude filter file for findbugs(for the invalid bugs). If we find any valid ones, we can fix under this JIRA.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5598) Analyse and fix the findbugs
reporting by QA and add invalid bugs into findbugs-excludeFilter file
Posted by "Jonathan Hsieh (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239490#comment-13239490 ]
Jonathan Hsieh commented on HBASE-5598:
---------------------------------------
Uma, good stuff. Please take a look at this thread from the mailing list if you haven't seen it yet.
http://mail-archives.apache.org/mod_mbox/hbase-dev/201203.mbox/browser
I'd suggest updating the findbugs warning count in dev-support/test-patch.properties. Mind moving it over to HBASE-5642? We can keep this on as the umbrella issue.
For the other folks interested, here's some link on how to add findbugs/findbugs excludes for those who want to jump on some issues.
http://findbugs.sourceforge.net/manual/filter.html
http://mojo.codehaus.org/findbugs-maven-plugin-2.4.0/
You can run findbugs locally via 'mvn findbugs:findbugs'. I thought we auto gen'ed the file for the website -- making findbugs run and generate html when 'mvn site' is run might be another subtask to add.
> Analyse and fix the findbugs reporting by QA and add invalid bugs into findbugs-excludeFilter file
> --------------------------------------------------------------------------------------------------
>
> Key: HBASE-5598
> URL: https://issues.apache.org/jira/browse/HBASE-5598
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.92.1, 0.94.0, 0.96.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Priority: Minor
> Attachments: HBASE-5598.patch, findbugs-gui-report.jpg
>
>
> There are many findbugs errors reporting by HbaseQA. HBASE-5597 is going to up the OK count.
> This may lead to other issues when we re-factor the code, if we induce new valid ones and remove invalid bugs also can not be reported by QA.
> So, I would propose to add the exclude filter file for findbugs(for the invalid bugs). If we find any valid ones, we can fix under this JIRA.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5598) Analyse and fix the findbugs
reporting by QA and add invalid bugs into findbugs-excludeFilter file
Posted by "Lars Hofhansl (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237694#comment-13237694 ]
Lars Hofhansl commented on HBASE-5598:
--------------------------------------
+1 on no-new-findbugs-policy once it's down to 0. (We do the same at Salesforce.)
Not sure, though, that right method to get this to 0 is to use an exclude filter, should use findbug annotation in the files.
> Analyse and fix the findbugs reporting by QA and add invalid bugs into findbugs-excludeFilter file
> --------------------------------------------------------------------------------------------------
>
> Key: HBASE-5598
> URL: https://issues.apache.org/jira/browse/HBASE-5598
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.92.1, 0.94.0, 0.96.0
> Reporter: Uma Maheswara Rao G
> Priority: Minor
>
> There are many findbugs errors reporting by HbaseQA. HBASE-5597 is going to up the OK count.
> This may lead to other issues when we re-factor the code, if we induce new valid ones and remove invalid bugs also can not be reported by QA.
> So, I would propose to add the exclude filter file for findbugs(for the invalid bugs). If we find any valid ones, we can fix under this JIRA.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5598) Analyse and fix the findbugs
reporting by QA and add invalid bugs into findbugs-excludeFilter file
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245859#comment-13245859 ]
jiraposter@reviews.apache.org commented on HBASE-5598:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4612/
-----------------------------------------------------------
Review request for hbase.
Summary
-------
Fixes for issues reported in findbugs for "Correctness" category.
This addresses bug HBASE-5598.
https://issues.apache.org/jira/browse/HBASE-5598
Diffs
-----
dev-support/test-patch.properties 2209d27
src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RSStatusTmpl.jamon ae76204
src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java 37bcaba
src/main/java/org/apache/hadoop/hbase/mapreduce/CellCounter.java 32d66fb
src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java 64def15
src/main/java/org/apache/hadoop/hbase/master/DefaultLoadBalancer.java 1676832
src/main/java/org/apache/hadoop/hbase/master/HMaster.java 9bd4ace
src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 3515d4a
src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 8ae60a3
src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreLAB.java 2694897
src/main/java/org/apache/hadoop/hbase/regionserver/ShutdownHook.java e3b230e
src/main/java/org/apache/hadoop/hbase/regionserver/Store.java 0c7b396
src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java 2e98b39
src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java 698bb3d
src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java 8950c9f
src/main/java/org/apache/hadoop/hbase/util/FSTableDescriptors.java 62cf6ac
src/main/java/org/apache/hadoop/hbase/util/FSUtils.java aebe5b0
src/main/java/org/apache/hadoop/hbase/util/JVMClusterUtil.java c21377c
src/main/java/org/apache/hadoop/hbase/util/Merge.java 04f15d4
src/main/java/org/apache/hadoop/hbase/util/PoolMap.java 8e2a856
Diff: https://reviews.apache.org/r/4612/diff
Testing
-------
Ran test-patch.sh and unit tests.
Thanks,
David
> Analyse and fix the findbugs reporting by QA and add invalid bugs into findbugs-excludeFilter file
> --------------------------------------------------------------------------------------------------
>
> Key: HBASE-5598
> URL: https://issues.apache.org/jira/browse/HBASE-5598
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.92.1, 0.94.0, 0.96.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Priority: Minor
> Attachments: HBASE-5598.patch, findbugs-gui-report.jpg
>
>
> There are many findbugs errors reporting by HbaseQA. HBASE-5597 is going to up the OK count.
> This may lead to other issues when we re-factor the code, if we induce new valid ones and remove invalid bugs also can not be reported by QA.
> So, I would propose to add the exclude filter file for findbugs(for the invalid bugs). If we find any valid ones, we can fix under this JIRA.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5598) Analyse and fix the findbugs
reporting by QA and add invalid bugs into findbugs-excludeFilter file
Posted by "Uma Maheswara Rao G (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238804#comment-13238804 ]
Uma Maheswara Rao G commented on HBASE-5598:
--------------------------------------------
I am not so favor of adding directly static tools related annotations into code.
In Hadoop projects(HDFS, Mapreduce) we are using this exclude-filter for invalid find bugs. So, I proposed this here.
I think we can decide first how we will exclude the invalid bugs, then we can start working on the bug fix directly.
> Analyse and fix the findbugs reporting by QA and add invalid bugs into findbugs-excludeFilter file
> --------------------------------------------------------------------------------------------------
>
> Key: HBASE-5598
> URL: https://issues.apache.org/jira/browse/HBASE-5598
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.92.1, 0.94.0, 0.96.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Priority: Minor
>
> There are many findbugs errors reporting by HbaseQA. HBASE-5597 is going to up the OK count.
> This may lead to other issues when we re-factor the code, if we induce new valid ones and remove invalid bugs also can not be reported by QA.
> So, I would propose to add the exclude filter file for findbugs(for the invalid bugs). If we find any valid ones, we can fix under this JIRA.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5598) Analyse and fix the findbugs
reporting by QA and add invalid bugs into findbugs-excludeFilter file
Posted by "ramkrishna.s.vasudevan (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13239168#comment-13239168 ]
ramkrishna.s.vasudevan commented on HBASE-5598:
-----------------------------------------------
@Jon
Can you add the subtasks here that you have identified as the categories of findbugs.
We have some tasks started over here. We can take up few in that.
> Analyse and fix the findbugs reporting by QA and add invalid bugs into findbugs-excludeFilter file
> --------------------------------------------------------------------------------------------------
>
> Key: HBASE-5598
> URL: https://issues.apache.org/jira/browse/HBASE-5598
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.92.1, 0.94.0, 0.96.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Priority: Minor
> Attachments: HBASE-5598.patch
>
>
> There are many findbugs errors reporting by HbaseQA. HBASE-5597 is going to up the OK count.
> This may lead to other issues when we re-factor the code, if we induce new valid ones and remove invalid bugs also can not be reported by QA.
> So, I would propose to add the exclude filter file for findbugs(for the invalid bugs). If we find any valid ones, we can fix under this JIRA.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5598) Analyse and fix the findbugs
reporting by QA and add invalid bugs into findbugs-excludeFilter file
Posted by "Uma Maheswara Rao G (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uma Maheswara Rao G updated HBASE-5598:
---------------------------------------
Status: Patch Available (was: Open)
> Analyse and fix the findbugs reporting by QA and add invalid bugs into findbugs-excludeFilter file
> --------------------------------------------------------------------------------------------------
>
> Key: HBASE-5598
> URL: https://issues.apache.org/jira/browse/HBASE-5598
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.92.1, 0.94.0, 0.96.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Priority: Minor
> Attachments: HBASE-5598.patch
>
>
> There are many findbugs errors reporting by HbaseQA. HBASE-5597 is going to up the OK count.
> This may lead to other issues when we re-factor the code, if we induce new valid ones and remove invalid bugs also can not be reported by QA.
> So, I would propose to add the exclude filter file for findbugs(for the invalid bugs). If we find any valid ones, we can fix under this JIRA.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-5598) Analyse and fix the findbugs
reporting by QA and add invalid bugs into findbugs-excludeFilter file
Posted by "Uma Maheswara Rao G (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uma Maheswara Rao G reassigned HBASE-5598:
------------------------------------------
Assignee: Uma Maheswara Rao G
> Analyse and fix the findbugs reporting by QA and add invalid bugs into findbugs-excludeFilter file
> --------------------------------------------------------------------------------------------------
>
> Key: HBASE-5598
> URL: https://issues.apache.org/jira/browse/HBASE-5598
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.92.1, 0.94.0, 0.96.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Priority: Minor
>
> There are many findbugs errors reporting by HbaseQA. HBASE-5597 is going to up the OK count.
> This may lead to other issues when we re-factor the code, if we induce new valid ones and remove invalid bugs also can not be reported by QA.
> So, I would propose to add the exclude filter file for findbugs(for the invalid bugs). If we find any valid ones, we can fix under this JIRA.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira