[GitHub] [helix] dasahcc commented on a change in pull request #1197: Support option to skip direct ZK read for health check API

[GitBox <gi...@apache.org>]

dasahcc commented on a change in pull request #1197:
URL: https://github.com/apache/helix/pull/1197#discussion_r464574757



##########
File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/InstancesAccessor.java
##########
@@ -172,7 +172,7 @@ public Response instancesOperations(@PathParam("clusterId") String clusterId,
         admin.enableInstance(clusterId, enableInstances, false);
         break;
       case stoppable:
-        return batchGetStoppableInstances(clusterId, node);
+        return batchGetStoppableInstances(clusterId, node, Boolean.valueOf(skipZKRead));

Review comment:
       parseBoolean can cause exception if that does not match. But the valueOf has a default value.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org