You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Owen O'Malley (JIRA)" <ji...@apache.org> on 2011/06/07 23:26:58 UTC
[jira] [Created] (HADOOP-7365) Clean up CHANGES.txt
Clean up CHANGES.txt
---------------------
Key: HADOOP-7365
URL: https://issues.apache.org/jira/browse/HADOOP-7365
Project: Hadoop Common
Issue Type: Task
Reporter: Owen O'Malley
Assignee: Owen O'Malley
CHANGES.txt has some typos and standardizing the formatting.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7365) Clean up CHANGES.txt
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13047457#comment-13047457 ]
Suresh Srinivas commented on HADOOP-7365:
-----------------------------------------
+1 for the change. Could you please add some unit tests ;-)
> Clean up CHANGES.txt
> ---------------------
>
> Key: HADOOP-7365
> URL: https://issues.apache.org/jira/browse/HADOOP-7365
> Project: Hadoop Common
> Issue Type: Task
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Attachments: c.patch, c.patch, changes.patch
>
>
> CHANGES.txt has some typos and standardizing the formatting.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7365) Clean up CHANGES.txt
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13046067#comment-13046067 ]
Hadoop QA commented on HADOOP-7365:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12481840/c.patch
against trunk revision 1133125.
-1 @author. The patch appears to contain 2 @author tags which the Hadoop community has agreed to not allow in code contributions.
+1 tests included. The patch appears to include 2 new or modified tests.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/595//console
This message is automatically generated.
> Clean up CHANGES.txt
> ---------------------
>
> Key: HADOOP-7365
> URL: https://issues.apache.org/jira/browse/HADOOP-7365
> Project: Hadoop Common
> Issue Type: Task
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Attachments: c.patch, c.patch
>
>
> CHANGES.txt has some typos and standardizing the formatting.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7365) Clean up CHANGES.txt
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-7365:
----------------------------------
Attachment: changes.patch
This fixes up some more of the wrong jiras that showed up when i looked for duplicates.
> Clean up CHANGES.txt
> ---------------------
>
> Key: HADOOP-7365
> URL: https://issues.apache.org/jira/browse/HADOOP-7365
> Project: Hadoop Common
> Issue Type: Task
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Attachments: c.patch, c.patch, changes.patch
>
>
> CHANGES.txt has some typos and standardizing the formatting.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7365) Clean up CHANGES.txt
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13047461#comment-13047461 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-7365:
------------------------------------------------
> ... Could you please add some unit tests ...
There are already 2 new or modified tests. :)
bq. +1 tests included. The patch appears to include 2 new or modified tests.
> Clean up CHANGES.txt
> ---------------------
>
> Key: HADOOP-7365
> URL: https://issues.apache.org/jira/browse/HADOOP-7365
> Project: Hadoop Common
> Issue Type: Task
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Attachments: c.patch, c.patch, changes.patch
>
>
> CHANGES.txt has some typos and standardizing the formatting.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7365) Clean up CHANGES.txt
Posted by "Allen Wittenauer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045695#comment-13045695 ]
Allen Wittenauer commented on HADOOP-7365:
------------------------------------------
Other than minor spacing issues and the fact that lots of people can't spell (myself included), it is much better. :)
> Clean up CHANGES.txt
> ---------------------
>
> Key: HADOOP-7365
> URL: https://issues.apache.org/jira/browse/HADOOP-7365
> Project: Hadoop Common
> Issue Type: Task
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Attachments: c.patch
>
>
> CHANGES.txt has some typos and standardizing the formatting.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7365) Clean up CHANGES.txt
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13047330#comment-13047330 ]
Hadoop QA commented on HADOOP-7365:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12482079/changes.patch
against trunk revision 1134218.
-1 @author. The patch appears to contain 2 @author tags which the Hadoop community has agreed to not allow in code contributions.
+1 tests included. The patch appears to include 2 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/609//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/609//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/609//console
This message is automatically generated.
> Clean up CHANGES.txt
> ---------------------
>
> Key: HADOOP-7365
> URL: https://issues.apache.org/jira/browse/HADOOP-7365
> Project: Hadoop Common
> Issue Type: Task
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Attachments: c.patch, c.patch, changes.patch
>
>
> CHANGES.txt has some typos and standardizing the formatting.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7365) Clean up CHANGES.txt
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045693#comment-13045693 ]
Hadoop QA commented on HADOOP-7365:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12481758/c.patch
against trunk revision 1133125.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/592//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/592//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/592//console
This message is automatically generated.
> Clean up CHANGES.txt
> ---------------------
>
> Key: HADOOP-7365
> URL: https://issues.apache.org/jira/browse/HADOOP-7365
> Project: Hadoop Common
> Issue Type: Task
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Attachments: c.patch
>
>
> CHANGES.txt has some typos and standardizing the formatting.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7365) Clean up CHANGES.txt
Posted by "Robert Joseph Evans (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Joseph Evans updated HADOOP-7365:
----------------------------------------
Status: Open (was: Patch Available)
Canceling the patch as it is over 7 months old and needs to be upmerged as 1.0 has moved on a bit.
> Clean up CHANGES.txt
> ---------------------
>
> Key: HADOOP-7365
> URL: https://issues.apache.org/jira/browse/HADOOP-7365
> Project: Hadoop Common
> Issue Type: Task
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Attachments: c.patch, c.patch, changes.patch
>
>
> CHANGES.txt has some typos and standardizing the formatting.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7365) Clean up CHANGES.txt
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-7365:
----------------------------------
Attachment: c.patch
> Clean up CHANGES.txt
> ---------------------
>
> Key: HADOOP-7365
> URL: https://issues.apache.org/jira/browse/HADOOP-7365
> Project: Hadoop Common
> Issue Type: Task
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Attachments: c.patch
>
>
> CHANGES.txt has some typos and standardizing the formatting.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7365) Clean up CHANGES.txt
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-7365:
----------------------------------
Status: Patch Available (was: Open)
> Clean up CHANGES.txt
> ---------------------
>
> Key: HADOOP-7365
> URL: https://issues.apache.org/jira/browse/HADOOP-7365
> Project: Hadoop Common
> Issue Type: Task
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Attachments: c.patch
>
>
> CHANGES.txt has some typos and standardizing the formatting.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7365) Clean up CHANGES.txt
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-7365:
----------------------------------
Attachment: c.patch
This patch cleans up CHANGES.txt by:
1. Normalizing committers names to their apache login.
2. Fixing typos.
3. Limiting the line length to 79 chars.
4. Normalizing a few of the jira names for jiras that moved projects.
5. Creating virtual-jira NOJIRA- ids for 3 changes that didn't have jiras.
6. Adding jiras for hadoop 1.0.
7. Normalizing the format in the old releases to what we currently use.
> Clean up CHANGES.txt
> ---------------------
>
> Key: HADOOP-7365
> URL: https://issues.apache.org/jira/browse/HADOOP-7365
> Project: Hadoop Common
> Issue Type: Task
> Reporter: Owen O'Malley
> Assignee: Owen O'Malley
> Attachments: c.patch, c.patch
>
>
> CHANGES.txt has some typos and standardizing the formatting.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira