[jira] [Created] (SOLR-4768) The Solr war produced by generate-maven-artifacts should not contain logging jars

["Steve Rowe (JIRA)" <ji...@apache.org>]

Steve Rowe created SOLR-4768:
--------------------------------

             Summary: The Solr war produced by generate-maven-artifacts should not contain logging jars
                 Key: SOLR-4768
                 URL: https://issues.apache.org/jira/browse/SOLR-4768
             Project: Solr
          Issue Type: Bug
          Components: Build
    Affects Versions: 4.3
            Reporter: Steve Rowe
            Assignee: Steve Rowe


I know why the two .wars are different:

The binary package Solr war's target chain is:

  'package'->'create-package'->'dist'->'dist-war'->webapp:'dist'

The maven Solr war's target chain is:

  'generate-maven-artifacts'->webapp:'dist-maven'->webapp:'dist'

So both create the war using webapp:'dist', but only 'dist-war' passes in a modified 'exclude.from.war' property definition (which is empty by default):

     <property name="exclude.from.war" value="*slf4j*,log4j-*" />

As a result, the maven Solr war contains logging jars while the official war does not.

I think the fix is to make the above the default setting, rather than passing in a non-default property value from 'dist-war'.


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org