You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by gn...@apache.org on 2020/05/05 16:30:54 UTC

[incubator-nuttx] 01/02: stm32f103-minimum/src/stm32_tone: remove unnecessary call to tone start()

This is an automated email from the ASF dual-hosted git repository.

gnutt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git

commit c11325d06167a09ad39ff5d428126763b9c183d0
Author: Pierre-Olivier Vauboin <po...@lambdaconcept.com>
AuthorDate: Tue May 5 17:07:20 2020 +0200

    stm32f103-minimum/src/stm32_tone: remove unnecessary call to tone start()
    
    The "info" structure was used non initialized and causing bad sounds at
    boot. The start() function is anyway called later on when actually playing
    sounds.
---
 boards/arm/stm32/stm32f103-minimum/src/stm32_tone.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/boards/arm/stm32/stm32f103-minimum/src/stm32_tone.c b/boards/arm/stm32/stm32f103-minimum/src/stm32_tone.c
index 453cd8e..c9d7ae2 100644
--- a/boards/arm/stm32/stm32f103-minimum/src/stm32_tone.c
+++ b/boards/arm/stm32/stm32f103-minimum/src/stm32_tone.c
@@ -101,7 +101,6 @@ int stm32_tone_setup(void)
 {
   static bool                initialized = false;
   struct pwm_lowerhalf_s     *tone;
-  struct pwm_info_s          info;
   struct oneshot_lowerhalf_s *oneshot = NULL;
   int                        ret;
 
@@ -121,7 +120,6 @@ int stm32_tone_setup(void)
       /* Initialize TONE PWM */
 
       tone->ops->setup(tone);
-      tone->ops->start(tone, &info);
 
       /* Initialize ONESHOT Timer */