[GitHub] [pinot] xiangfu0 commented on a diff in pull request #10626: [multistage] populate queryOption down to leaf

["xiangfu0 (via GitHub)" <gi...@apache.org>]

xiangfu0 commented on code in PR #10626:
URL: https://github.com/apache/pinot/pull/10626#discussion_r1169263628


##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/plan/ServerRequestPlanVisitor.java:
##########
@@ -126,8 +126,7 @@ public static ServerPlanRequestContext build(MailboxService<TransferableBlock> m
     QUERY_OPTIMIZER.optimize(pinotQuery, tableConfig, schema);
 
     // 2. set pinot query options according to requestMetadataMap
-    pinotQuery.setQueryOptions(
-        ImmutableMap.of(CommonConstants.Broker.Request.QueryOptionKey.TIMEOUT_MS, String.valueOf(timeoutMs)));
+    updateQueryOptions(pinotQuery, requestMetadataMap, timeoutMs, traceEnabled);

Review Comment:
   do we want to support stage based query options as well?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org