Re: [PR] KAFKA-16331: remove EOSv1 from StreamsProducer [kafka]

["chia7712 (via GitHub)" <gi...@apache.org>]

chia7712 commented on code in PR #17212:
URL: https://github.com/apache/kafka/pull/17212#discussion_r1769375309


##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/ActiveTaskCreator.java:
##########
@@ -318,14 +314,7 @@ Map<MetricName, Metric> producerMetrics() {
     }
 
     Set<String> producerClientIds() {

Review Comment:
   Could we use `String` instead of `Set<String>>` for now?



##########
streams/src/test/java/org/apache/kafka/streams/state/KeyValueStoreTestDriver.java:
##########
@@ -191,7 +191,7 @@ public static <K, V> KeyValueStoreTestDriver<K, V> create(final Serializer<K> ke
     private final Set<K> flushedRemovals = new HashSet<>();
     private final List<KeyValue<byte[], byte[]>> restorableEntries = new LinkedList<>();
 
-    private final InternalMockProcessorContext context;
+    private final InternalMockProcessorContext<?, ?> context;
     private final StateSerdes<K, V> stateSerdes;
 
     @SuppressWarnings("unchecked")

Review Comment:
   this can be removed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org