[Impala-ASF-CR] IMPALA-4052: CREATE TABLE LIKE for Kudu tables

["Quanlong Huang (Code Review)" <ge...@cloudera.org>]

Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18729 )

Change subject: IMPALA-4052: CREATE TABLE LIKE for Kudu tables
......................................................................


Patch Set 12:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18729/12/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java
File fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java:

http://gerrit.cloudera.org:8080/#/c/18729/12/fe/src/main/java/org/apache/impala/analysis/CreateTableLikeStmt.java@223
PS12, Line 223:     if (sortColumns_ != null) {
This causes the test failure. We should only check this when the target table is a Kudu table.



-- 
To view, visit http://gerrit.cloudera.org:8080/18729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3d276a6465301dbcfed17bb713aca06367d9a42
Gerrit-Change-Number: 18729
Gerrit-PatchSet: 12
Gerrit-Owner: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Xiaoqing Gao <ga...@gmail.com>
Gerrit-Comment-Date: Sun, 04 Sep 2022 12:30:34 +0000
Gerrit-HasComments: Yes