You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Bertrand Guay-Paquet (JIRA)" <ji...@apache.org> on 2011/04/07 23:47:05 UTC
[jira] [Created] (WICKET-3603) DataTable row groups are present in
markup even when they contain no rows.
DataTable row groups are present in markup even when they contain no rows.
--------------------------------------------------------------------------
Key: WICKET-3603
URL: https://issues.apache.org/jira/browse/WICKET-3603
Project: Wicket
Issue Type: Bug
Components: wicket-extensions
Affects Versions: 1.5-RC3
Reporter: Bertrand Guay-Paquet
As per the HTML spec :
"When present, each THEAD, TFOOT, and TBODY contains a row group. Each row group must contain at least one row, defined by the TR element."
There is no check in place to remove the row group tags from the output if they don't contain any row.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (WICKET-3603) DataTable row groups are present in
markup even when they contain no rows.
Posted by "Bertrand Guay-Paquet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bertrand Guay-Paquet closed WICKET-3603.
----------------------------------------
> DataTable row groups are present in markup even when they contain no rows.
> --------------------------------------------------------------------------
>
> Key: WICKET-3603
> URL: https://issues.apache.org/jira/browse/WICKET-3603
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.5-RC3
> Reporter: Bertrand Guay-Paquet
> Assignee: Martin Grigorov
> Labels: datatable
> Fix For: 1.5-RC4
>
> Attachments: DataTableToolbars.patch
>
>
> As per the HTML spec :
> "When present, each THEAD, TFOOT, and TBODY contains a row group. Each row group must contain at least one row, defined by the TR element."
> There is no check in place to remove the row group tags from the output if they don't contain any row.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WICKET-3603) DataTable row groups are present in
markup even when they contain no rows.
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov resolved WICKET-3603.
-------------------------------------
Resolution: Fixed
Fix Version/s: 1.5-RC4
Improved with r1094660.
> DataTable row groups are present in markup even when they contain no rows.
> --------------------------------------------------------------------------
>
> Key: WICKET-3603
> URL: https://issues.apache.org/jira/browse/WICKET-3603
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.5-RC3
> Reporter: Bertrand Guay-Paquet
> Assignee: Martin Grigorov
> Labels: datatable
> Fix For: 1.5-RC4
>
> Attachments: DataTableToolbars.patch
>
>
> As per the HTML spec :
> "When present, each THEAD, TFOOT, and TBODY contains a row group. Each row group must contain at least one row, defined by the TR element."
> There is no check in place to remove the row group tags from the output if they don't contain any row.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (WICKET-3603) DataTable row groups
are present in markup even when they contain no rows.
Posted by "Bertrand Guay-Paquet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13017176#comment-13017176 ]
Bertrand Guay-Paquet edited comment on WICKET-3603 at 4/7/11 10:01 PM:
-----------------------------------------------------------------------
Partial fix for thead and tfoot
was (Author: berniegp):
Partial fix for thead and tbody
> DataTable row groups are present in markup even when they contain no rows.
> --------------------------------------------------------------------------
>
> Key: WICKET-3603
> URL: https://issues.apache.org/jira/browse/WICKET-3603
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.5-RC3
> Reporter: Bertrand Guay-Paquet
> Labels: datatable
> Attachments: DataTableToolbars.patch
>
>
> As per the HTML spec :
> "When present, each THEAD, TFOOT, and TBODY contains a row group. Each row group must contain at least one row, defined by the TR element."
> There is no check in place to remove the row group tags from the output if they don't contain any row.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-3603) DataTable row groups are present
in markup even when they contain no rows.
Posted by "Bertrand Guay-Paquet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13017178#comment-13017178 ]
Bertrand Guay-Paquet commented on WICKET-3603:
----------------------------------------------
Please see attached DataTableToolbars.patch for a proposed patch to fix the occurance of <thead> and <tfoot>.
There is still a problem when the DataTable has no records however. In that case, we have an empty <tbody> which is not valid html. <tbody> cannot be simply removed because a non-empty table body is required.
I wasn't sure what to do in that case so I left it out of the first patch.
> DataTable row groups are present in markup even when they contain no rows.
> --------------------------------------------------------------------------
>
> Key: WICKET-3603
> URL: https://issues.apache.org/jira/browse/WICKET-3603
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.5-RC3
> Reporter: Bertrand Guay-Paquet
> Labels: datatable
> Attachments: DataTableToolbars.patch
>
>
> As per the HTML spec :
> "When present, each THEAD, TFOOT, and TBODY contains a row group. Each row group must contain at least one row, defined by the TR element."
> There is no check in place to remove the row group tags from the output if they don't contain any row.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-3603) DataTable row groups are present in
markup even when they contain no rows.
Posted by "Bertrand Guay-Paquet (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bertrand Guay-Paquet updated WICKET-3603:
-----------------------------------------
Attachment: DataTableToolbars.patch
Partial fix for thead and tbody
> DataTable row groups are present in markup even when they contain no rows.
> --------------------------------------------------------------------------
>
> Key: WICKET-3603
> URL: https://issues.apache.org/jira/browse/WICKET-3603
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.5-RC3
> Reporter: Bertrand Guay-Paquet
> Labels: datatable
> Attachments: DataTableToolbars.patch
>
>
> As per the HTML spec :
> "When present, each THEAD, TFOOT, and TBODY contains a row group. Each row group must contain at least one row, defined by the TR element."
> There is no check in place to remove the row group tags from the output if they don't contain any row.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (WICKET-3603) DataTable row groups are present in
markup even when they contain no rows.
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov reassigned WICKET-3603:
---------------------------------------
Assignee: Martin Grigorov
> DataTable row groups are present in markup even when they contain no rows.
> --------------------------------------------------------------------------
>
> Key: WICKET-3603
> URL: https://issues.apache.org/jira/browse/WICKET-3603
> Project: Wicket
> Issue Type: Bug
> Components: wicket-extensions
> Affects Versions: 1.5-RC3
> Reporter: Bertrand Guay-Paquet
> Assignee: Martin Grigorov
> Labels: datatable
> Attachments: DataTableToolbars.patch
>
>
> As per the HTML spec :
> "When present, each THEAD, TFOOT, and TBODY contains a row group. Each row group must contain at least one row, defined by the TR element."
> There is no check in place to remove the row group tags from the output if they don't contain any row.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira