You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Philip Zeyliger (JIRA)" <ji...@apache.org> on 2009/09/16 19:35:57 UTC
[jira] Created: (MAPREDUCE-990) Making distributed cache getters in
JobContext never return null
Making distributed cache getters in JobContext never return null
----------------------------------------------------------------
Key: MAPREDUCE-990
URL: https://issues.apache.org/jira/browse/MAPREDUCE-990
Project: Hadoop Map/Reduce
Issue Type: Improvement
Reporter: Philip Zeyliger
Assignee: Philip Zeyliger
Priority: Minor
MAPREDUCE-898 moved distributed cache setters and getters into Job and JobContext. Since the API is new, I'd like to propose that those getters never return null, but instead always return an array, even if it's empty.
If people don't like this change, I can instead merely update the javadoc to reflect the fact that null may be returned.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-990) Making distributed cache getters
in JobContext never return null
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12757352#action_12757352 ]
Hadoop QA commented on MAPREDUCE-990:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12420045/MAPREDUCE-990.patch
against trunk revision 816735.
-1 @author. The patch appears to contain @author tags which the Hadoop community has agreed to not allow in code contributions.
+1 tests included. The patch appears to include new or modified tests.
-1 patch. The patch command could not apply the patch.
Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/114/console
This message is automatically generated.
> Making distributed cache getters in JobContext never return null
> ----------------------------------------------------------------
>
> Key: MAPREDUCE-990
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-990
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Philip Zeyliger
> Assignee: Philip Zeyliger
> Priority: Minor
> Attachments: MAPREDUCE-990.patch, MAPREDUCE-990.patch.txt
>
>
> MAPREDUCE-898 moved distributed cache setters and getters into Job and JobContext. Since the API is new, I'd like to propose that those getters never return null, but instead always return an array, even if it's empty.
> If people don't like this change, I can instead merely update the javadoc to reflect the fact that null may be returned.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-990) Making distributed cache getters in
JobContext never return null
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated MAPREDUCE-990:
--------------------------------
Status: Open (was: Patch Available)
> Making distributed cache getters in JobContext never return null
> ----------------------------------------------------------------
>
> Key: MAPREDUCE-990
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-990
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Philip Zeyliger
> Assignee: Philip Zeyliger
> Priority: Minor
> Attachments: MAPREDUCE-990.patch, MAPREDUCE-990.patch.txt
>
>
> MAPREDUCE-898 moved distributed cache setters and getters into Job and JobContext. Since the API is new, I'd like to propose that those getters never return null, but instead always return an array, even if it's empty.
> If people don't like this change, I can instead merely update the javadoc to reflect the fact that null may be returned.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-990) Making distributed cache getters in
JobContext never return null
Posted by "Philip Zeyliger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Philip Zeyliger updated MAPREDUCE-990:
--------------------------------------
Status: Patch Available (was: Open)
> Making distributed cache getters in JobContext never return null
> ----------------------------------------------------------------
>
> Key: MAPREDUCE-990
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-990
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Philip Zeyliger
> Assignee: Philip Zeyliger
> Priority: Minor
> Attachments: MAPREDUCE-990.patch.txt
>
>
> MAPREDUCE-898 moved distributed cache setters and getters into Job and JobContext. Since the API is new, I'd like to propose that those getters never return null, but instead always return an array, even if it's empty.
> If people don't like this change, I can instead merely update the javadoc to reflect the fact that null may be returned.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-990) Making distributed cache getters in
JobContext never return null
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated MAPREDUCE-990:
--------------------------------
Attachment: MAPREDUCE-990.patch
New patch that removes the timestamp methods.
> Making distributed cache getters in JobContext never return null
> ----------------------------------------------------------------
>
> Key: MAPREDUCE-990
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-990
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Philip Zeyliger
> Assignee: Philip Zeyliger
> Priority: Minor
> Attachments: MAPREDUCE-990.patch, MAPREDUCE-990.patch.txt
>
>
> MAPREDUCE-898 moved distributed cache setters and getters into Job and JobContext. Since the API is new, I'd like to propose that those getters never return null, but instead always return an array, even if it's empty.
> If people don't like this change, I can instead merely update the javadoc to reflect the fact that null may be returned.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-990) Making distributed cache getters
in JobContext never return null
Posted by "Philip Zeyliger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756363#action_12756363 ]
Philip Zeyliger commented on MAPREDUCE-990:
-------------------------------------------
bq. As javadoc says JobContext is a readonly view of the job provided to tasks. get*TimeStamps cannot be package private methods. Framework would call them from a different packge.
The framework doesn't currently call them at all. The framework probably has more than the JobContext, so they ought to move somewhere else. I don't think they should be part of the user API--can I delete them entirely until they actually get used?
-- Philip
> Making distributed cache getters in JobContext never return null
> ----------------------------------------------------------------
>
> Key: MAPREDUCE-990
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-990
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Philip Zeyliger
> Assignee: Philip Zeyliger
> Priority: Minor
> Attachments: MAPREDUCE-990.patch.txt
>
>
> MAPREDUCE-898 moved distributed cache setters and getters into Job and JobContext. Since the API is new, I'd like to propose that those getters never return null, but instead always return an array, even if it's empty.
> If people don't like this change, I can instead merely update the javadoc to reflect the fact that null may be returned.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-990) Making distributed cache getters
in JobContext never return null
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756354#action_12756354 ]
Amareshwari Sriramadasu commented on MAPREDUCE-990:
---------------------------------------------------
As javadoc says JobContext is a readonly view of the job provided to tasks. get*TimeStamps cannot be package private methods. Framework would call them from a different packge.
> Making distributed cache getters in JobContext never return null
> ----------------------------------------------------------------
>
> Key: MAPREDUCE-990
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-990
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Philip Zeyliger
> Assignee: Philip Zeyliger
> Priority: Minor
> Attachments: MAPREDUCE-990.patch.txt
>
>
> MAPREDUCE-898 moved distributed cache setters and getters into Job and JobContext. Since the API is new, I'd like to propose that those getters never return null, but instead always return an array, even if it's empty.
> If people don't like this change, I can instead merely update the javadoc to reflect the fact that null may be returned.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-990) Making distributed cache getters
in JobContext never return null
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12757351#action_12757351 ]
Hadoop QA commented on MAPREDUCE-990:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12420045/MAPREDUCE-990.patch
against trunk revision 816664.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 javadoc. The javadoc tool appears to have generated 1 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/113/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/113/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/113/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h6.grid.sp2.yahoo.net/113/console
This message is automatically generated.
> Making distributed cache getters in JobContext never return null
> ----------------------------------------------------------------
>
> Key: MAPREDUCE-990
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-990
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Philip Zeyliger
> Assignee: Philip Zeyliger
> Priority: Minor
> Attachments: MAPREDUCE-990.patch, MAPREDUCE-990.patch.txt
>
>
> MAPREDUCE-898 moved distributed cache setters and getters into Job and JobContext. Since the API is new, I'd like to propose that those getters never return null, but instead always return an array, even if it's empty.
> If people don't like this change, I can instead merely update the javadoc to reflect the fact that null may be returned.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-990) Making distributed cache getters
in JobContext never return null
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756579#action_12756579 ]
Tom White commented on MAPREDUCE-990:
-------------------------------------
bq. I don't think they should be part of the user API--can I delete them entirely until they actually get used?
+1
> Making distributed cache getters in JobContext never return null
> ----------------------------------------------------------------
>
> Key: MAPREDUCE-990
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-990
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Philip Zeyliger
> Assignee: Philip Zeyliger
> Priority: Minor
> Attachments: MAPREDUCE-990.patch.txt
>
>
> MAPREDUCE-898 moved distributed cache setters and getters into Job and JobContext. Since the API is new, I'd like to propose that those getters never return null, but instead always return an array, even if it's empty.
> If people don't like this change, I can instead merely update the javadoc to reflect the fact that null may be returned.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-990) Making distributed cache getters
in JobContext never return null
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756415#action_12756415 ]
Hadoop QA commented on MAPREDUCE-990:
-------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12419796/MAPREDUCE-990.patch.txt
against trunk revision 816052.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/41/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/41/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/41/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h3.grid.sp2.yahoo.net/41/console
This message is automatically generated.
> Making distributed cache getters in JobContext never return null
> ----------------------------------------------------------------
>
> Key: MAPREDUCE-990
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-990
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Philip Zeyliger
> Assignee: Philip Zeyliger
> Priority: Minor
> Attachments: MAPREDUCE-990.patch.txt
>
>
> MAPREDUCE-898 moved distributed cache setters and getters into Job and JobContext. Since the API is new, I'd like to propose that those getters never return null, but instead always return an array, even if it's empty.
> If people don't like this change, I can instead merely update the javadoc to reflect the fact that null may be returned.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-990) Making distributed cache getters
in JobContext never return null
Posted by "Vinod K V (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756346#action_12756346 ]
Vinod K V commented on MAPREDUCE-990:
-------------------------------------
bq. Ideally those interfaces aren't leaked to the user at all--the only person who accesses them is the mapreduce framework itself, so they should remain an implementation detail.
In which case, I think they shouldn't even be in JobContext. Amareshwari?
> Making distributed cache getters in JobContext never return null
> ----------------------------------------------------------------
>
> Key: MAPREDUCE-990
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-990
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Philip Zeyliger
> Assignee: Philip Zeyliger
> Priority: Minor
> Attachments: MAPREDUCE-990.patch.txt
>
>
> MAPREDUCE-898 moved distributed cache setters and getters into Job and JobContext. Since the API is new, I'd like to propose that those getters never return null, but instead always return an array, even if it's empty.
> If people don't like this change, I can instead merely update the javadoc to reflect the fact that null may be returned.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-990) Making distributed cache getters in
JobContext never return null
Posted by "Philip Zeyliger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Philip Zeyliger updated MAPREDUCE-990:
--------------------------------------
Attachment: MAPREDUCE-990.patch.txt
This changes javadocs and implementations of accessors to never return null.
I've also made getFileTimestamps and getArchiveTimestamps package private. Ideally those interfaces aren't leaked to the user at all--the only person who accesses them is the mapreduce framework itself, so they should remain an implementation detail.
> Making distributed cache getters in JobContext never return null
> ----------------------------------------------------------------
>
> Key: MAPREDUCE-990
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-990
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Philip Zeyliger
> Assignee: Philip Zeyliger
> Priority: Minor
> Attachments: MAPREDUCE-990.patch.txt
>
>
> MAPREDUCE-898 moved distributed cache setters and getters into Job and JobContext. Since the API is new, I'd like to propose that those getters never return null, but instead always return an array, even if it's empty.
> If people don't like this change, I can instead merely update the javadoc to reflect the fact that null may be returned.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-990) Making distributed cache getters in
JobContext never return null
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated MAPREDUCE-990:
------------------------------------
Status: Open (was: Patch Available)
The patch is stale
> Making distributed cache getters in JobContext never return null
> ----------------------------------------------------------------
>
> Key: MAPREDUCE-990
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-990
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Philip Zeyliger
> Assignee: Philip Zeyliger
> Priority: Minor
> Attachments: MAPREDUCE-990.patch, MAPREDUCE-990.patch.txt
>
>
> MAPREDUCE-898 moved distributed cache setters and getters into Job and JobContext. Since the API is new, I'd like to propose that those getters never return null, but instead always return an array, even if it's empty.
> If people don't like this change, I can instead merely update the javadoc to reflect the fact that null may be returned.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (MAPREDUCE-990) Making distributed cache getters
in JobContext never return null
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12756344#action_12756344 ]
Todd Lipcon commented on MAPREDUCE-990:
---------------------------------------
+1, lgtm. Mark as patch available so unit tests can run?
> Making distributed cache getters in JobContext never return null
> ----------------------------------------------------------------
>
> Key: MAPREDUCE-990
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-990
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Philip Zeyliger
> Assignee: Philip Zeyliger
> Priority: Minor
> Attachments: MAPREDUCE-990.patch.txt
>
>
> MAPREDUCE-898 moved distributed cache setters and getters into Job and JobContext. Since the API is new, I'd like to propose that those getters never return null, but instead always return an array, even if it's empty.
> If people don't like this change, I can instead merely update the javadoc to reflect the fact that null may be returned.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (MAPREDUCE-990) Making distributed cache getters in
JobContext never return null
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated MAPREDUCE-990:
--------------------------------
Status: Patch Available (was: Open)
> Making distributed cache getters in JobContext never return null
> ----------------------------------------------------------------
>
> Key: MAPREDUCE-990
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-990
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Philip Zeyliger
> Assignee: Philip Zeyliger
> Priority: Minor
> Attachments: MAPREDUCE-990.patch, MAPREDUCE-990.patch.txt
>
>
> MAPREDUCE-898 moved distributed cache setters and getters into Job and JobContext. Since the API is new, I'd like to propose that those getters never return null, but instead always return an array, even if it's empty.
> If people don't like this change, I can instead merely update the javadoc to reflect the fact that null may be returned.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.