[jira] [Commented] (HBASE-15066) Small improvements to Canary tool

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-15066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15081689#comment-15081689 ] 

Hadoop QA commented on HBASE-15066:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12780343/hbase-15066_v1.patch
  against master branch at commit 00656688f73c85ea9e6f5241ac852f72e774eeea.
  ATTACHMENT ID: 12780343

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 2.7.1)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}. The applied patch does not generate new checkstyle errors.

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

    {color:green}+1 site{color}.  The mvn post-site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

    {color:green}+1 zombies{color}. No zombie tests found running at the end of the build.

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/17111//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/17111//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/17111//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/17111//console

This message is automatically generated.

> Small improvements to Canary tool
> ---------------------------------
>
>                 Key: HBASE-15066
>                 URL: https://issues.apache.org/jira/browse/HBASE-15066
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Enis Soztutar
>            Assignee: Enis Soztutar
>             Fix For: 2.0.0, 1.3.0
>
>         Attachments: hbase-15066_v1.patch
>
>
> From an internal request from a user: 
> {quote}
> HBase comes with a canary tool which is very useful, but a few minor changes would make it substantially better. Specifically, you don't know what it's testing until it completes the test, so if it hangs, you can't tell where it's hanging. For example, if I run it with the -regionserver option, it sends get requests to each of the regionservers in some random order...
> And the same goes for the non-default mode, which hits each region for each table. 
> If it would just print a message prior to each 'get', it would be extremely helpful.
> {quote}
> This patch: 
>   - Adds debug statements for pre-operation steps. 
>   - Adds bin/hbase canary support 
>   - Fixes table names with patterns where the pattern was not matched previously. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)