You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2021/09/27 19:21:11 UTC
[GitHub] [calcite-avatica] asolimando opened a new pull request #154: [CALCITE-4600] ClassCastException for arrays with date/time/timestamp elements
asolimando opened a new pull request #154:
URL: https://github.com/apache/calcite-avatica/pull/154
Rebasing https://github.com/apache/calcite-avatica/pulls on master and fixing conflicts.
The original PR includes commits for both [CALCITE-4600] and [CALCITE-4602].
While fixing conflicts I found out that merged PRs for [CALCITE-4536] and [CALCITE-4757] added tests but did not enable them, so I have added two extra commits to enable them (I think it's needed since they are already merged and that code is untested at the moment).
PS: whenever a new data type is added to `@Override public ExecuteResult prepareAndExecute(`, it must be paired with an addition under `public static Collection<AccessorTestHelper> data()`, otherwise it won't be called.
PPS: I suggested to the committer to squash the first two commits starting with `[CALCITE-4600]` (I did not do it because it was like this in the original PR, it's easier to check what I changed) and leave the rest as separate commits for clarity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite-avatica] asolimando commented on pull request #154: [CALCITE-4600] ClassCastException for arrays with date/time/timestamp elements
Posted by GitBox <gi...@apache.org>.
asolimando commented on pull request #154:
URL: https://github.com/apache/calcite-avatica/pull/154#issuecomment-928979156
I can't reproduce the failure locally on MacOSX (I have tried few JVMs), and it seems to work fine in CI.
I made sure to skip test cache which sometimes fools me by running with: `./gradlew --no-build-cache cleanTest test`.
Could you share the relevant details of your environment so I can try to reproduce the issue?
Could you try if the failure happens with the original PR as well?
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite-avatica] julianhyde commented on pull request #154: [CALCITE-4600] ClassCastException for arrays with date/time/timestamp elements
Posted by GitBox <gi...@apache.org>.
julianhyde commented on pull request #154:
URL: https://github.com/apache/calcite-avatica/pull/154#issuecomment-932990517
I'll merge shortly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite-avatica] julianhyde closed pull request #154: [CALCITE-4600] ClassCastException for arrays with date/time/timestamp elements
Posted by GitBox <gi...@apache.org>.
julianhyde closed pull request #154:
URL: https://github.com/apache/calcite-avatica/pull/154
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite-avatica] asolimando commented on pull request #154: [CALCITE-4600] ClassCastException for arrays with date/time/timestamp elements
Posted by GitBox <gi...@apache.org>.
asolimando commented on pull request #154:
URL: https://github.com/apache/calcite-avatica/pull/154#issuecomment-932890001
Thanks @snuyanzin, I have tested it locally with different timezones and it works fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite-avatica] julianhyde commented on pull request #154: [CALCITE-4600] ClassCastException for arrays with date/time/timestamp elements
Posted by GitBox <gi...@apache.org>.
julianhyde commented on pull request #154:
URL: https://github.com/apache/calcite-avatica/pull/154#issuecomment-928531982
Thanks for doing this. I just ran your top commit and I got a couple of failures:
```
FAILURE 0.0sec, org.apache.calcite.avatica.AvaticaResultSetConversionsTest > testGetArray[30: org.apache.calcite.avatica.AvaticaResultSetConversionsTest$DateArrayAccessorTestHelper@164f5eb0]
java.lang.AssertionError
at org.junit.Assert.fail(Assert.java:86)
at org.junit.Assert.assertTrue(Assert.java:41)
at org.junit.Assert.assertTrue(Assert.java:52)
at org.apache.calcite.avatica.AvaticaResultSetConversionsTest$DateArrayAccessorTestHelper.testGetArray(AvaticaResultSetConversionsTest.java:639)
at org.apache.calcite.avatica.AvaticaResultSetConversionsTest.testGetArray(AvaticaResultSetConversionsTest.java:1282)
org.apache.calcite.avatica.AvaticaResultSetConversionsTest > testGetArray[30: org.apache.calcite.avatica.AvaticaResultSetConversionsTest$DateArrayAccessorTestHelper@164f5eb0] FAILED
java.lang.AssertionError
at org.junit.Assert.fail(Assert.java:86)
at org.junit.Assert.assertTrue(Assert.java:41)
at org.junit.Assert.assertTrue(Assert.java:52)
at org.apache.calcite.avatica.AvaticaResultSetConversionsTest$DateArrayAccessorTestHelper.testGetArray(AvaticaResultSetConversionsTest.java:639)
at org.apache.calcite.avatica.AvaticaResultSetConversionsTest.testGetArray(AvaticaResultSetConversionsTest.java:1282)
FAILURE 0.0sec, org.apache.calcite.avatica.AvaticaResultSetConversionsTest > testGetArray[31: org.apache.calcite.avatica.AvaticaResultSetConversionsTest$DateArrayAccessorTestHelper@705513b4]
java.lang.AssertionError
at org.junit.Assert.fail(Assert.java:86)
at org.junit.Assert.assertTrue(Assert.java:41)
at org.junit.Assert.assertTrue(Assert.java:52)
at org.apache.calcite.avatica.AvaticaResultSetConversionsTest$DateArrayAccessorTestHelper.testGetArray(AvaticaResultSetConversionsTest.java:639)
at org.apache.calcite.avatica.AvaticaResultSetConversionsTest.testGetArray(AvaticaResultSetConversionsTest.java:1282)
org.apache.calcite.avatica.AvaticaResultSetConversionsTest > testGetArray[31: org.apache.calcite.avatica.AvaticaResultSetConversionsTest$DateArrayAccessorTestHelper@705513b4] FAILED
java.lang.AssertionError
at org.junit.Assert.fail(Assert.java:86)
at org.junit.Assert.assertTrue(Assert.java:41)
at org.junit.Assert.assertTrue(Assert.java:52)
at org.apache.calcite.avatica.AvaticaResultSetConversionsTest$DateArrayAccessorTestHelper.testGetArray(AvaticaResultSetConversionsTest.java:639)
at org.apache.calcite.avatica.AvaticaResultSetConversionsTest.testGetArray(AvaticaResultSetConversionsTest.java:1282)
FAILURE 0.6sec, 1026 completed, 2 failed, 0 skipped, org.apache.calcite.avatica.AvaticaResultSetConversionsTest
0.5sec, 45 completed, 0 failed, 0 skipped, org.apache.calcite.avatica.AvaticaClosedStatementTest
```
Let's figure this out, and I'll merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite-avatica] snuyanzin commented on pull request #154: [CALCITE-4600] ClassCastException for arrays with date/time/timestamp elements
Posted by GitBox <gi...@apache.org>.
snuyanzin commented on pull request #154:
URL: https://github.com/apache/calcite-avatica/pull/154#issuecomment-932824993
I created a PR to this branch with a fix for a problem in different timezone
https://github.com/asolimando/calcite-avatica/pull/2/commits/d15ad090cea3e5210822e80c881a4220e458db80
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite-avatica] asolimando commented on pull request #154: [CALCITE-4600] ClassCastException for arrays with date/time/timestamp elements
Posted by GitBox <gi...@apache.org>.
asolimando commented on pull request #154:
URL: https://github.com/apache/calcite-avatica/pull/154#issuecomment-928979156
I can't reproduce the failure locally on MacOSX (I have tried few JVMs), and it seems to work fine in CI.
I made sure to skip test cache which sometimes fools me by running with: `./gradlew --no-build-cache cleanTest test`.
Could you share the relevant details of your environment so I can try to reproduce the issue?
Could you try if the failure happens with the original PR as well?
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite-avatica] julianhyde commented on pull request #154: [CALCITE-4600] ClassCastException for arrays with date/time/timestamp elements
Posted by GitBox <gi...@apache.org>.
julianhyde commented on pull request #154:
URL: https://github.com/apache/calcite-avatica/pull/154#issuecomment-928531982
Thanks for doing this. I just ran your top commit and I got a couple of failures:
```
FAILURE 0.0sec, org.apache.calcite.avatica.AvaticaResultSetConversionsTest > testGetArray[30: org.apache.calcite.avatica.AvaticaResultSetConversionsTest$DateArrayAccessorTestHelper@164f5eb0]
java.lang.AssertionError
at org.junit.Assert.fail(Assert.java:86)
at org.junit.Assert.assertTrue(Assert.java:41)
at org.junit.Assert.assertTrue(Assert.java:52)
at org.apache.calcite.avatica.AvaticaResultSetConversionsTest$DateArrayAccessorTestHelper.testGetArray(AvaticaResultSetConversionsTest.java:639)
at org.apache.calcite.avatica.AvaticaResultSetConversionsTest.testGetArray(AvaticaResultSetConversionsTest.java:1282)
org.apache.calcite.avatica.AvaticaResultSetConversionsTest > testGetArray[30: org.apache.calcite.avatica.AvaticaResultSetConversionsTest$DateArrayAccessorTestHelper@164f5eb0] FAILED
java.lang.AssertionError
at org.junit.Assert.fail(Assert.java:86)
at org.junit.Assert.assertTrue(Assert.java:41)
at org.junit.Assert.assertTrue(Assert.java:52)
at org.apache.calcite.avatica.AvaticaResultSetConversionsTest$DateArrayAccessorTestHelper.testGetArray(AvaticaResultSetConversionsTest.java:639)
at org.apache.calcite.avatica.AvaticaResultSetConversionsTest.testGetArray(AvaticaResultSetConversionsTest.java:1282)
FAILURE 0.0sec, org.apache.calcite.avatica.AvaticaResultSetConversionsTest > testGetArray[31: org.apache.calcite.avatica.AvaticaResultSetConversionsTest$DateArrayAccessorTestHelper@705513b4]
java.lang.AssertionError
at org.junit.Assert.fail(Assert.java:86)
at org.junit.Assert.assertTrue(Assert.java:41)
at org.junit.Assert.assertTrue(Assert.java:52)
at org.apache.calcite.avatica.AvaticaResultSetConversionsTest$DateArrayAccessorTestHelper.testGetArray(AvaticaResultSetConversionsTest.java:639)
at org.apache.calcite.avatica.AvaticaResultSetConversionsTest.testGetArray(AvaticaResultSetConversionsTest.java:1282)
org.apache.calcite.avatica.AvaticaResultSetConversionsTest > testGetArray[31: org.apache.calcite.avatica.AvaticaResultSetConversionsTest$DateArrayAccessorTestHelper@705513b4] FAILED
java.lang.AssertionError
at org.junit.Assert.fail(Assert.java:86)
at org.junit.Assert.assertTrue(Assert.java:41)
at org.junit.Assert.assertTrue(Assert.java:52)
at org.apache.calcite.avatica.AvaticaResultSetConversionsTest$DateArrayAccessorTestHelper.testGetArray(AvaticaResultSetConversionsTest.java:639)
at org.apache.calcite.avatica.AvaticaResultSetConversionsTest.testGetArray(AvaticaResultSetConversionsTest.java:1282)
FAILURE 0.6sec, 1026 completed, 2 failed, 0 skipped, org.apache.calcite.avatica.AvaticaResultSetConversionsTest
0.5sec, 45 completed, 0 failed, 0 skipped, org.apache.calcite.avatica.AvaticaClosedStatementTest
```
Let's figure this out, and I'll merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org