You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/23 22:11:56 UTC

[GitHub] [incubator-superset] graceguo-supercat opened a new pull request #11029: fix: dashboard edit button (again)

graceguo-supercat opened a new pull request #11029:
URL: https://github.com/apache/incubator-superset/pull/11029


   ### SUMMARY
   This is 2nd fix for the same problem in #11024. Originally the `edit` control is button so that we can set disabled attribute. Sorry i didn't test it :(
   But now it is `<span>` so the disabled attribute won't work.
   This PR is to fix the issue by hide the icon when user do not have edit permit.
   
   
   ### TEST PLAN
   CI and manual test
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [X] Has associated issue: #11024 #10394 
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   cc @nytai 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] graceguo-supercat merged pull request #11029: fix: dashboard edit button (again)

Posted by GitBox <gi...@apache.org>.
graceguo-supercat merged pull request #11029:
URL: https://github.com/apache/incubator-superset/pull/11029


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org