You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jorisvandenbossche (via GitHub)" <gi...@apache.org> on 2023/04/07 09:03:38 UTC
[GitHub] [arrow] jorisvandenbossche opened a new pull request, #34958: GH-34944: [Python] Fix crash when converting non-sequence object with getitem in pa.array()
jorisvandenbossche opened a new pull request, #34958:
URL: https://github.com/apache/arrow/pull/34958
### What changes are included in this PR?
Some python objects can pass the `PySequence_Check` without being "proper" sequences with a length, resulting in a subsequent `PySequence_Size` to fail, but we didn't check for python errors there, and so failed to properly raise this as a python exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche merged pull request #34958: GH-34944: [Python] Fix crash when converting non-sequence object with getitem in pa.array()
Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.
jorisvandenbossche merged PR #34958:
URL: https://github.com/apache/arrow/pull/34958
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34958: GH-34944: [Python] Fix crash when converting non-sequence object with getitem in pa.array()
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34958:
URL: https://github.com/apache/arrow/pull/34958#issuecomment-1500094872
:warning: GitHub issue #34944 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34958: GH-34944: [Python] Fix crash when converting non-sequence object with getitem in pa.array()
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34958:
URL: https://github.com/apache/arrow/pull/34958#issuecomment-1500094841
* Closes: #34944
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #34958: GH-34944: [Python] Fix crash when converting non-sequence object with getitem in pa.array()
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #34958:
URL: https://github.com/apache/arrow/pull/34958#issuecomment-1504780046
Benchmark runs are scheduled for baseline = c9e07f8e3c49838c7b4a1cec927341625eb3aba4 and contender = 61b89df503c85e892c0b1b4f0d02b08b26f9eae1. 61b89df503c85e892c0b1b4f0d02b08b26f9eae1 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/980f5b31d3e1465fa01487201d00eb8b...9a8e1802183d4b1694821a8b5d1d7567/)
[Failed] [test-mac-arm](https://conbench.ursa.dev/compare/runs/bb3c2be721974b94a534628dc4200af3...8a2e7b5d471f4aec92ec6649e52d31a3/)
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/6c83040df9234391bb589070013f9f65...ff7a94ecd162454ea9986af5919c43e3/)
[Finished :arrow_down:0.37% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/65e487a9a95645f19417a1a1d0d24261...17c494251be24af7975b923bd122b263/)
Buildkite builds:
[Finished] [`61b89df5` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2675)
[Failed] [`61b89df5` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2708)
[Finished] [`61b89df5` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2674)
[Finished] [`61b89df5` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2701)
[Finished] [`c9e07f8e` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2674)
[Failed] [`c9e07f8e` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2707)
[Finished] [`c9e07f8e` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2673)
[Finished] [`c9e07f8e` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2700)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org