[jira] [Commented] (DRILL-2532) Glob not always fired for DFS storage engine

["Adam Gilmore (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-2532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14377162#comment-14377162 ] 

Adam Gilmore commented on DRILL-2532:
-------------------------------------

I've modified the FileSelection create() implementation to always glob and then find the common path for the selectionRoot.  I feel this is far better than trying to parse the path ourselves and work out whether globbing is occurring in part of the path.

Happy to discuss other options, though.

> Glob not always fired for DFS storage engine
> --------------------------------------------
>
>                 Key: DRILL-2532
>                 URL: https://issues.apache.org/jira/browse/DRILL-2532
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Storage - Other
>    Affects Versions: 0.7.0, 0.8.0
>            Reporter: Adam Gilmore
>            Assignee: Adam Gilmore
>         Attachments: DRILL-2532.1.patch.txt
>
>
> Currently, globbing doesn't always fire for table names when the name doesn't include a * or ? character.
> This means, for example:
> {code}
> select * from dfs.tmp.`mytable/{1,2,3}`
> {code}
> does not fire the globbing (even though it is valid glob syntax for Hadoop).
> The culprit is in FileSelection that explicitly checks for * or ? before performing the globbing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)