You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Nicolas Spiegelberg (Created) (JIRA)" <ji...@apache.org> on 2011/10/19 23:59:10 UTC
[jira] [Created] (HBASE-4628) Enhance Table Create Presplit
Functionality within the HBase Shell
Enhance Table Create Presplit Functionality within the HBase Shell
------------------------------------------------------------------
Key: HBASE-4628
URL: https://issues.apache.org/jira/browse/HBASE-4628
Project: HBase
Issue Type: Improvement
Reporter: Nicolas Spiegelberg
Assignee: Nicolas Spiegelberg
Currently, we allow the user to presplit in the HBase shell by explicitly listing the startkey of all the region shards that they want. Instead, we should provide the RegionSplitter functionality of choosing a split algorithm, followed by the number of splits that they want.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4628) Enhance Table Create Presplit
Functionality within the HBase Shell
Posted by "Nicolas Spiegelberg (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolas Spiegelberg updated HBASE-4628:
---------------------------------------
Comment: was deleted
(was: cgist requested code review of "HBASE-4628 [jira] Enhance Table Create Presplit Functionality within the HBase Shell".
Reviewers: nspiegelberg, JIRA
[89-fb] Ported RegionSplitter and TestRegionSplitter from trunk
The RegionSplitter is useful for creating a table pre-split
into many regions, including two different algorithms for splitting
keys. This also includes the patch for HBASE-4627.
Currently, we allow the user to presplit in the HBase shell by explicitly listing the startkey of all the region shards that they want. Instead, we should provide the RegionSplitter functionality of choosing a split algorithm, followed by the number of splits that they want.
TEST PLAN
The TestRegionSplitter test suite.
REVISION DETAIL
https://reviews.facebook.net/D411
AFFECTED FILES
src/main/java/org/apache/hadoop/hbase/util/Bytes.java
src/main/java/org/apache/hadoop/hbase/util/RegionSplitter.java
src/test/java/org/apache/hadoop/hbase/util/TestRegionSplitter.java
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/831/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
)
> Enhance Table Create Presplit Functionality within the HBase Shell
> ------------------------------------------------------------------
>
> Key: HBASE-4628
> URL: https://issues.apache.org/jira/browse/HBASE-4628
> Project: HBase
> Issue Type: Improvement
> Reporter: Nicolas Spiegelberg
> Assignee: Nicolas Spiegelberg
> Attachments: HBASE-4628.D411.1.patch, HBASE-4628.D417.1.patch
>
>
> Currently, we allow the user to presplit in the HBase shell by explicitly listing the startkey of all the region shards that they want. Instead, we should provide the RegionSplitter functionality of choosing a split algorithm, followed by the number of splits that they want.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4628) Enhance Table Create Presplit
Functionality within the HBase Shell
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152431#comment-13152431 ]
Phabricator commented on HBASE-4628:
------------------------------------
cgist has committed the revision "HBASE-4628 [jira] Enhance Table Create Presplit Functionality within the HBase Shell".
REVISION DETAIL
https://reviews.facebook.net/D429
COMMIT
https://reviews.facebook.net/rHBASE1203413
> Enhance Table Create Presplit Functionality within the HBase Shell
> ------------------------------------------------------------------
>
> Key: HBASE-4628
> URL: https://issues.apache.org/jira/browse/HBASE-4628
> Project: HBase
> Issue Type: Improvement
> Reporter: Nicolas Spiegelberg
> Assignee: Nicolas Spiegelberg
> Fix For: 0.94.0
>
> Attachments: HBASE-4628.D411.1.patch, HBASE-4628.D417.1.patch, HBASE-4628.D417.2.patch, HBASE-4628.D429.1.patch
>
>
> Currently, we allow the user to presplit in the HBase shell by explicitly listing the startkey of all the region shards that they want. Instead, we should provide the RegionSplitter functionality of choosing a split algorithm, followed by the number of splits that they want.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4628) Enhance Table Create Presplit
Functionality within the HBase Shell
Posted by "Nicolas Spiegelberg (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolas Spiegelberg updated HBASE-4628:
---------------------------------------
Comment: was deleted
(was: nspiegelberg has accepted the revision "HBASE-4628 [jira] Enhance Table Create Presplit Functionality within the HBase Shell".
lgtm! Thanks for the contribution
REVISION DETAIL
https://reviews.facebook.net/D417
)
> Enhance Table Create Presplit Functionality within the HBase Shell
> ------------------------------------------------------------------
>
> Key: HBASE-4628
> URL: https://issues.apache.org/jira/browse/HBASE-4628
> Project: HBase
> Issue Type: Improvement
> Reporter: Nicolas Spiegelberg
> Assignee: Nicolas Spiegelberg
> Attachments: HBASE-4628.D411.1.patch, HBASE-4628.D417.1.patch, HBASE-4628.D417.2.patch, HBASE-4628.D429.1.patch
>
>
> Currently, we allow the user to presplit in the HBase shell by explicitly listing the startkey of all the region shards that they want. Instead, we should provide the RegionSplitter functionality of choosing a split algorithm, followed by the number of splits that they want.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4628) Enhance Table Create Presplit
Functionality within the HBase Shell
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148706#comment-13148706 ]
Phabricator commented on HBASE-4628:
------------------------------------
cgist has abandoned the revision "HBASE-4628 [jira] Enhance Table Create Presplit Functionality within the HBase Shell".
REVISION DETAIL
https://reviews.facebook.net/D411
> Enhance Table Create Presplit Functionality within the HBase Shell
> ------------------------------------------------------------------
>
> Key: HBASE-4628
> URL: https://issues.apache.org/jira/browse/HBASE-4628
> Project: HBase
> Issue Type: Improvement
> Reporter: Nicolas Spiegelberg
> Assignee: Nicolas Spiegelberg
> Attachments: HBASE-4628.D411.1.patch, HBASE-4628.D417.1.patch
>
>
> Currently, we allow the user to presplit in the HBase shell by explicitly listing the startkey of all the region shards that they want. Instead, we should provide the RegionSplitter functionality of choosing a split algorithm, followed by the number of splits that they want.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4628) Enhance Table Create Presplit
Functionality within the HBase Shell
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148967#comment-13148967 ]
Phabricator commented on HBASE-4628:
------------------------------------
nspiegelberg has requested changes to the revision "HBASE-4628 [jira] Enhance Table Create Presplit Functionality within the HBase Shell".
was this change ported to trunk or just 89-fb? I cannot apply this patch on top of trunk.
REVISION DETAIL
https://reviews.facebook.net/D417
> Enhance Table Create Presplit Functionality within the HBase Shell
> ------------------------------------------------------------------
>
> Key: HBASE-4628
> URL: https://issues.apache.org/jira/browse/HBASE-4628
> Project: HBase
> Issue Type: Improvement
> Reporter: Nicolas Spiegelberg
> Assignee: Nicolas Spiegelberg
> Attachments: HBASE-4628.D411.1.patch, HBASE-4628.D417.1.patch, HBASE-4628.D417.2.patch, HBASE-4628.D429.1.patch
>
>
> Currently, we allow the user to presplit in the HBase shell by explicitly listing the startkey of all the region shards that they want. Instead, we should provide the RegionSplitter functionality of choosing a split algorithm, followed by the number of splits that they want.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4628) Enhance Table Create Presplit
Functionality within the HBase Shell
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149789#comment-13149789 ]
Phabricator commented on HBASE-4628:
------------------------------------
cgist has commented on the revision "HBASE-4628 [jira] Enhance Table Create Presplit Functionality within the HBase Shell".
This diff was only intended for 89-fb. There is a separate diff for apache trunk D429.
REVISION DETAIL
https://reviews.facebook.net/D417
> Enhance Table Create Presplit Functionality within the HBase Shell
> ------------------------------------------------------------------
>
> Key: HBASE-4628
> URL: https://issues.apache.org/jira/browse/HBASE-4628
> Project: HBase
> Issue Type: Improvement
> Reporter: Nicolas Spiegelberg
> Assignee: Nicolas Spiegelberg
> Attachments: HBASE-4628.D411.1.patch, HBASE-4628.D417.1.patch, HBASE-4628.D417.2.patch, HBASE-4628.D429.1.patch
>
>
> Currently, we allow the user to presplit in the HBase shell by explicitly listing the startkey of all the region shards that they want. Instead, we should provide the RegionSplitter functionality of choosing a split algorithm, followed by the number of splits that they want.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4628) Enhance Table Create Presplit
Functionality within the HBase Shell
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-4628:
-------------------------------
Attachment: HBASE-4628.D417.2.patch
cgist updated the revision "HBASE-4628 [jira] Enhance Table Create Presplit Functionality within the HBase Shell".
Reviewers: nspiegelberg, JIRA
Added a line which was missing from admin.rb due to an unrelated commit
REVISION DETAIL
https://reviews.facebook.net/D417
AFFECTED FILES
src/main/ruby/hbase.rb
src/main/ruby/hbase/admin.rb
src/main/ruby/shell/commands/create.rb
> Enhance Table Create Presplit Functionality within the HBase Shell
> ------------------------------------------------------------------
>
> Key: HBASE-4628
> URL: https://issues.apache.org/jira/browse/HBASE-4628
> Project: HBase
> Issue Type: Improvement
> Reporter: Nicolas Spiegelberg
> Assignee: Nicolas Spiegelberg
> Attachments: HBASE-4628.D411.1.patch, HBASE-4628.D417.1.patch, HBASE-4628.D417.2.patch, HBASE-4628.D429.1.patch
>
>
> Currently, we allow the user to presplit in the HBase shell by explicitly listing the startkey of all the region shards that they want. Instead, we should provide the RegionSplitter functionality of choosing a split algorithm, followed by the number of splits that they want.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4628) Enhance Table Create Presplit
Functionality within the HBase Shell
Posted by "Nicolas Spiegelberg (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolas Spiegelberg updated HBASE-4628:
---------------------------------------
Comment: was deleted
(was: nspiegelberg has requested changes to the revision "HBASE-4628 [jira] Enhance Table Create Presplit Functionality within the HBase Shell".
was this change ported to trunk or just 89-fb? I cannot apply this patch on top of trunk.
REVISION DETAIL
https://reviews.facebook.net/D417
)
> Enhance Table Create Presplit Functionality within the HBase Shell
> ------------------------------------------------------------------
>
> Key: HBASE-4628
> URL: https://issues.apache.org/jira/browse/HBASE-4628
> Project: HBase
> Issue Type: Improvement
> Reporter: Nicolas Spiegelberg
> Assignee: Nicolas Spiegelberg
> Attachments: HBASE-4628.D411.1.patch, HBASE-4628.D417.1.patch, HBASE-4628.D417.2.patch, HBASE-4628.D429.1.patch
>
>
> Currently, we allow the user to presplit in the HBase shell by explicitly listing the startkey of all the region shards that they want. Instead, we should provide the RegionSplitter functionality of choosing a split algorithm, followed by the number of splits that they want.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4628) Enhance Table Create Presplit
Functionality within the HBase Shell
Posted by "Nicolas Spiegelberg (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolas Spiegelberg updated HBASE-4628:
---------------------------------------
Comment: was deleted
(was: cgist has abandoned the revision "HBASE-4628 [jira] Enhance Table Create Presplit Functionality within the HBase Shell".
REVISION DETAIL
https://reviews.facebook.net/D411
)
> Enhance Table Create Presplit Functionality within the HBase Shell
> ------------------------------------------------------------------
>
> Key: HBASE-4628
> URL: https://issues.apache.org/jira/browse/HBASE-4628
> Project: HBase
> Issue Type: Improvement
> Reporter: Nicolas Spiegelberg
> Assignee: Nicolas Spiegelberg
> Attachments: HBASE-4628.D411.1.patch, HBASE-4628.D417.1.patch
>
>
> Currently, we allow the user to presplit in the HBase shell by explicitly listing the startkey of all the region shards that they want. Instead, we should provide the RegionSplitter functionality of choosing a split algorithm, followed by the number of splits that they want.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4628) Enhance Table Create Presplit
Functionality within the HBase Shell
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-4628:
-------------------------------
Attachment: HBASE-4628.D411.1.patch
cgist requested code review of "HBASE-4628 [jira] Enhance Table Create Presplit Functionality within the HBase Shell".
Reviewers: nspiegelberg, JIRA
[89-fb] Ported RegionSplitter and TestRegionSplitter from trunk
The RegionSplitter is useful for creating a table pre-split
into many regions, including two different algorithms for splitting
keys. This also includes the patch for HBASE-4627.
Currently, we allow the user to presplit in the HBase shell by explicitly listing the startkey of all the region shards that they want. Instead, we should provide the RegionSplitter functionality of choosing a split algorithm, followed by the number of splits that they want.
TEST PLAN
The TestRegionSplitter test suite.
REVISION DETAIL
https://reviews.facebook.net/D411
AFFECTED FILES
src/main/java/org/apache/hadoop/hbase/util/Bytes.java
src/main/java/org/apache/hadoop/hbase/util/RegionSplitter.java
src/test/java/org/apache/hadoop/hbase/util/TestRegionSplitter.java
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/831/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> Enhance Table Create Presplit Functionality within the HBase Shell
> ------------------------------------------------------------------
>
> Key: HBASE-4628
> URL: https://issues.apache.org/jira/browse/HBASE-4628
> Project: HBase
> Issue Type: Improvement
> Reporter: Nicolas Spiegelberg
> Assignee: Nicolas Spiegelberg
> Attachments: HBASE-4628.D411.1.patch
>
>
> Currently, we allow the user to presplit in the HBase shell by explicitly listing the startkey of all the region shards that they want. Instead, we should provide the RegionSplitter functionality of choosing a split algorithm, followed by the number of splits that they want.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4628) Enhance Table Create Presplit
Functionality within the HBase Shell
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151448#comment-13151448 ]
Phabricator commented on HBASE-4628:
------------------------------------
Kannan has accepted the revision "HBASE-4628 [jira] Enhance Table Create Presplit Functionality within the HBase Shell".
Looks great! Sweet feature.
Nicolas will walk me through the commit flow tomorrow. So should get committed tomorrow.
REVISION DETAIL
https://reviews.facebook.net/D417
> Enhance Table Create Presplit Functionality within the HBase Shell
> ------------------------------------------------------------------
>
> Key: HBASE-4628
> URL: https://issues.apache.org/jira/browse/HBASE-4628
> Project: HBase
> Issue Type: Improvement
> Reporter: Nicolas Spiegelberg
> Assignee: Nicolas Spiegelberg
> Attachments: HBASE-4628.D411.1.patch, HBASE-4628.D417.1.patch, HBASE-4628.D417.2.patch, HBASE-4628.D429.1.patch
>
>
> Currently, we allow the user to presplit in the HBase shell by explicitly listing the startkey of all the region shards that they want. Instead, we should provide the RegionSplitter functionality of choosing a split algorithm, followed by the number of splits that they want.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-4628) Enhance Table Create Presplit
Functionality within the HBase Shell
Posted by "Kannan Muthukkaruppan (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kannan Muthukkaruppan resolved HBASE-4628.
------------------------------------------
Resolution: Fixed
Fix Version/s: 0.94.0
> Enhance Table Create Presplit Functionality within the HBase Shell
> ------------------------------------------------------------------
>
> Key: HBASE-4628
> URL: https://issues.apache.org/jira/browse/HBASE-4628
> Project: HBase
> Issue Type: Improvement
> Reporter: Nicolas Spiegelberg
> Assignee: Nicolas Spiegelberg
> Fix For: 0.94.0
>
> Attachments: HBASE-4628.D411.1.patch, HBASE-4628.D417.1.patch, HBASE-4628.D417.2.patch, HBASE-4628.D429.1.patch
>
>
> Currently, we allow the user to presplit in the HBase shell by explicitly listing the startkey of all the region shards that they want. Instead, we should provide the RegionSplitter functionality of choosing a split algorithm, followed by the number of splits that they want.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4628) Enhance Table Create Presplit
Functionality within the HBase Shell
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-4628:
-------------------------------
Attachment: HBASE-4628.D429.1.patch
cgist requested code review of "HBASE-4628 [jira] Enhance Table Create Presplit Functionality within the HBase Shell".
Reviewers: nspiegelberg, JIRA
HBase shell can algorithmically split a new table at creation
This change adds optional arguments to the HBase shell's create command
to split a table into a specified number of regions using a specified
splitting algorithm as defined by RegionSplitter.
Currently, we allow the user to presplit in the HBase shell by explicitly listing the startkey of all the region shards that they want. Instead, we should provide the RegionSplitter functionality of choosing a split algorithm, followed by the number of splits that they want.
TEST PLAN
Created tables with and without splits using the shell; also attampted
to give incorrect arguments to shell create command.
REVISION DETAIL
https://reviews.facebook.net/D429
AFFECTED FILES
src/main/java/org/apache/hadoop/hbase/util/RegionSplitter.java
src/main/ruby/hbase.rb
src/main/ruby/hbase/admin.rb
src/main/ruby/shell/commands/create.rb
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/855/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> Enhance Table Create Presplit Functionality within the HBase Shell
> ------------------------------------------------------------------
>
> Key: HBASE-4628
> URL: https://issues.apache.org/jira/browse/HBASE-4628
> Project: HBase
> Issue Type: Improvement
> Reporter: Nicolas Spiegelberg
> Assignee: Nicolas Spiegelberg
> Attachments: HBASE-4628.D411.1.patch, HBASE-4628.D417.1.patch, HBASE-4628.D429.1.patch
>
>
> Currently, we allow the user to presplit in the HBase shell by explicitly listing the startkey of all the region shards that they want. Instead, we should provide the RegionSplitter functionality of choosing a split algorithm, followed by the number of splits that they want.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4628) Enhance Table Create Presplit
Functionality within the HBase Shell
Posted by "Nicolas Spiegelberg (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolas Spiegelberg updated HBASE-4628:
---------------------------------------
Comment: was deleted
(was: cgist has commented on the revision "HBASE-4628 [jira] Enhance Table Create Presplit Functionality within the HBase Shell".
This diff was only intended for 89-fb. There is a separate diff for apache trunk D429.
REVISION DETAIL
https://reviews.facebook.net/D417
)
> Enhance Table Create Presplit Functionality within the HBase Shell
> ------------------------------------------------------------------
>
> Key: HBASE-4628
> URL: https://issues.apache.org/jira/browse/HBASE-4628
> Project: HBase
> Issue Type: Improvement
> Reporter: Nicolas Spiegelberg
> Assignee: Nicolas Spiegelberg
> Attachments: HBASE-4628.D411.1.patch, HBASE-4628.D417.1.patch, HBASE-4628.D417.2.patch, HBASE-4628.D429.1.patch
>
>
> Currently, we allow the user to presplit in the HBase shell by explicitly listing the startkey of all the region shards that they want. Instead, we should provide the RegionSplitter functionality of choosing a split algorithm, followed by the number of splits that they want.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4628) Enhance Table Create Presplit
Functionality within the HBase Shell
Posted by "Nicolas Spiegelberg (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolas Spiegelberg updated HBASE-4628:
---------------------------------------
Comment: was deleted
(was: cgist requested code review of "HBASE-4628 [jira] Enhance Table Create Presplit Functionality within the HBase Shell".
Reviewers: nspiegelberg, JIRA
[89-fb] HBase shell can pre-split a new table at creation
THis change adds optional arguments to the HBase shell's create command
to split a tabel into a specified number of regions using a specified
splitting algorithm as defined by RegionSplitter.
Currently, we allow the user to presplit in the HBase shell by explicitly listing the startkey of all the region shards that they want. Instead, we should provide the RegionSplitter functionality of choosing a split algorithm, followed by the number of splits that they want.
TEST PLAN
Created tables with and without splits using the shell; also attempted
to give incorrect arguments to shell create command.
REVISION DETAIL
https://reviews.facebook.net/D417
AFFECTED FILES
src/main/ruby/hbase.rb
src/main/ruby/hbase/admin.rb
src/main/ruby/shell/commands/create.rb
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/837/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
)
> Enhance Table Create Presplit Functionality within the HBase Shell
> ------------------------------------------------------------------
>
> Key: HBASE-4628
> URL: https://issues.apache.org/jira/browse/HBASE-4628
> Project: HBase
> Issue Type: Improvement
> Reporter: Nicolas Spiegelberg
> Assignee: Nicolas Spiegelberg
> Attachments: HBASE-4628.D411.1.patch, HBASE-4628.D417.1.patch, HBASE-4628.D417.2.patch, HBASE-4628.D429.1.patch
>
>
> Currently, we allow the user to presplit in the HBase shell by explicitly listing the startkey of all the region shards that they want. Instead, we should provide the RegionSplitter functionality of choosing a split algorithm, followed by the number of splits that they want.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4628) Enhance Table Create Presplit
Functionality within the HBase Shell
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152625#comment-13152625 ]
Hudson commented on HBASE-4628:
-------------------------------
Integrated in HBase-TRUNK #2453 (See [https://builds.apache.org/job/HBase-TRUNK/2453/])
HBASE-4628 [jira] Enhance Table Create Presplit Functionality within the HBase
Shell
Summary:
HBase shell can algorithmically split a new table at creation
This change adds optional arguments to the HBase shell's create command
to split a table into a specified number of regions using a specified
splitting algorithm as defined by RegionSplitter.
Currently, we allow the user to presplit in the HBase shell by explicitly
listing the startkey of all the region shards that they want. Instead, we
should provide the RegionSplitter functionality of choosing a split algorithm,
followed by the number of splits that they want.
Test Plan:
Created tables with and without splits using the shell; also attampted
to give incorrect arguments to shell create command.
Reviewers: nspiegelberg, JIRA
Reviewed By: nspiegelberg
CC: nspiegelberg, lhofhansl
Differential Revision: 429
kannan :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/RegionSplitter.java
* /hbase/trunk/src/main/ruby/hbase.rb
* /hbase/trunk/src/main/ruby/hbase/admin.rb
* /hbase/trunk/src/main/ruby/shell/commands/create.rb
> Enhance Table Create Presplit Functionality within the HBase Shell
> ------------------------------------------------------------------
>
> Key: HBASE-4628
> URL: https://issues.apache.org/jira/browse/HBASE-4628
> Project: HBase
> Issue Type: Improvement
> Reporter: Nicolas Spiegelberg
> Assignee: Nicolas Spiegelberg
> Fix For: 0.94.0
>
> Attachments: HBASE-4628.D411.1.patch, HBASE-4628.D417.1.patch, HBASE-4628.D417.2.patch, HBASE-4628.D429.1.patch
>
>
> Currently, we allow the user to presplit in the HBase shell by explicitly listing the startkey of all the region shards that they want. Instead, we should provide the RegionSplitter functionality of choosing a split algorithm, followed by the number of splits that they want.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4628) Enhance Table Create Presplit
Functionality within the HBase Shell
Posted by "Nicolas Spiegelberg (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151766#comment-13151766 ]
Nicolas Spiegelberg commented on HBASE-4628:
--------------------------------------------
A little confusing to people looking here. D429 is for trunk (0.94). D417 is for 0.89-fb.
> Enhance Table Create Presplit Functionality within the HBase Shell
> ------------------------------------------------------------------
>
> Key: HBASE-4628
> URL: https://issues.apache.org/jira/browse/HBASE-4628
> Project: HBase
> Issue Type: Improvement
> Reporter: Nicolas Spiegelberg
> Assignee: Nicolas Spiegelberg
> Attachments: HBASE-4628.D411.1.patch, HBASE-4628.D417.1.patch, HBASE-4628.D417.2.patch, HBASE-4628.D429.1.patch
>
>
> Currently, we allow the user to presplit in the HBase shell by explicitly listing the startkey of all the region shards that they want. Instead, we should provide the RegionSplitter functionality of choosing a split algorithm, followed by the number of splits that they want.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4628) Enhance Table Create Presplit
Functionality within the HBase Shell
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148700#comment-13148700 ]
Phabricator commented on HBASE-4628:
------------------------------------
nspiegelberg has commented on the revision "HBASE-4628 [jira] Enhance Table Create Presplit Functionality within the HBase Shell".
Since this patch has been accepted into apache trunk, you don't need to make a patch for 89-fb. I'll automatically pull it in. We're just stalled on a previous commit. Go ahead and abandone this review.
REVISION DETAIL
https://reviews.facebook.net/D411
> Enhance Table Create Presplit Functionality within the HBase Shell
> ------------------------------------------------------------------
>
> Key: HBASE-4628
> URL: https://issues.apache.org/jira/browse/HBASE-4628
> Project: HBase
> Issue Type: Improvement
> Reporter: Nicolas Spiegelberg
> Assignee: Nicolas Spiegelberg
> Attachments: HBASE-4628.D411.1.patch, HBASE-4628.D417.1.patch
>
>
> Currently, we allow the user to presplit in the HBase shell by explicitly listing the startkey of all the region shards that they want. Instead, we should provide the RegionSplitter functionality of choosing a split algorithm, followed by the number of splits that they want.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4628) Enhance Table Create Presplit
Functionality within the HBase Shell
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149970#comment-13149970 ]
Phabricator commented on HBASE-4628:
------------------------------------
nspiegelberg has accepted the revision "HBASE-4628 [jira] Enhance Table Create Presplit Functionality within the HBase Shell".
REVISION DETAIL
https://reviews.facebook.net/D429
> Enhance Table Create Presplit Functionality within the HBase Shell
> ------------------------------------------------------------------
>
> Key: HBASE-4628
> URL: https://issues.apache.org/jira/browse/HBASE-4628
> Project: HBase
> Issue Type: Improvement
> Reporter: Nicolas Spiegelberg
> Assignee: Nicolas Spiegelberg
> Attachments: HBASE-4628.D411.1.patch, HBASE-4628.D417.1.patch, HBASE-4628.D417.2.patch, HBASE-4628.D429.1.patch
>
>
> Currently, we allow the user to presplit in the HBase shell by explicitly listing the startkey of all the region shards that they want. Instead, we should provide the RegionSplitter functionality of choosing a split algorithm, followed by the number of splits that they want.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4628) Enhance Table Create Presplit
Functionality within the HBase Shell
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148703#comment-13148703 ]
Phabricator commented on HBASE-4628:
------------------------------------
nspiegelberg has accepted the revision "HBASE-4628 [jira] Enhance Table Create Presplit Functionality within the HBase Shell".
lgtm! Thanks for the contribution
REVISION DETAIL
https://reviews.facebook.net/D417
> Enhance Table Create Presplit Functionality within the HBase Shell
> ------------------------------------------------------------------
>
> Key: HBASE-4628
> URL: https://issues.apache.org/jira/browse/HBASE-4628
> Project: HBase
> Issue Type: Improvement
> Reporter: Nicolas Spiegelberg
> Assignee: Nicolas Spiegelberg
> Attachments: HBASE-4628.D411.1.patch, HBASE-4628.D417.1.patch
>
>
> Currently, we allow the user to presplit in the HBase shell by explicitly listing the startkey of all the region shards that they want. Instead, we should provide the RegionSplitter functionality of choosing a split algorithm, followed by the number of splits that they want.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4628) Enhance Table Create Presplit
Functionality within the HBase Shell
Posted by "Lars Hofhansl (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152562#comment-13152562 ]
Lars Hofhansl commented on HBASE-4628:
--------------------------------------
Looks like this is breaking TestShell.
> Enhance Table Create Presplit Functionality within the HBase Shell
> ------------------------------------------------------------------
>
> Key: HBASE-4628
> URL: https://issues.apache.org/jira/browse/HBASE-4628
> Project: HBase
> Issue Type: Improvement
> Reporter: Nicolas Spiegelberg
> Assignee: Nicolas Spiegelberg
> Fix For: 0.94.0
>
> Attachments: HBASE-4628.D411.1.patch, HBASE-4628.D417.1.patch, HBASE-4628.D417.2.patch, HBASE-4628.D429.1.patch
>
>
> Currently, we allow the user to presplit in the HBase shell by explicitly listing the startkey of all the region shards that they want. Instead, we should provide the RegionSplitter functionality of choosing a split algorithm, followed by the number of splits that they want.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4628) Enhance Table Create Presplit
Functionality within the HBase Shell
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151861#comment-13151861 ]
Phabricator commented on HBASE-4628:
------------------------------------
lhofhansl has commented on the revision "HBASE-4628 [jira] Enhance Table Create Presplit Functionality within the HBase Shell".
+1 looks good to me
REVISION DETAIL
https://reviews.facebook.net/D429
> Enhance Table Create Presplit Functionality within the HBase Shell
> ------------------------------------------------------------------
>
> Key: HBASE-4628
> URL: https://issues.apache.org/jira/browse/HBASE-4628
> Project: HBase
> Issue Type: Improvement
> Reporter: Nicolas Spiegelberg
> Assignee: Nicolas Spiegelberg
> Attachments: HBASE-4628.D411.1.patch, HBASE-4628.D417.1.patch, HBASE-4628.D417.2.patch, HBASE-4628.D429.1.patch
>
>
> Currently, we allow the user to presplit in the HBase shell by explicitly listing the startkey of all the region shards that they want. Instead, we should provide the RegionSplitter functionality of choosing a split algorithm, followed by the number of splits that they want.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4628) Enhance Table Create Presplit
Functionality within the HBase Shell
Posted by "Nicolas Spiegelberg (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nicolas Spiegelberg updated HBASE-4628:
---------------------------------------
Comment: was deleted
(was: nspiegelberg has commented on the revision "HBASE-4628 [jira] Enhance Table Create Presplit Functionality within the HBase Shell".
Since this patch has been accepted into apache trunk, you don't need to make a patch for 89-fb. I'll automatically pull it in. We're just stalled on a previous commit. Go ahead and abandone this review.
REVISION DETAIL
https://reviews.facebook.net/D411
)
> Enhance Table Create Presplit Functionality within the HBase Shell
> ------------------------------------------------------------------
>
> Key: HBASE-4628
> URL: https://issues.apache.org/jira/browse/HBASE-4628
> Project: HBase
> Issue Type: Improvement
> Reporter: Nicolas Spiegelberg
> Assignee: Nicolas Spiegelberg
> Attachments: HBASE-4628.D411.1.patch, HBASE-4628.D417.1.patch
>
>
> Currently, we allow the user to presplit in the HBase shell by explicitly listing the startkey of all the region shards that they want. Instead, we should provide the RegionSplitter functionality of choosing a split algorithm, followed by the number of splits that they want.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4628) Enhance Table Create Presplit
Functionality within the HBase Shell
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-4628:
-------------------------------
Attachment: HBASE-4628.D417.1.patch
cgist requested code review of "HBASE-4628 [jira] Enhance Table Create Presplit Functionality within the HBase Shell".
Reviewers: nspiegelberg, JIRA
[89-fb] HBase shell can pre-split a new table at creation
THis change adds optional arguments to the HBase shell's create command
to split a tabel into a specified number of regions using a specified
splitting algorithm as defined by RegionSplitter.
Currently, we allow the user to presplit in the HBase shell by explicitly listing the startkey of all the region shards that they want. Instead, we should provide the RegionSplitter functionality of choosing a split algorithm, followed by the number of splits that they want.
TEST PLAN
Created tables with and without splits using the shell; also attempted
to give incorrect arguments to shell create command.
REVISION DETAIL
https://reviews.facebook.net/D417
AFFECTED FILES
src/main/ruby/hbase.rb
src/main/ruby/hbase/admin.rb
src/main/ruby/shell/commands/create.rb
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/837/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> Enhance Table Create Presplit Functionality within the HBase Shell
> ------------------------------------------------------------------
>
> Key: HBASE-4628
> URL: https://issues.apache.org/jira/browse/HBASE-4628
> Project: HBase
> Issue Type: Improvement
> Reporter: Nicolas Spiegelberg
> Assignee: Nicolas Spiegelberg
> Attachments: HBASE-4628.D411.1.patch, HBASE-4628.D417.1.patch
>
>
> Currently, we allow the user to presplit in the HBase shell by explicitly listing the startkey of all the region shards that they want. Instead, we should provide the RegionSplitter functionality of choosing a split algorithm, followed by the number of splits that they want.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira