[jira] [Comment Edited] (CALCITE-4766) I think this condition is always true, so we need not to check it.

["Stamatis Zampetakis (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-4766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17412474#comment-17412474 ] 

Stamatis Zampetakis edited comment on CALCITE-4766 at 9/9/21, 9:35 AM:
-----------------------------------------------------------------------

You are obviously right; couple of comments for the JIRA itself.

The JIRA summary should be a short meaningful statement describing the problem, feature, or proposed change. In this case for instance it should be something like:

{noformat}
Remove unreachable code from SqlValidatorImpl#performUnconditionalRewrites for VALUES node
{noformat}
According to the Calcite conventions, the summary should not end with a period.

Also when you refer to code it is preferred to use plain text inside \{code\} tags or/and permalinks to the repository instead of images.

Please apply the necessary changes, create a PR on GitHub, and ping me to merge it, thanks. 



was (Author: zabetak):
You are obviously right; couple of comments for the JIRA itself.

The JIRA summary should be a short meaningful statement describing the problem, feature, or proposed change. In this case for instance it should be something like:

{noformat}
Remove unreachable code from SqlValidatorImpl#performUnconditionalRewrites for VALUES node
{noformat}
According to the Calcite conventions, the summary should not end with a period.

Also when you refer to code it is preferred to use plain text inside {code} tags or/and permalinks to the repository instead of images.

Please apply the necessary changes, create a PR on GitHub, and ping me to merge it, thanks. 


> I think this condition is always true, so we need not to check it.
> ------------------------------------------------------------------
>
>                 Key: CALCITE-4766
>                 URL: https://issues.apache.org/jira/browse/CALCITE-4766
>             Project: Calcite
>          Issue Type: Improvement
>            Reporter: Jianhui Dong
>            Priority: Minor
>         Attachments: image-2021-09-08-15-46-09-395.png
>
>
> in SqlValidatorImpl line 1387, there is a line `if (underFrom || true)`:
> !image-2021-09-08-15-46-09-395.png!
> The condition is always true and I think we can remove this condition.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)