[jira] [Work logged] (ARTEMIS-3650) rework assembly creation to simplify and ease maintenance

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ARTEMIS-3650?focusedWorklogId=710066&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-710066 ]

ASF GitHub Bot logged work on ARTEMIS-3650:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 17/Jan/22 17:22
            Start Date: 17/Jan/22 17:22
    Worklog Time Spent: 10m 
      Work Description: gemmellr commented on pull request #3919:
URL: https://github.com/apache/activemq-artemis/pull/3919#issuecomment-1014756505


   This produces almost the same assembly lib dir as before except a few small changes. It adds a tiny transitive dependency of guava that was being excluded (I excluded its others, mostly annotation related, but excluding this one causes compilation failure with errorprone), removes the artemis-commons test jar that shouldnt have been there, removes the artemis-rest jar (not usuable on its own anyway as it has many already-omitted deps; there are steps in the docs to emit the needed bits that will be unaffected by the assembly change), and finally adds in another netty transitive dependency that was previously being omitted due to lack of explicit inclusion much like the problem in #3887 (this change would have prevented that from occurring).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 710066)
    Remaining Estimate: 0h
            Time Spent: 10m

> rework assembly creation to simplify and ease maintenance
> ---------------------------------------------------------
>
>                 Key: ARTEMIS-3650
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-3650
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>    Affects Versions: 2.20.0
>            Reporter: Robbie Gemmell
>            Priority: Major
>             Fix For: 2.21.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The current assembly creation process is rather verbose, and can also be somewhat problematic as result of effectively specifying every jar to include, often meaning it can both fail to pick up certain changes that occur in dependencies of the maven modules that then breaks things (e.g ARTEMIS-3616), or in turn also masking issues in the modules that could otherwise be visible and noticed in the assembly otherwise (e.g some of the scope et changes made in the coming diff). 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)