[GitHub] [pinot] npawar commented on pull request #8815: Allow moveToFinalLocation in METADATA push based on config

[GitBox <gi...@apache.org>]

npawar commented on PR #8815:
URL: https://github.com/apache/pinot/pull/8815#issuecomment-1145156435

   > (MAJOR) Have we tested this change? I'm pretty sure it won't work as expected. For metadata push, the local segment file only contains the segment metadata, and that is what we'll move to the deep store without the actual segment content.
   
   hmm you might be right. i tested the move, but missed testing the part of it being metadata only.
   Will fix it in a followup PR, and see if there's a test which I can add this flag to


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org