You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/09/10 03:58:30 UTC

[GitHub] [spark] mingjialiu commented on pull request #29564: [WIP][SPARK-32708] Query optimization fails to reuse exchange with DataSourceV2

mingjialiu commented on pull request #29564:
URL: https://github.com/apache/spark/pull/29564#issuecomment-689963482


   > If exchange reuse is broken, it means plan equality is broken somewhere. I think `Seq[Expression]` is OK as long as we canonicalize it before comparing it. `FileSourceScanExec` also contains `Seq[Expression]` and it's fine.
   > 
   > Can you look into it more and have a more surgical fix?
   
   Updated with a more surgical fix. Please review.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org