You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Dmitriy V. Ryaboy (JIRA)" <ji...@apache.org> on 2012/08/03 01:17:02 UTC
[jira] [Created] (PIG-2857) Add a -tagPath option to PigStorage
Dmitriy V. Ryaboy created PIG-2857:
--------------------------------------
Summary: Add a -tagPath option to PigStorage
Key: PIG-2857
URL: https://issues.apache.org/jira/browse/PIG-2857
Project: Pig
Issue Type: New Feature
Reporter: Dmitriy V. Ryaboy
Assignee: Prashant Kommireddi
We recently added a "-tagSource" option to PigStorage, which allows us to add filenames from which records come to the returned tuples.
Often, users want the whole path, not just the source file. I propose we add a "-tagPath" option to do this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2857) Add a -tagPath option to PigStorage
Posted by "Prashant Kommireddi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428351#comment-13428351 ]
Prashant Kommireddi commented on PIG-2857:
------------------------------------------
Should only 1 of "tagSource" or "tagpath" options be allowed?
> Add a -tagPath option to PigStorage
> -----------------------------------
>
> Key: PIG-2857
> URL: https://issues.apache.org/jira/browse/PIG-2857
> Project: Pig
> Issue Type: New Feature
> Reporter: Dmitriy V. Ryaboy
> Assignee: Prashant Kommireddi
>
> We recently added a "-tagSource" option to PigStorage, which allows us to add filenames from which records come to the returned tuples.
> Often, users want the whole path, not just the source file. I propose we add a "-tagPath" option to do this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2857) Add a -tagPath option to PigStorage
Posted by "Dmitriy V. Ryaboy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428420#comment-13428420 ]
Dmitriy V. Ryaboy commented on PIG-2857:
----------------------------------------
I think so. And perhaps we can deprecate tagSource (log a message to that effect), and rename it to -tagFile (as opposed to -tagPath) ?
> Add a -tagPath option to PigStorage
> -----------------------------------
>
> Key: PIG-2857
> URL: https://issues.apache.org/jira/browse/PIG-2857
> Project: Pig
> Issue Type: New Feature
> Reporter: Dmitriy V. Ryaboy
> Assignee: Prashant Kommireddi
>
> We recently added a "-tagSource" option to PigStorage, which allows us to add filenames from which records come to the returned tuples.
> Often, users want the whole path, not just the source file. I propose we add a "-tagPath" option to do this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2857) Add a -tagPath option to PigStorage
Posted by "Prashant Kommireddi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Prashant Kommireddi updated PIG-2857:
-------------------------------------
Attachment: PIG-2857.patch
Coming back to this. I think we should keep 'tagsource' in the next release for backward compatibility and as you suggested, log the deprecation message. May be we can remove 'tagsource' for 0.13. Adding a patch that now uses '-tagFile' for source filename and '-tagPath' for source path. I have modified tests accordingly to handle the same.
> Add a -tagPath option to PigStorage
> -----------------------------------
>
> Key: PIG-2857
> URL: https://issues.apache.org/jira/browse/PIG-2857
> Project: Pig
> Issue Type: New Feature
> Reporter: Dmitriy V. Ryaboy
> Assignee: Prashant Kommireddi
> Attachments: PIG-2857.patch
>
>
> We recently added a "-tagSource" option to PigStorage, which allows us to add filenames from which records come to the returned tuples.
> Often, users want the whole path, not just the source file. I propose we add a "-tagPath" option to do this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2857) Add a -tagPath option to PigStorage
Posted by "Prashant Kommireddi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Prashant Kommireddi updated PIG-2857:
-------------------------------------
Attachment: PIG-2857_1.patch
Had made changes to Utils.java that I did not add to the previous patch. Attaching an updated patch.
> Add a -tagPath option to PigStorage
> -----------------------------------
>
> Key: PIG-2857
> URL: https://issues.apache.org/jira/browse/PIG-2857
> Project: Pig
> Issue Type: New Feature
> Reporter: Dmitriy V. Ryaboy
> Assignee: Prashant Kommireddi
> Attachments: PIG-2857_1.patch, PIG-2857.patch
>
>
> We recently added a "-tagSource" option to PigStorage, which allows us to add filenames from which records come to the returned tuples.
> Often, users want the whole path, not just the source file. I propose we add a "-tagPath" option to do this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2857) Add a -tagPath option to PigStorage
Posted by "Prashant Kommireddi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Prashant Kommireddi updated PIG-2857:
-------------------------------------
Patch Info: Patch Available
> Add a -tagPath option to PigStorage
> -----------------------------------
>
> Key: PIG-2857
> URL: https://issues.apache.org/jira/browse/PIG-2857
> Project: Pig
> Issue Type: New Feature
> Reporter: Dmitriy V. Ryaboy
> Assignee: Prashant Kommireddi
> Attachments: PIG-2857_1.patch, PIG-2857.patch
>
>
> We recently added a "-tagSource" option to PigStorage, which allows us to add filenames from which records come to the returned tuples.
> Often, users want the whole path, not just the source file. I propose we add a "-tagPath" option to do this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2857) Add a -tagPath option to PigStorage
Posted by "Prashant Kommireddi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13503657#comment-13503657 ]
Prashant Kommireddi commented on PIG-2857:
------------------------------------------
Ping!
> Add a -tagPath option to PigStorage
> -----------------------------------
>
> Key: PIG-2857
> URL: https://issues.apache.org/jira/browse/PIG-2857
> Project: Pig
> Issue Type: New Feature
> Reporter: Dmitriy V. Ryaboy
> Assignee: Prashant Kommireddi
> Attachments: PIG-2857_1.patch, PIG-2857.patch
>
>
> We recently added a "-tagSource" option to PigStorage, which allows us to add filenames from which records come to the returned tuples.
> Often, users want the whole path, not just the source file. I propose we add a "-tagPath" option to do this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira