You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/06/03 16:20:14 UTC

[GitHub] [incubator-pinot] jackjlli commented on a change in pull request #7011: Modified the checkout scripts to parse arguments

jackjlli commented on a change in pull request #7011:
URL: https://github.com/apache/incubator-pinot/pull/7011#discussion_r644941547



##########
File path: compatibility-verifier/utils.inc
##########
@@ -0,0 +1,12 @@
+#compute absolute path from a relative path

Review comment:
       nit: put one space between `#` and the actual comment

##########
File path: compatibility-verifier/utils.inc
##########
@@ -0,0 +1,12 @@
+#compute absolute path from a relative path
+function absPath() {
+  local relPath=$1
+  if [[ ! "$relPath" == /* ]]; then
+    #relative path

Review comment:
       Same here




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org