You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by aray <gi...@git.apache.org> on 2017/01/10 22:52:37 UTC
[GitHub] spark pull request #16539: [SPARK-8855][MLlib][PySpark] Python API for Assoc...
GitHub user aray opened a pull request:
https://github.com/apache/spark/pull/16539
[SPARK-8855][MLlib][PySpark] Python API for Association Rules
## What changes were proposed in this pull request?
This patch adds a `generateAssociationRules(confidence)` method to `FPGrowthModel` for feature parity with the Scala and Java API.
I will do a follow up for website documentation.
## How was this patch tested?
Doctest
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aray/spark py-association-rules
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/16539.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #16539
----
commit 9b783cf2ea21c086d6ebf3316e300d859788a723
Author: Andrew Ray <ra...@gmail.com>
Date: 2017-01-10T22:46:25Z
python wrapper for association rules
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16539: [SPARK-8855][MLlib][PySpark] Python API for Association ...
Posted by jkbradley <gi...@git.apache.org>.
Github user jkbradley commented on the issue:
https://github.com/apache/spark/pull/16539
@zhengruifeng You're correct. @aray Thanks for the PR, but it will be best if we add this to the DataFrame-based API instead. Could you please close this issue? In the future, I'd recommend commenting on JIRAs before you being implementation to make sure the plan is up-to-date. Please feel free to help with the DataFrame-based API though!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #16539: [SPARK-8855][MLlib][PySpark] Python API for Assoc...
Posted by aray <gi...@git.apache.org>.
Github user aray closed the pull request at:
https://github.com/apache/spark/pull/16539
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16539: [SPARK-8855][MLlib][PySpark] Python API for Association ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16539
**[Test build #71166 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71166/testReport)** for PR 16539 at commit [`9b783cf`](https://github.com/apache/spark/commit/9b783cf2ea21c086d6ebf3316e300d859788a723).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `class AssociationRules(object):`
* ` class Rule(namedtuple(\"Rule\", [\"antecedent\", \"consequent\", \"confidence\"])):`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16539: [SPARK-8855][MLlib][PySpark] Python API for Association ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16539
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71216/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16539: [SPARK-8855][MLlib][PySpark] Python API for Association ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16539
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/71166/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16539: [SPARK-8855][MLlib][PySpark] Python API for Association ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16539
**[Test build #71216 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71216/testReport)** for PR 16539 at commit [`2dd5d0f`](https://github.com/apache/spark/commit/2dd5d0f512c49c1071627dbb134ea86291b5ee17).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16539: [SPARK-8855][MLlib][PySpark] Python API for Association ...
Posted by zhengruifeng <gi...@git.apache.org>.
Github user zhengruifeng commented on the issue:
https://github.com/apache/spark/pull/16539
I think the mllib in the python side is also in maintenance mode, and we should only fix bugs for it. @yanboliang am I right?
For this pr, I think it's reasonable to wait for the porting of FPM in SPARK-14501.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16539: [SPARK-8855][MLlib][PySpark] Python API for Association ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16539
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16539: [SPARK-8855][MLlib][PySpark] Python API for Association ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16539
**[Test build #71216 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71216/testReport)** for PR 16539 at commit [`2dd5d0f`](https://github.com/apache/spark/commit/2dd5d0f512c49c1071627dbb134ea86291b5ee17).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16539: [SPARK-8855][MLlib][PySpark] Python API for Association ...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/16539
**[Test build #71166 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/71166/testReport)** for PR 16539 at commit [`9b783cf`](https://github.com/apache/spark/commit/9b783cf2ea21c086d6ebf3316e300d859788a723).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #16539: [SPARK-8855][MLlib][PySpark] Python API for Association ...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/16539
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org