[jira] Commented: (HIVE-309) FunctionRegistry should allow loading UDFs and UDAFs from property file

["Namit Jain (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694327#action_12694327 ] 

Namit Jain commented on HIVE-309:
---------------------------------

Your code changes look good - but can you add a few tests also.

You have ignored badly specified function names etc. - please add some good functions as you mentioned above and also some bad functions (which 
will just get ignored)

Once the tests are in, I will accept and commit the patch

> FunctionRegistry should allow loading UDFs and UDAFs from property file
> -----------------------------------------------------------------------
>
>                 Key: HIVE-309
>                 URL: https://issues.apache.org/jira/browse/HIVE-309
>             Project: Hadoop Hive
>          Issue Type: Improvement
>          Components: Query Processor
>            Reporter: Richard Lee
>         Attachments: hive-external-functions-2.diff, hive-external-functions.diff, hive-external-functions2.diff, hive-external-functions3.diff
>
>
> FunctionRegistry.java hard code all UDF, UDAF definitions in a static initializer.  There is no way to add new functions without directly modifying this file.  
> FunctionRegistry SHOULD look for a property file in which new functions and their implementations can be specified.  This will allow third parties to extend hive without maintaining patches against the codebase. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.