You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "jedcunningham (via GitHub)" <gi...@apache.org> on 2024/01/16 22:13:27 UTC
[PR] Revert "Make links in logs as hyperlinks in grid view (#36816)" [airflow]
jedcunningham opened a new pull request, #36826:
URL: https://github.com/apache/airflow/pull/36826
This reverts commit af6ae954476ab45fd5776f76f27b2668eb868aef. This introduces at least some html injection from task logs.
More context: https://github.com/apache/airflow/pull/36816#issuecomment-1894601383
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Revert "Make links in logs as hyperlinks in grid view (#36816)" [airflow]
Posted by "jedcunningham (via GitHub)" <gi...@apache.org>.
jedcunningham merged PR #36826:
URL: https://github.com/apache/airflow/pull/36826
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Revert "Make links in logs as hyperlinks in grid view (#36816)" [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on PR #36826:
URL: https://github.com/apache/airflow/pull/36826#issuecomment-1894884990
Super good catch btw, @jedcunningham!!
Appreciate the catch :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Revert "Make links in logs as hyperlinks in grid view (#36816)" [airflow]
Posted by "jedcunningham (via GitHub)" <gi...@apache.org>.
jedcunningham commented on PR #36826:
URL: https://github.com/apache/airflow/pull/36826#issuecomment-1894626288
More examples:
```
@task
def bold():
print("http://apache.org/</a><b>bad-stuff!</b>")
print("back to normal")
print("<b>does this work?</b>")
@task
def alert():
print("<div onmouseover=\"alert('hi');\">hello</div>")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Revert "Make links in logs as hyperlinks in grid view (#36816)" [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on PR #36826:
URL: https://github.com/apache/airflow/pull/36826#issuecomment-1894624522
Good call my bad! Let me create a proper fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Revert "Make links in logs as hyperlinks in grid view (#36816)" [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on PR #36826:
URL: https://github.com/apache/airflow/pull/36826#issuecomment-1894883968
@bbovenzi shall I work on a proper fix for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org