You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Abhishek Kumar <ab...@gmail.com> on 2021/10/07 01:04:52 UTC
Review Request 73633: RANGER-3421: Avoid logging key details in
RangerMasterKey.java
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73633/
-----------------------------------------------------------
Review request for ranger, Dhaval Shah, Abhay Kulkarni, Sailaja Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-3421
https://issues.apache.org/jira/browse/RANGER-3421
Repository: ranger
Description
-------
Avoiding logging key details and code refactoring.
Diffs
-----
kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java adb2c2604
Diff: https://reviews.apache.org/r/73633/diff/1/
Testing
-------
Thanks,
Abhishek Kumar
Re: Review Request 73633: RANGER-3421: Avoid logging key details in
RangerMasterKey.java
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73633/#review223611
-----------------------------------------------------------
Ship it!
Ship It!
- Abhay Kulkarni
On Oct. 13, 2021, 1:12 a.m., Abhishek Kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73633/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2021, 1:12 a.m.)
>
>
> Review request for ranger, Dhaval Shah, Abhay Kulkarni, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3421
> https://issues.apache.org/jira/browse/RANGER-3421
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Avoiding logging key details and code refactoring.
>
>
> Diffs
> -----
>
> kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java adb2c2604
>
>
> Diff: https://reviews.apache.org/r/73633/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Abhishek Kumar
>
>
Re: Review Request 73633: RANGER-3421: Avoid logging key details in
RangerMasterKey.java
Posted by Abhishek Kumar <ab...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73633/
-----------------------------------------------------------
(Updated Oct. 13, 2021, 1:12 a.m.)
Review request for ranger, Dhaval Shah, Abhay Kulkarni, Sailaja Polavarapu, and Velmurugan Periasamy.
Changes
-------
Updated as per suggestions.
Bugs: RANGER-3421
https://issues.apache.org/jira/browse/RANGER-3421
Repository: ranger
Description
-------
Avoiding logging key details and code refactoring.
Diffs (updated)
-----
kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java adb2c2604
Diff: https://reviews.apache.org/r/73633/diff/2/
Changes: https://reviews.apache.org/r/73633/diff/1-2/
Testing
-------
Thanks,
Abhishek Kumar
Re: Review Request 73633: RANGER-3421: Avoid logging key details in
RangerMasterKey.java
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73633/#review223589
-----------------------------------------------------------
kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java
Line 223 (original), 219 (patched)
<https://reviews.apache.org/r/73633/#comment312693>
Please review this change. Can it simply be as follows?
if (savedKey != null && !savedKey.trim().equals("")) {
if (logger.isDebugEnabled()) {
<<<< logger.debug("Master Key Created with id = " + savedKey);
<<<< }
}
- Abhay Kulkarni
On Oct. 7, 2021, 1:04 a.m., Abhishek Kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73633/
> -----------------------------------------------------------
>
> (Updated Oct. 7, 2021, 1:04 a.m.)
>
>
> Review request for ranger, Dhaval Shah, Abhay Kulkarni, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3421
> https://issues.apache.org/jira/browse/RANGER-3421
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Avoiding logging key details and code refactoring.
>
>
> Diffs
> -----
>
> kms/src/main/java/org/apache/hadoop/crypto/key/RangerMasterKey.java adb2c2604
>
>
> Diff: https://reviews.apache.org/r/73633/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Abhishek Kumar
>
>