[GitHub] [arrow] Platob commented on a diff in pull request #35183: GH-35175: [C#] Decimal128 / 256 Types should alloc dynamic byteWidth based on precision and scale

["Platob (via GitHub)" <gi...@apache.org>]

Platob commented on code in PR #35183:
URL: https://github.com/apache/arrow/pull/35183#discussion_r1169532257


##########
csharp/test/Apache.Arrow.Tests/Decimal128ArrayTests.cs:
##########
@@ -41,7 +40,7 @@ public void AppendThenGetGivesNull()
                     var array = builder.Build();
 
                     Assert.Equal(3, array.Length);
-                    Assert.Equal(array.Data.Buffers[1].Length, array.ByteWidth * 3);
+                    Assert.Equal(array.Data.Buffers[1].Length, array.ByteWidth * 3 + array.ByteWidth - 1);

Review Comment:
   yeah indeed seeing cpp implementation its fixed
   
   I saw in ParquetSharp implementation returning a Decimal128Type with 9 byteWidth for precision = 15 and scale = 5 which was different from 16



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org