[GitHub] [jackrabbit-oak] mreutegg commented on pull request #690: OAK-9913 : added metrics for mongo document store throttling feature

[GitBox <gi...@apache.org>]

mreutegg commented on PR #690:
URL: https://github.com/apache/jackrabbit-oak/pull/690#issuecomment-1248989611

   I only noticed now that Stefan also [mentioned](https://issues.apache.org/jira/browse/OAK-9913?focusedCommentId=17598459&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17598459) he would keep the two metrics separate. The existing one that gives us timings with the DocumentStore implementation and the throttling metrics.
   
   There is also good [comment](https://issues.apache.org/jira/browse/OAK-9913?focusedCommentId=17600332&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17600332) from Jose in the JIRA issue.
   
   This is a bit late in the review and I feel bad that I didn't point this out earlier, but wouldn't it be easier and more decoupled if there was a `ThrottlingStatsCollector`? It would be similar to `DocumentStoreStatsCollector`, but without methods for read operations. The `DocumentNodeStoreBuilder` would provide a `ThrottlingStatsCollector` that can be used in the constructor of `DocumentNodeStore` when a `ThrottlingDocumentStoreWrapper` created. The `ThrottlingStatsCollector` is passed as an argument to `ThrottlingDocumentStoreWrapper`. Whenever the `ThrottlingDocumentStoreWrapper` throttles an operation it reports it to the `ThrottlingStatsCollector`. As mentioned earlier, the existing metrics for write operations would be untouched and decoupled from the new throttling metrics.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org