You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "lhsribas (via GitHub)" <gi...@apache.org> on 2023/05/02 14:51:08 UTC

[GitHub] [camel] lhsribas opened a new pull request, #9975: Removing unused parameters from method signature

lhsribas opened a new pull request, #9975:
URL: https://github.com/apache/camel/pull/9975

   # Description
   
    I have worked on the following class removing the unused parameters from method signature.
   
   # Tracking
   - [Removing Unuse parameters from method signature] https://sonarcloud.io/project/issues?resolved=false&rules=java%3AS1172&id=apache_camel


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] rhuan080 commented on pull request #9975: Removing unused parameters from method signature

Posted by "rhuan080 (via GitHub)" <gi...@apache.org>.
rhuan080 commented on PR #9975:
URL: https://github.com/apache/camel/pull/9975#issuecomment-1531898601

   Hi, 
   
   I would like to suggest using method overload to createBaseDescription and turning the method with unused parameters deprecated. Thus, you can change the call to the need method in many other PRs. I think it is more secure approach.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] github-actions[bot] commented on pull request #9975: Removing unused parameters from method signature

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9975:
URL: https://github.com/apache/camel/pull/9975#issuecomment-1531619577

   :star2: Thank you for your contribution to the Apache Camel project! :star2: 
   
   :warning: Please note that the changes on this PR may be **tested automatically**. 
   
   If necessary Apache Camel Committers may access logs and test results in the job summaries!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] orpiske commented on pull request #9975: Removing unused parameters from method signature

Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #9975:
URL: https://github.com/apache/camel/pull/9975#issuecomment-1531630090

   Folks, I've been giving some ideas/help for @lhsribas on his first contribution to Camel. Please, feel free to step in and provide more comments. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] orpiske closed pull request #9975: Removing unused parameters from method signature

Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske closed pull request #9975: Removing unused parameters from method signature
URL: https://github.com/apache/camel/pull/9975


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] orpiske commented on pull request #9975: Removing unused parameters from method signature

Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #9975:
URL: https://github.com/apache/camel/pull/9975#issuecomment-1598192516

   This one has stalled, therefore closing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org