[jira] [Resolved] (IMPALA-2690) Revisit checkState() in HdfsTable#getTHdfsTable()

["Tim Armstrong (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/IMPALA-2690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tim Armstrong resolved IMPALA-2690.
-----------------------------------
    Resolution: Won't Fix

The code changed a lot, dont' think this makes sense still.

> Revisit checkState() in HdfsTable#getTHdfsTable()
> -------------------------------------------------
>
>                 Key: IMPALA-2690
>                 URL: https://issues.apache.org/jira/browse/IMPALA-2690
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Frontend
>    Affects Versions: Impala 2.3.0
>            Reporter: Bharath Vissapragada
>            Assignee: Bharath Vissapragada
>            Priority: Trivial
>
> Following is a code snippet in HdfsTable#getTHdfsTable() 
> {code}
> /**
>    * Create a THdfsTable corresponding to this HdfsTable. If includeFileDesc is true,
>    * then then all partitions and THdfsFileDescs of each partition should be included.
>    * Otherwise, don't include any THdfsFileDescs, and include only those partitions in
>    * the refPartitions set (the backend doesn't need metadata for unreferenced
>    * partitions).
>    */
>   private THdfsTable getTHdfsTable(boolean includeFileDesc, Set<Long> refPartitions) {
>     // includeFileDesc implies all partitions should be included (refPartitions == null).
>     Preconditions.checkState(!includeFileDesc || refPartitions == null);
> {code}
> As per the javadoc, checkState() can be more stricter where refPartitions be != null if !includeFileDesc . However adding it breaks insert into table partition() values() statement. Either the javadoc is wrong or the caller is setting wrong refPartitions.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)