You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2022/07/04 17:31:59 UTC

[GitHub] [tinkerpop] jroimartin commented on pull request #1743: Cast Times serialization to int in Gremlin-Go

jroimartin commented on PR #1743:
URL: https://github.com/apache/tinkerpop/pull/1743#issuecomment-1174026336

   @simonz-bq @xiazcy would it be an option to deal with this kind of casts inside the function [makeBytecodeRequest](https://github.com/apache/tinkerpop/blob/40508a427756d088d38b2236837c09db5dd1f2cd/gremlin-go/driver/request.go#L66)?
   
   It could be modified to return `(request, error)` and, then `(*Client).submitBytecode` could [return with error if it fails](https://github.com/apache/tinkerpop/blob/40508a427756d088d38b2236837c09db5dd1f2cd/gremlin-go/driver/client.go#L161). That would allow to check that the cast is valid before sending it to the server.
   
   I'm asking because it seems that the root cause of the problem is dealing with this inside the step itself which cannot return an error.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org