You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hive.apache.org by Harish Butani <rh...@gmail.com> on 2013/12/20 05:36:20 UTC

Review Request 16413: HIVE-5558: Allow from clause to join table sources with the `comma' token.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16413/
-----------------------------------------------------------

Review request for hive and Ashutosh Chauhan.


Bugs: HIVE-5558
    https://issues.apache.org/jira/browse/HIVE-5558


Repository: hive-git


Description
-------

Allow from clause to join table sources with the `comma' token.


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/parse/FromClauseParser.g 205604c 
  ql/src/test/queries/clientnegative/join_alt_syntax_comma_on.q PRE-CREATION 
  ql/src/test/queries/clientpositive/join_alt_syntax.q PRE-CREATION 
  ql/src/test/results/clientnegative/join_alt_syntax_comma_on.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/join_alt_syntax.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/16413/diff/


Testing
-------

added new tests


Thanks,

Harish Butani