You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sling.apache.org by chrisgavin <gi...@git.apache.org> on 2017/05/09 07:39:11 UTC

[GitHub] sling pull request #224: Fix a cross-site scripting vulnerability in the Sli...

GitHub user chrisgavin opened a pull request:

    https://github.com/apache/sling/pull/224

    Fix a cross-site scripting vulnerability in the SlingLogPanel.

    The log appender name is a user provided value originating [here](/apache/sling/blob/f0e4561935cbebfe6f84a85622513baa74e72d44/bundles/commons/log-webconsole/src/main/java/org/apache/sling/commons/log/webconsole/internal/LogWebConsolePlugin.java#L65), therefore it should not be written to the output HTML without being sanitized.
    
    ---
    
    I found this issue through [lgtm.com](https://lgtm.com/projects/g/apache/sling/alerts/), a service that analyzes open-source code to look for potential problems. (Full disclosure: I work for the company that operates it.)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/chrisgavin/sling log-panel-xss

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/sling/pull/224.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #224
    
----
commit 3e7e3ed09dfac4d5794385cb6165530c1795cb27
Author: Chris Gavin <ch...@chrisgavin.me>
Date:   2017-05-09T07:34:33Z

    Fix a cross-site scripting vulnerability in the SlingLogPanel.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---