You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/04/07 02:47:15 UTC
[GitHub] [kafka] cmccabe opened a new pull request #10496: MINOR: move NoOpSnapshotWriter to main
cmccabe opened a new pull request #10496:
URL: https://github.com/apache/kafka/pull/10496
Move NoOpSnapshotWriter and NoOpSnapshotWriterBuilder out of the test
directory and into the main directory, until we implement the KRaft
integration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe merged pull request #10496: MINOR: move NoOpSnapshotWriter to main
Posted by GitBox <gi...@apache.org>.
cmccabe merged pull request #10496:
URL: https://github.com/apache/kafka/pull/10496
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe commented on pull request #10496: MINOR: move NoOpSnapshotWriter to main
Posted by GitBox <gi...@apache.org>.
cmccabe commented on pull request #10496:
URL: https://github.com/apache/kafka/pull/10496#issuecomment-814612546
I added a comment. Thanks for the reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe commented on a change in pull request #10496: MINOR: move NoOpSnapshotWriter to main
Posted by GitBox <gi...@apache.org>.
cmccabe commented on a change in pull request #10496:
URL: https://github.com/apache/kafka/pull/10496#discussion_r608349100
##########
File path: metadata/src/main/java/org/apache/kafka/controller/QuorumController.java
##########
@@ -208,8 +208,7 @@ public QuorumController build() throws Exception {
"org.apache.kafka.controller.MockControllerMetrics").getConstructor().newInstance();
Review comment:
It's not an issue because of the way it's used in the code. But we will probably clean this up a little bit in a follow-on PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on a change in pull request #10496: MINOR: move NoOpSnapshotWriter to main
Posted by GitBox <gi...@apache.org>.
ijuma commented on a change in pull request #10496:
URL: https://github.com/apache/kafka/pull/10496#discussion_r608348438
##########
File path: metadata/src/main/java/org/apache/kafka/controller/QuorumController.java
##########
@@ -208,8 +208,7 @@ public QuorumController build() throws Exception {
"org.apache.kafka.controller.MockControllerMetrics").getConstructor().newInstance();
Review comment:
I asked the same question and it's apparently intended. I think we should not use this pattern, but we can do that in a separate PR. This PR is required to fix some tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe edited a comment on pull request #10496: MINOR: move NoOpSnapshotWriter to main
Posted by GitBox <gi...@apache.org>.
cmccabe edited a comment on pull request #10496:
URL: https://github.com/apache/kafka/pull/10496#issuecomment-814612546
@ijuma : I added a comment as you suggested.
Thanks for the reviews, @ijuma & @chia7712 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on a change in pull request #10496: MINOR: move NoOpSnapshotWriter to main
Posted by GitBox <gi...@apache.org>.
chia7712 commented on a change in pull request #10496:
URL: https://github.com/apache/kafka/pull/10496#discussion_r608341991
##########
File path: metadata/src/main/java/org/apache/kafka/controller/QuorumController.java
##########
@@ -208,8 +208,7 @@ public QuorumController build() throws Exception {
"org.apache.kafka.controller.MockControllerMetrics").getConstructor().newInstance();
Review comment:
Is this a potential issue? `"org.apache.kafka.controller.MockControllerMetrics"` is not in produce code also.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org