You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mc...@gmail.com> on 2015/06/23 10:19:43 UTC
Review Request 35777: Made post-reviews.py handle bad (or not)
ReviewBoard URLs.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35777/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Till Toenshoff.
Repository: mesos
Description
-------
(1) Handles the case where the `Review: ...` line isn't the last of the commit message.
```
01596ce802669e9dac7dd24193f041cef3354830 - Fixed post-reviews.py hanging bug. (6 seconds ago)
ReviewBoard URL must be the last line of the commit message!
Fixed post-reviews.py hanging bug.
Review: https://reviews.apache.org/r/35771
abcd
```
(2) Handles the case where the ReviewBoard URL is invalid.
```
af081a07234794f60a2575e0383ce537d7111c18 - Fixed post-reviews.py hanging bug. (29 seconds ago)
Invalid ReviewBoard URL : 'https://reviews.apache.org/r/35771 abcd'
```
Diffs
-----
support/post-reviews.py 10861a9eb9739a519732fef02a14dc4514463a8c
Diff: https://reviews.apache.org/r/35777/diff/
Testing
-------
Modified the commit message with `git rebase` and ran `./support/post-reviews.py` to observe the above error messages.
Used the valid commit message for this patch and created it by running `./support/post-reviews.py`.
Thanks,
Michael Park
Re: Review Request 35777: Made post-reviews.py handle bad (or not)
ReviewBoard URLs.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35777/#review88957
-----------------------------------------------------------
Patch looks great!
Reviews applied: [35777]
All tests passed.
- Mesos ReviewBot
On June 23, 2015, 8:19 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35777/
> -----------------------------------------------------------
>
> (Updated June 23, 2015, 8:19 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> (1) Handles the case where the `Review: ...` line isn't the last of the commit message.
>
> ```
> 01596ce802669e9dac7dd24193f041cef3354830 - Fixed post-reviews.py hanging bug. (6 seconds ago)
>
> ReviewBoard URL must be the last line of the commit message!
>
> Fixed post-reviews.py hanging bug.
>
> Review: https://reviews.apache.org/r/35771
>
> abcd
> ```
>
> (2) Handles the case where the ReviewBoard URL is invalid.
>
> ```
> af081a07234794f60a2575e0383ce537d7111c18 - Fixed post-reviews.py hanging bug. (29 seconds ago)
>
> Invalid ReviewBoard URL : 'https://reviews.apache.org/r/35771 abcd'
> ```
>
>
> Diffs
> -----
>
> support/post-reviews.py 10861a9eb9739a519732fef02a14dc4514463a8c
>
> Diff: https://reviews.apache.org/r/35777/diff/
>
>
> Testing
> -------
>
> Modified the commit message with `git rebase` and ran `./support/post-reviews.py` to observe the above error messages.
> Used the valid commit message for this patch and created it by running `./support/post-reviews.py`.
>
>
> Thanks,
>
> Michael Park
>
>