You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2021/04/06 07:38:11 UTC
[GitHub] [openwhisk-utilities] upgle opened a new pull request #81: Exclude auto-generated protobuf files
upgle opened a new pull request #81:
URL: https://github.com/apache/openwhisk-utilities/pull/81
## Description
It excludes files auto-generated by the Scala Plugin for the Protocol Buffer Compiler.
I couldn't find a way to add a license header for the auto-generated file.
Those excluded protobuf files will be used for the new scheduler contribution (GRPC).
## Related issue
https://github.com/apache/openwhisk/pull/5070
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-utilities] upgle commented on pull request #81: Exclude auto-generated protobuf files
Posted by GitBox <gi...@apache.org>.
upgle commented on pull request #81:
URL: https://github.com/apache/openwhisk-utilities/pull/81#issuecomment-814123883
Close this issue by handling it in another way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-utilities] upgle commented on pull request #81: Exclude auto-generated protobuf files
Posted by GitBox <gi...@apache.org>.
upgle commented on pull request #81:
URL: https://github.com/apache/openwhisk-utilities/pull/81#issuecomment-814105310
@dgrove-oss
Thank you for your comment. Let me check if the code can be scanned on the fresh clone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-utilities] upgle commented on pull request #81: Exclude auto-generated protobuf files
Posted by GitBox <gi...@apache.org>.
upgle commented on pull request #81:
URL: https://github.com/apache/openwhisk-utilities/pull/81#issuecomment-814122413
Thank you for taking a closer look. I've moved the invocation of scan.sh into the install stage in this commit. https://github.com/apache/openwhisk/pull/5070/commits/4d9c7c6ef8ba97d5521231583da0dd5d2e5d89e1
It runs on all jobs in matrices, but it doesn't take much time to do a code scanning. And I think this approach would be more suitable for handling various cases for auto-generated files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-utilities] dgrove-oss commented on pull request #81: Exclude auto-generated protobuf files
Posted by GitBox <gi...@apache.org>.
dgrove-oss commented on pull request #81:
URL: https://github.com/apache/openwhisk-utilities/pull/81#issuecomment-814090713
Do the generated files need to be checked into git? Or are they artifacts produced by the build. If produced by the build, they should not need to be excluded from scan code. We can run the scan code on the fresh clone (before starting build).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-utilities] dgrove-oss commented on pull request #81: Exclude auto-generated protobuf files
Posted by GitBox <gi...@apache.org>.
dgrove-oss commented on pull request #81:
URL: https://github.com/apache/openwhisk-utilities/pull/81#issuecomment-814108240
I took a look at .travis.yml. We intentionally compile the source tree "early" in the `install` stage from setup.sh while we defer scancode.sh to the runUnitTests.sh job. So, our choices are either exclude the generated sources as this PR does or to move the invocation of scan.sh into the install stage (which would cause it to run on all jobs in the matrix in the install stage). It would be more consistent with the other openwhisk repos to move the scan early, but either approach could be made to work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-utilities] dgrove-oss edited a comment on pull request #81: Exclude auto-generated protobuf files
Posted by GitBox <gi...@apache.org>.
dgrove-oss edited a comment on pull request #81:
URL: https://github.com/apache/openwhisk-utilities/pull/81#issuecomment-814090713
Do the generated files need to be checked into git? Or are they artifacts produced by doing a build? If produced by the build, they should not need to be excluded from scan code. We can run the scan code on the fresh clone (before starting build).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [openwhisk-utilities] upgle closed pull request #81: Exclude auto-generated protobuf files
Posted by GitBox <gi...@apache.org>.
upgle closed pull request #81:
URL: https://github.com/apache/openwhisk-utilities/pull/81
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org