You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by neykov <gi...@git.apache.org> on 2014/10/15 15:18:44 UTC
[GitHub] incubator-brooklyn pull request: Fix a HA failover bug where the m...
GitHub user neykov opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/245
Fix a HA failover bug where the master tries to become a master again and fails.
Instead of failing just log a warning, turns out this case can happen in a real-world scenario where the storage delays the writes of the master.
Based on Sam's approach and prototype test, thanks.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/neykov/incubator-brooklyn fix/double-master-rebind
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/245.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #245
----
commit 27d958dea72ee3aa593a695de29f8bbb18d403eb
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date: 2014-10-15T09:59:52Z
Fix a HA failover bug where the master tries to become a master again and fails.
Instead of failing just log a warning, turns out this case can happen in a real-world scenario where the storage delays the writes of the master.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix a HA failover bug where the m...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/245#issuecomment-59382254
great tests, nice simple fix
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix a HA failover bug where the m...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/245
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix a HA failover bug where the m...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/245#issuecomment-59260705
Seems like the failure is unrelated, local tests are passing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---