[GitHub] [airflow] uranusjr commented on pull request #14878: Make app creation session- or class-wide when possible to make tests faster

[GitBox <gi...@apache.org>]

uranusjr commented on pull request #14878:
URL: https://github.com/apache/airflow/pull/14878#issuecomment-802142848


   I’ve rebased this against #14875, so this now includes changes from that PR. If that gets merged first I’ll rebase/merge again.
   
   I’ve located several more app creation code and change them to be session or class scoped. I think there are some more possibile optimisations, especially several of the apps are simply bare `create_app(testing=True)` without decorators. I think they can be merged into a session-scoped fixture in the top-level `tests/conftest.py`. What would be a good name for the fixture? `app` sounds wrong to me, maybe
   
   ```python
   @pytest.fixture(scope="session")
   def testing_app():
       return application.create_app(testing=True)
   ```
   
   ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org