You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2023/04/29 14:52:49 UTC
[GitHub] [incubator-pekko-connectors] mdedetrich opened a new pull request, #86: Add bucketVersioningEnabled helper methods
mdedetrich opened a new pull request, #86:
URL: https://github.com/apache/incubator-pekko-connectors/pull/86
Follow up on from https://github.com/apache/incubator-pekko-connectors/pull/84, one of the common usecases for bucket versioning is to figure out if its enabled/disabled and due to the current field being nested inside of an option with a custom ADT the helper methods are being added to trivialize the operation.
Note that a Java alias is being added since the rest of the models in S3 follow the `field`/`getField` for Scala/Java repsectively.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] mdedetrich merged pull request #86: Add bucketVersioningEnabled helper methods
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich merged PR #86:
URL: https://github.com/apache/incubator-pekko-connectors/pull/86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors] pjfanning commented on a diff in pull request #86: Add bucketVersioningEnabled helper methods
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #86:
URL: https://github.com/apache/incubator-pekko-connectors/pull/86#discussion_r1181651467
##########
s3/src/main/scala/org/apache/pekko/stream/connectors/s3/model.scala:
##########
@@ -194,6 +200,12 @@ final class BucketVersioning private (val status: Option[BucketVersioningStatus]
/** Java API */
def getMfaDelete: java.util.Optional[MFAStatus] = mfaDelete.asJava
+ /** Java API */
+ def getBucketVersioningEnabled: Boolean = bucketVersioningEnabled
Review Comment:
With Java APIs, it is more common to use 'is' instead of 'get' for the names of getters that return booleans.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org