You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@geode.apache.org by davinash <gi...@git.apache.org> on 2017/04/20 19:13:26 UTC

[GitHub] geode pull request #464: GEODE-237: Removed deprecated API from EntryEvent

GitHub user davinash opened a pull request:

    https://github.com/apache/geode/pull/464

    GEODE-237: Removed deprecated API from EntryEvent

    Removed deprecated CacheEvent methods

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/davinash/geode feature/GEODE-237

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/464.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #464
    
----
commit 69c7d997c340efe9cfd3ba755f529ee113d1e2ad
Author: adongre <ad...@apache.org>
Date:   2017-04-19T08:41:49Z

    GEODE-237: Removed deprecated API from EntryEvent
    1. isLocalLoad
    2. isNetLoad
    3. isLoad
    4. isNetSearch
    5. isBridgeEvent

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #464: GEODE-237: Removed deprecated API from EntryEvent

Posted by dschneider-pivotal <gi...@git.apache.org>.

Github user dschneider-pivotal commented on the issue:

    https://github.com/apache/geode/pull/464
  
    This change looks good. I noticed travis CI failed with the following. But it looks like isExpiration was removed in some other commit so it is not clear to me why this one got the following failure.
    
    :geode-core:compileTestJava/home/travis/build/apache/geode/geode-core/src/test/java/org/apache/geode/TXJUnitTest.java:3009: error: cannot find symbol
          assertTrue(!event.isExpiration());
                           ^
      symbol:   method isExpiration()
      location: variable event of type EntryEvent


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode pull request #464: GEODE-237: Removed deprecated API from EntryEvent

Posted by davinash <gi...@git.apache.org>.

Github user davinash closed the pull request at:

    https://github.com/apache/geode/pull/464


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] geode issue #464: GEODE-237: Removed deprecated API from EntryEvent

Posted by davinash <gi...@git.apache.org>.

Github user davinash commented on the issue:

    https://github.com/apache/geode/pull/464
  
    Some is wrong. I am closing this PR and will raise another one from latest develop.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---