You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "keith-turner (via GitHub)" <gi...@apache.org> on 2023/04/18 22:47:21 UTC

[GitHub] [accumulo] keith-turner commented on a diff in pull request #3292: fixes #3252 support tablets w/ and w/o location in tablet location cache

keith-turner commented on code in PR #3292:
URL: https://github.com/apache/accumulo/pull/3292#discussion_r1170635870


##########
core/src/main/java/org/apache/accumulo/core/clientImpl/RootTabletLocator.java:
##########
@@ -57,19 +59,23 @@ public <T extends Mutation> void binMutations(ClientContext context, List<T> mut
       Map<String,TabletServerMutations<T>> binnedMutations, List<T> failures) {
     TabletLocation rootTabletLocation = getRootTabletLocation(context);
     if (rootTabletLocation != null) {
-      var tsm = new TabletServerMutations<T>(rootTabletLocation.getTserverSession());
+      var tsm = new TabletServerMutations<T>(rootTabletLocation.getTserverSession().get());
       for (T mutation : mutations) {
         tsm.addMutation(RootTable.EXTENT, mutation);
       }
-      binnedMutations.put(rootTabletLocation.getTserverLocation(), tsm);
+      binnedMutations.put(rootTabletLocation.getTserverLocation().get(), tsm);
     } else {
       failures.addAll(mutations);
     }
   }
 
   @Override
   public List<Range> locateTablets(ClientContext context, List<Range> ranges,
-      BiConsumer<TabletLocation,Range> rangeConsumer) {
+      BiConsumer<TabletLocation,Range> rangeConsumer, HostingNeed hostingNeed) {
+
+    // only expect the hosted case so this code only handles that, so throw an exception is
+    // something else is seed

Review Comment:
   Yeah, was only expecting request for the root tablet to have a location.  Also there is no handling for the other cases, like the root tablet will not be requested to be brought online. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org