You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Alex Newman (Created) (JIRA)" <ji...@apache.org> on 2012/01/17 20:17:40 UTC
[jira] [Created] (HBASE-5217) Reenable the thrift tests, and add a
new one for getRegionInfo
Reenable the thrift tests, and add a new one for getRegionInfo
--------------------------------------------------------------
Key: HBASE-5217
URL: https://issues.apache.org/jira/browse/HBASE-5217
Project: HBase
Issue Type: Improvement
Reporter: Alex Newman
Assignee: Alex Newman
At some point we disabled tests for the thrift server. In addition, it looks like the getRegionInfo no longer functions. I'd like to reenable the tests and add one for getRegionInfo.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5217) Reenable the thrift tests, and add a
new one for getRegionInfo
Posted by "Alex Newman (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Newman updated HBASE-5217:
-------------------------------
Status: In Progress (was: Patch Available)
> Reenable the thrift tests, and add a new one for getRegionInfo
> --------------------------------------------------------------
>
> Key: HBASE-5217
> URL: https://issues.apache.org/jira/browse/HBASE-5217
> Project: HBase
> Issue Type: Improvement
> Reporter: Alex Newman
> Assignee: Alex Newman
> Priority: Minor
> Attachments: 0001-Fixing-thrift-tests-v2.patch, 0001-Fixing-thrift-tests.patch, 0002-HBASE-5217.-Reenable-the-thrift-tests-and-add-a-new-.patch, zzzz-hbase-posix4e #92 Console [Jenkins].pdf
>
>
> At some point we disabled tests for the thrift server. In addition, it looks like the getRegionInfo no longer functions. I'd like to reenable the tests and add one for getRegionInfo. I had to write this to test my changes in HBASE-2600 anyway. I figured I would break it out. We shouldn't commit it until we have fixed getting the regioninfo from the thriftserver.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5217) Reenable the thrift tests, and add
a new one for getRegionInfo
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13188664#comment-13188664 ]
Hadoop QA commented on HBASE-5217:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12511026/0002-HBASE-5217.-Reenable-the-thrift-tests-and-add-a-new-v2.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 4 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated -145 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 82 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/806//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/806//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/806//console
This message is automatically generated.
> Reenable the thrift tests, and add a new one for getRegionInfo
> --------------------------------------------------------------
>
> Key: HBASE-5217
> URL: https://issues.apache.org/jira/browse/HBASE-5217
> Project: HBase
> Issue Type: Improvement
> Reporter: Alex Newman
> Assignee: Alex Newman
> Priority: Minor
> Attachments: 0001-Fixing-thrift-tests-v2.patch, 0001-Fixing-thrift-tests.patch, 0002-HBASE-5217.-Reenable-the-thrift-tests-and-add-a-new-v2.patch, zzzz-hbase-posix4e #92 Console [Jenkins].pdf
>
>
> At some point we disabled tests for the thrift server. In addition, it looks like the getRegionInfo no longer functions. I'd like to reenable the tests and add one for getRegionInfo. I had to write this to test my changes in HBASE-2600 anyway. I figured I would break it out. We shouldn't commit it until we have fixed getting the regioninfo from the thriftserver.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5217) Reenable the thrift tests, and add
a new one for getRegionInfo
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237964#comment-13237964 ]
jiraposter@reviews.apache.org commented on HBASE-5217:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3514/
-----------------------------------------------------------
(Updated 2012-03-25 20:11:30.928544)
Review request for hbase.
Summary
-------
At some point we disabled tests for the thrift server. In addition, it looks like the getRegionInfo no longer functions. I'd like to reenable the tests and add one for getRegionInfo.
This addresses bug HBASE-5217.
https://issues.apache.org/jira/browse/HBASE-5217
Diffs (updated)
-----
src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java 60eb426
src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java 444d6d5
Diff: https://reviews.apache.org/r/3514/diff
Testing
-------
Ran the tests with my changes in HBASE-2600 to test.
Thanks,
Alex
> Reenable the thrift tests, and add a new one for getRegionInfo
> --------------------------------------------------------------
>
> Key: HBASE-5217
> URL: https://issues.apache.org/jira/browse/HBASE-5217
> Project: HBase
> Issue Type: Improvement
> Reporter: Alex Newman
> Assignee: Alex Newman
> Priority: Minor
> Attachments: 0001-Fixing-thrift-tests-v2.patch, 0001-Fixing-thrift-tests.patch, 0002-HBASE-5217.-Reenable-the-thrift-tests-and-add-a-new-.patch, zzzz-hbase-posix4e #92 Console [Jenkins].pdf
>
>
> At some point we disabled tests for the thrift server. In addition, it looks like the getRegionInfo no longer functions. I'd like to reenable the tests and add one for getRegionInfo. I had to write this to test my changes in HBASE-2600 anyway. I figured I would break it out. We shouldn't commit it until we have fixed getting the regioninfo from the thriftserver.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5217) Reenable the thrift tests, and add
a new one for getRegionInfo
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13187917#comment-13187917 ]
jiraposter@reviews.apache.org commented on HBASE-5217:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3514/
-----------------------------------------------------------
(Updated 2012-01-17 19:26:07.447407)
Review request for hbase.
Summary
-------
At some point we disabled tests for the thrift server. In addition, it looks like the getRegionInfo no longer functions. I'd like to reenable the tests and add one for getRegionInfo.
This addresses bug HBASE-5217.
https://issues.apache.org/jira/browse/HBASE-5217
Diffs (updated)
-----
src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java 12247d0
Diff: https://reviews.apache.org/r/3514/diff
Testing
-------
Ran the tests with my changes in HBASE-2600 to test.
Thanks,
Alex
> Reenable the thrift tests, and add a new one for getRegionInfo
> --------------------------------------------------------------
>
> Key: HBASE-5217
> URL: https://issues.apache.org/jira/browse/HBASE-5217
> Project: HBase
> Issue Type: Improvement
> Reporter: Alex Newman
> Assignee: Alex Newman
> Priority: Minor
> Attachments: 0001-Fixing-thrift-tests-v2.patch, 0001-Fixing-thrift-tests.patch
>
>
> At some point we disabled tests for the thrift server. In addition, it looks like the getRegionInfo no longer functions. I'd like to reenable the tests and add one for getRegionInfo. I had to write this to test my changes in HBASE-2600 anyway. I figured I would break it out. We shouldn't commit it until we have fixed getting the regioninfo from the thriftserver.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5217) Reenable the thrift tests, and add
a new one for getRegionInfo
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247432#comment-13247432 ]
Hadoop QA commented on HBASE-5217:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12521535/0002-HBASE-5217-v3.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 4 new or modified tests.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1406//console
This message is automatically generated.
> Reenable the thrift tests, and add a new one for getRegionInfo
> --------------------------------------------------------------
>
> Key: HBASE-5217
> URL: https://issues.apache.org/jira/browse/HBASE-5217
> Project: HBase
> Issue Type: Improvement
> Reporter: Alex Newman
> Assignee: Alex Newman
> Priority: Minor
> Attachments: 0001-Fixing-thrift-tests-v2.patch, 0001-Fixing-thrift-tests.patch, 0002-HBASE-5217-v3.patch, 0002-HBASE-5217.-Reenable-the-thrift-tests-and-add-a-new-.patch, zzzz-hbase-posix4e #92 Console [Jenkins].pdf
>
>
> At some point we disabled tests for the thrift server. In addition, it looks like the getRegionInfo no longer functions. I'd like to reenable the tests and add one for getRegionInfo. I had to write this to test my changes in HBASE-2600 anyway. I figured I would break it out. We shouldn't commit it until we have fixed getting the regioninfo from the thriftserver.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5217) Reenable the thrift tests, and add a
new one for getRegionInfo
Posted by "Alex Newman (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Newman updated HBASE-5217:
-------------------------------
Attachment: (was: 0002-HBASE-5217.-Reenable-the-thrift-tests-and-add-a-new-v2.patch)
> Reenable the thrift tests, and add a new one for getRegionInfo
> --------------------------------------------------------------
>
> Key: HBASE-5217
> URL: https://issues.apache.org/jira/browse/HBASE-5217
> Project: HBase
> Issue Type: Improvement
> Reporter: Alex Newman
> Assignee: Alex Newman
> Priority: Minor
> Attachments: 0001-Fixing-thrift-tests-v2.patch, 0001-Fixing-thrift-tests.patch, 0002-HBASE-5217.-Reenable-the-thrift-tests-and-add-a-new-.patch, zzzz-hbase-posix4e #92 Console [Jenkins].pdf
>
>
> At some point we disabled tests for the thrift server. In addition, it looks like the getRegionInfo no longer functions. I'd like to reenable the tests and add one for getRegionInfo. I had to write this to test my changes in HBASE-2600 anyway. I figured I would break it out. We shouldn't commit it until we have fixed getting the regioninfo from the thriftserver.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5217) Reenable the thrift tests, and add a
new one for getRegionInfo
Posted by "Alex Newman (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Newman updated HBASE-5217:
-------------------------------
Status: Patch Available (was: In Progress)
> Reenable the thrift tests, and add a new one for getRegionInfo
> --------------------------------------------------------------
>
> Key: HBASE-5217
> URL: https://issues.apache.org/jira/browse/HBASE-5217
> Project: HBase
> Issue Type: Improvement
> Reporter: Alex Newman
> Assignee: Alex Newman
> Priority: Minor
> Attachments: 0001-Fixing-thrift-tests-v2.patch, 0001-Fixing-thrift-tests.patch, 0002-HBASE-5217.-Reenable-the-thrift-tests-and-add-a-new-.patch, zzzz-hbase-posix4e #92 Console [Jenkins].pdf
>
>
> At some point we disabled tests for the thrift server. In addition, it looks like the getRegionInfo no longer functions. I'd like to reenable the tests and add one for getRegionInfo. I had to write this to test my changes in HBASE-2600 anyway. I figured I would break it out. We shouldn't commit it until we have fixed getting the regioninfo from the thriftserver.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5217) Reenable the thrift tests, and add a
new one for getRegionInfo
Posted by "Alex Newman (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Newman updated HBASE-5217:
-------------------------------
Attachment: 0002-HBASE-5217.-Reenable-the-thrift-tests-and-add-a-new-v2.patch
remerged
> Reenable the thrift tests, and add a new one for getRegionInfo
> --------------------------------------------------------------
>
> Key: HBASE-5217
> URL: https://issues.apache.org/jira/browse/HBASE-5217
> Project: HBase
> Issue Type: Improvement
> Reporter: Alex Newman
> Assignee: Alex Newman
> Priority: Minor
> Attachments: 0001-Fixing-thrift-tests-v2.patch, 0001-Fixing-thrift-tests.patch, 0002-HBASE-5217.-Reenable-the-thrift-tests-and-add-a-new-v2.patch, zzzz-hbase-posix4e #92 Console [Jenkins].pdf
>
>
> At some point we disabled tests for the thrift server. In addition, it looks like the getRegionInfo no longer functions. I'd like to reenable the tests and add one for getRegionInfo. I had to write this to test my changes in HBASE-2600 anyway. I figured I would break it out. We shouldn't commit it until we have fixed getting the regioninfo from the thriftserver.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5217) Reenable the thrift tests, and add a
new one for getRegionInfo
Posted by "Alex Newman (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Newman updated HBASE-5217:
-------------------------------
Attachment: 0001-Fixing-thrift-tests-v2.patch
> Reenable the thrift tests, and add a new one for getRegionInfo
> --------------------------------------------------------------
>
> Key: HBASE-5217
> URL: https://issues.apache.org/jira/browse/HBASE-5217
> Project: HBase
> Issue Type: Improvement
> Reporter: Alex Newman
> Assignee: Alex Newman
> Priority: Minor
> Attachments: 0001-Fixing-thrift-tests-v2.patch, 0001-Fixing-thrift-tests.patch
>
>
> At some point we disabled tests for the thrift server. In addition, it looks like the getRegionInfo no longer functions. I'd like to reenable the tests and add one for getRegionInfo. I had to write this to test my changes in HBASE-2600 anyway. I figured I would break it out. We shouldn't commit it until we have fixed getting the regioninfo from the thriftserver.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5217) Reenable the thrift tests, and add a
new one for getRegionInfo
Posted by "Alex Newman (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Newman updated HBASE-5217:
-------------------------------
Attachment: 0002-HBASE-5217-v3.patch
Fixed spacing
> Reenable the thrift tests, and add a new one for getRegionInfo
> --------------------------------------------------------------
>
> Key: HBASE-5217
> URL: https://issues.apache.org/jira/browse/HBASE-5217
> Project: HBase
> Issue Type: Improvement
> Reporter: Alex Newman
> Assignee: Alex Newman
> Priority: Minor
> Attachments: 0001-Fixing-thrift-tests-v2.patch, 0001-Fixing-thrift-tests.patch, 0002-HBASE-5217-v3.patch, 0002-HBASE-5217.-Reenable-the-thrift-tests-and-add-a-new-.patch, zzzz-hbase-posix4e #92 Console [Jenkins].pdf
>
>
> At some point we disabled tests for the thrift server. In addition, it looks like the getRegionInfo no longer functions. I'd like to reenable the tests and add one for getRegionInfo. I had to write this to test my changes in HBASE-2600 anyway. I figured I would break it out. We shouldn't commit it until we have fixed getting the regioninfo from the thriftserver.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5217) Reenable the thrift tests, and add a
new one for getRegionInfo
Posted by "Alex Newman (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Newman updated HBASE-5217:
-------------------------------
Attachment: 0001-Fixing-thrift-tests.patch
> Reenable the thrift tests, and add a new one for getRegionInfo
> --------------------------------------------------------------
>
> Key: HBASE-5217
> URL: https://issues.apache.org/jira/browse/HBASE-5217
> Project: HBase
> Issue Type: Improvement
> Reporter: Alex Newman
> Assignee: Alex Newman
> Attachments: 0001-Fixing-thrift-tests.patch
>
>
> At some point we disabled tests for the thrift server. In addition, it looks like the getRegionInfo no longer functions. I'd like to reenable the tests and add one for getRegionInfo.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5217) Reenable the thrift tests, and add a
new one for getRegionInfo
Posted by "Alex Newman (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Newman updated HBASE-5217:
-------------------------------
Status: Patch Available (was: Open)
> Reenable the thrift tests, and add a new one for getRegionInfo
> --------------------------------------------------------------
>
> Key: HBASE-5217
> URL: https://issues.apache.org/jira/browse/HBASE-5217
> Project: HBase
> Issue Type: Improvement
> Reporter: Alex Newman
> Assignee: Alex Newman
> Priority: Minor
> Attachments: 0001-Fixing-thrift-tests-v2.patch, 0001-Fixing-thrift-tests.patch
>
>
> At some point we disabled tests for the thrift server. In addition, it looks like the getRegionInfo no longer functions. I'd like to reenable the tests and add one for getRegionInfo. I had to write this to test my changes in HBASE-2600 anyway. I figured I would break it out. We shouldn't commit it until we have fixed getting the regioninfo from the thriftserver.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5217) Reenable the thrift tests, and add
a new one for getRegionInfo
Posted by "Alex Newman (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247741#comment-13247741 ]
Alex Newman commented on HBASE-5217:
------------------------------------
Indeed, it is tied to HBASE-2600.
> Reenable the thrift tests, and add a new one for getRegionInfo
> --------------------------------------------------------------
>
> Key: HBASE-5217
> URL: https://issues.apache.org/jira/browse/HBASE-5217
> Project: HBase
> Issue Type: Improvement
> Reporter: Alex Newman
> Assignee: Alex Newman
> Priority: Minor
> Attachments: 0001-Fixing-thrift-tests-v2.patch, 0001-Fixing-thrift-tests.patch, 0002-HBASE-5217-v3.patch, 0002-HBASE-5217-v4.patch, 0002-HBASE-5217.-Reenable-the-thrift-tests-and-add-a-new-.patch, zzzz-hbase-posix4e #92 Console [Jenkins].pdf
>
>
> At some point we disabled tests for the thrift server. In addition, it looks like the getRegionInfo no longer functions. I'd like to reenable the tests and add one for getRegionInfo. I had to write this to test my changes in HBASE-2600 anyway. I figured I would break it out. We shouldn't commit it until we have fixed getting the regioninfo from the thriftserver.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5217) Reenable the thrift tests, and add
a new one for getRegionInfo
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13256858#comment-13256858 ]
Hadoop QA commented on HBASE-5217:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12523232/0002-HBASE-5217-v5.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 4 new or modified tests.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1569//console
This message is automatically generated.
> Reenable the thrift tests, and add a new one for getRegionInfo
> --------------------------------------------------------------
>
> Key: HBASE-5217
> URL: https://issues.apache.org/jira/browse/HBASE-5217
> Project: HBase
> Issue Type: Improvement
> Reporter: Alex Newman
> Assignee: Alex Newman
> Priority: Minor
> Attachments: 0001-Fixing-thrift-tests-v2.patch, 0001-Fixing-thrift-tests.patch, 0002-HBASE-5217-v3.patch, 0002-HBASE-5217-v4.patch, 0002-HBASE-5217-v5.patch, 0002-HBASE-5217.-Reenable-the-thrift-tests-and-add-a-new-.patch, zzzz-hbase-posix4e #92 Console [Jenkins].pdf
>
>
> At some point we disabled tests for the thrift server. In addition, it looks like the getRegionInfo no longer functions. I'd like to reenable the tests and add one for getRegionInfo. I had to write this to test my changes in HBASE-2600 anyway. I figured I would break it out. We shouldn't commit it until we have fixed getting the regioninfo from the thriftserver.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5217) Reenable the thrift tests, and add a
new one for getRegionInfo
Posted by "Alex Newman (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Newman updated HBASE-5217:
-------------------------------
Attachment: 0002-HBASE-5217-v4.patch
> Reenable the thrift tests, and add a new one for getRegionInfo
> --------------------------------------------------------------
>
> Key: HBASE-5217
> URL: https://issues.apache.org/jira/browse/HBASE-5217
> Project: HBase
> Issue Type: Improvement
> Reporter: Alex Newman
> Assignee: Alex Newman
> Priority: Minor
> Attachments: 0001-Fixing-thrift-tests-v2.patch, 0001-Fixing-thrift-tests.patch, 0002-HBASE-5217-v3.patch, 0002-HBASE-5217-v4.patch, 0002-HBASE-5217.-Reenable-the-thrift-tests-and-add-a-new-.patch, zzzz-hbase-posix4e #92 Console [Jenkins].pdf
>
>
> At some point we disabled tests for the thrift server. In addition, it looks like the getRegionInfo no longer functions. I'd like to reenable the tests and add one for getRegionInfo. I had to write this to test my changes in HBASE-2600 anyway. I figured I would break it out. We shouldn't commit it until we have fixed getting the regioninfo from the thriftserver.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5217) Reenable the thrift tests, and add
a new one for getRegionInfo
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245398#comment-13245398 ]
stack commented on HBASE-5217:
------------------------------
@Alex Is this dependent on another issue being committed first? In doTestGetRegionInfo the tabs are wrong. Should be two spaces like the rest of the file. With your changes are we going to start a cluster each time (Was the testAll method trying to avoid our making a cluster each time)?
> Reenable the thrift tests, and add a new one for getRegionInfo
> --------------------------------------------------------------
>
> Key: HBASE-5217
> URL: https://issues.apache.org/jira/browse/HBASE-5217
> Project: HBase
> Issue Type: Improvement
> Reporter: Alex Newman
> Assignee: Alex Newman
> Priority: Minor
> Attachments: 0001-Fixing-thrift-tests-v2.patch, 0001-Fixing-thrift-tests.patch, 0002-HBASE-5217.-Reenable-the-thrift-tests-and-add-a-new-.patch, zzzz-hbase-posix4e #92 Console [Jenkins].pdf
>
>
> At some point we disabled tests for the thrift server. In addition, it looks like the getRegionInfo no longer functions. I'd like to reenable the tests and add one for getRegionInfo. I had to write this to test my changes in HBASE-2600 anyway. I figured I would break it out. We shouldn't commit it until we have fixed getting the regioninfo from the thriftserver.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5217) Reenable the thrift tests, and add a
new one for getRegionInfo
Posted by "Alex Newman (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Newman updated HBASE-5217:
-------------------------------
Attachment: zzzz-hbase-posix4e #92 Console [Jenkins].pdf
I attached my own jenkins run. The one failing test is due to 2600 not handling migrations yet.
> Reenable the thrift tests, and add a new one for getRegionInfo
> --------------------------------------------------------------
>
> Key: HBASE-5217
> URL: https://issues.apache.org/jira/browse/HBASE-5217
> Project: HBase
> Issue Type: Improvement
> Reporter: Alex Newman
> Assignee: Alex Newman
> Priority: Minor
> Attachments: 0001-Fixing-thrift-tests-v2.patch, 0001-Fixing-thrift-tests.patch, zzzz-hbase-posix4e #92 Console [Jenkins].pdf
>
>
> At some point we disabled tests for the thrift server. In addition, it looks like the getRegionInfo no longer functions. I'd like to reenable the tests and add one for getRegionInfo. I had to write this to test my changes in HBASE-2600 anyway. I figured I would break it out. We shouldn't commit it until we have fixed getting the regioninfo from the thriftserver.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5217) Reenable the thrift tests, and add
a new one for getRegionInfo
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13188643#comment-13188643 ]
jiraposter@reviews.apache.org commented on HBASE-5217:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3514/
-----------------------------------------------------------
(Updated 2012-01-18 19:20:58.494454)
Review request for hbase.
Summary
-------
At some point we disabled tests for the thrift server. In addition, it looks like the getRegionInfo no longer functions. I'd like to reenable the tests and add one for getRegionInfo.
This addresses bug HBASE-5217.
https://issues.apache.org/jira/browse/HBASE-5217
Diffs (updated)
-----
src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java c3be6e3
Diff: https://reviews.apache.org/r/3514/diff
Testing
-------
Ran the tests with my changes in HBASE-2600 to test.
Thanks,
Alex
> Reenable the thrift tests, and add a new one for getRegionInfo
> --------------------------------------------------------------
>
> Key: HBASE-5217
> URL: https://issues.apache.org/jira/browse/HBASE-5217
> Project: HBase
> Issue Type: Improvement
> Reporter: Alex Newman
> Assignee: Alex Newman
> Priority: Minor
> Attachments: 0001-Fixing-thrift-tests-v2.patch, 0001-Fixing-thrift-tests.patch, 0002-HBASE-5217.-Reenable-the-thrift-tests-and-add-a-new-v2.patch, zzzz-hbase-posix4e #92 Console [Jenkins].pdf
>
>
> At some point we disabled tests for the thrift server. In addition, it looks like the getRegionInfo no longer functions. I'd like to reenable the tests and add one for getRegionInfo. I had to write this to test my changes in HBASE-2600 anyway. I figured I would break it out. We shouldn't commit it until we have fixed getting the regioninfo from the thriftserver.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5217) Reenable the thrift tests, and add
a new one for getRegionInfo
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13187929#comment-13187929 ]
Hadoop QA commented on HBASE-5217:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12510881/0001-Fixing-thrift-tests-v2.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 4 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated -145 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 82 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/794//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/794//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/794//console
This message is automatically generated.
> Reenable the thrift tests, and add a new one for getRegionInfo
> --------------------------------------------------------------
>
> Key: HBASE-5217
> URL: https://issues.apache.org/jira/browse/HBASE-5217
> Project: HBase
> Issue Type: Improvement
> Reporter: Alex Newman
> Assignee: Alex Newman
> Priority: Minor
> Attachments: 0001-Fixing-thrift-tests-v2.patch, 0001-Fixing-thrift-tests.patch
>
>
> At some point we disabled tests for the thrift server. In addition, it looks like the getRegionInfo no longer functions. I'd like to reenable the tests and add one for getRegionInfo. I had to write this to test my changes in HBASE-2600 anyway. I figured I would break it out. We shouldn't commit it until we have fixed getting the regioninfo from the thriftserver.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5217) Reenable the thrift tests, and add
a new one for getRegionInfo
Posted by "Alex Newman (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13187937#comment-13187937 ]
Alex Newman commented on HBASE-5217:
------------------------------------
Expect this build to fail until the dependent jira is done.
> Reenable the thrift tests, and add a new one for getRegionInfo
> --------------------------------------------------------------
>
> Key: HBASE-5217
> URL: https://issues.apache.org/jira/browse/HBASE-5217
> Project: HBase
> Issue Type: Improvement
> Reporter: Alex Newman
> Assignee: Alex Newman
> Priority: Minor
> Attachments: 0001-Fixing-thrift-tests-v2.patch, 0001-Fixing-thrift-tests.patch
>
>
> At some point we disabled tests for the thrift server. In addition, it looks like the getRegionInfo no longer functions. I'd like to reenable the tests and add one for getRegionInfo. I had to write this to test my changes in HBASE-2600 anyway. I figured I would break it out. We shouldn't commit it until we have fixed getting the regioninfo from the thriftserver.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5217) Reenable the thrift tests, and add a
new one for getRegionInfo
Posted by "Alex Newman (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Newman updated HBASE-5217:
-------------------------------
Attachment: 0002-HBASE-5217.-Reenable-the-thrift-tests-and-add-a-new-.patch
v2
> Reenable the thrift tests, and add a new one for getRegionInfo
> --------------------------------------------------------------
>
> Key: HBASE-5217
> URL: https://issues.apache.org/jira/browse/HBASE-5217
> Project: HBase
> Issue Type: Improvement
> Reporter: Alex Newman
> Assignee: Alex Newman
> Priority: Minor
> Attachments: 0001-Fixing-thrift-tests-v2.patch, 0001-Fixing-thrift-tests.patch, 0002-HBASE-5217.-Reenable-the-thrift-tests-and-add-a-new-.patch, zzzz-hbase-posix4e #92 Console [Jenkins].pdf
>
>
> At some point we disabled tests for the thrift server. In addition, it looks like the getRegionInfo no longer functions. I'd like to reenable the tests and add one for getRegionInfo. I had to write this to test my changes in HBASE-2600 anyway. I figured I would break it out. We shouldn't commit it until we have fixed getting the regioninfo from the thriftserver.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5217) Reenable the thrift tests, and add a
new one for getRegionInfo
Posted by "Alex Newman (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Newman updated HBASE-5217:
-------------------------------
Attachment: 0002-HBASE-5217-v5.patch
I rebased today
> Reenable the thrift tests, and add a new one for getRegionInfo
> --------------------------------------------------------------
>
> Key: HBASE-5217
> URL: https://issues.apache.org/jira/browse/HBASE-5217
> Project: HBase
> Issue Type: Improvement
> Reporter: Alex Newman
> Assignee: Alex Newman
> Priority: Minor
> Attachments: 0001-Fixing-thrift-tests-v2.patch, 0001-Fixing-thrift-tests.patch, 0002-HBASE-5217-v3.patch, 0002-HBASE-5217-v4.patch, 0002-HBASE-5217-v5.patch, 0002-HBASE-5217.-Reenable-the-thrift-tests-and-add-a-new-.patch, zzzz-hbase-posix4e #92 Console [Jenkins].pdf
>
>
> At some point we disabled tests for the thrift server. In addition, it looks like the getRegionInfo no longer functions. I'd like to reenable the tests and add one for getRegionInfo. I had to write this to test my changes in HBASE-2600 anyway. I figured I would break it out. We shouldn't commit it until we have fixed getting the regioninfo from the thriftserver.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5217) Reenable the thrift tests, and add
a new one for getRegionInfo
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247737#comment-13247737 ]
stack commented on HBASE-5217:
------------------------------
Your patch still doesn't apply Boss.
> Reenable the thrift tests, and add a new one for getRegionInfo
> --------------------------------------------------------------
>
> Key: HBASE-5217
> URL: https://issues.apache.org/jira/browse/HBASE-5217
> Project: HBase
> Issue Type: Improvement
> Reporter: Alex Newman
> Assignee: Alex Newman
> Priority: Minor
> Attachments: 0001-Fixing-thrift-tests-v2.patch, 0001-Fixing-thrift-tests.patch, 0002-HBASE-5217-v3.patch, 0002-HBASE-5217-v4.patch, 0002-HBASE-5217.-Reenable-the-thrift-tests-and-add-a-new-.patch, zzzz-hbase-posix4e #92 Console [Jenkins].pdf
>
>
> At some point we disabled tests for the thrift server. In addition, it looks like the getRegionInfo no longer functions. I'd like to reenable the tests and add one for getRegionInfo. I had to write this to test my changes in HBASE-2600 anyway. I figured I would break it out. We shouldn't commit it until we have fixed getting the regioninfo from the thriftserver.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5217) Reenable the thrift tests, and add a
new one for getRegionInfo
Posted by "Alex Newman (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Newman updated HBASE-5217:
-------------------------------
Priority: Minor (was: Major)
> Reenable the thrift tests, and add a new one for getRegionInfo
> --------------------------------------------------------------
>
> Key: HBASE-5217
> URL: https://issues.apache.org/jira/browse/HBASE-5217
> Project: HBase
> Issue Type: Improvement
> Reporter: Alex Newman
> Assignee: Alex Newman
> Priority: Minor
> Attachments: 0001-Fixing-thrift-tests.patch
>
>
> At some point we disabled tests for the thrift server. In addition, it looks like the getRegionInfo no longer functions. I'd like to reenable the tests and add one for getRegionInfo.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5217) Reenable the thrift tests, and add
a new one for getRegionInfo
Posted by "Alex Newman (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245537#comment-13245537 ]
Alex Newman commented on HBASE-5217:
------------------------------------
This <bold>is</bold> dependent on the other being committed first. Sorry about the spacing will fix when I am back from vegas. I think the reason this patch had them consolidated was
* Runs all of the tests under a single JUnit test method. We
- * consolidate all testing to one method because HBaseClusterTestCase
- * is prone to OutOfMemoryExceptions when there are three or more
- * JUnit test methods.
- *
- * @throws Exception
I think this is mostly fixed now though.
> Reenable the thrift tests, and add a new one for getRegionInfo
> --------------------------------------------------------------
>
> Key: HBASE-5217
> URL: https://issues.apache.org/jira/browse/HBASE-5217
> Project: HBase
> Issue Type: Improvement
> Reporter: Alex Newman
> Assignee: Alex Newman
> Priority: Minor
> Attachments: 0001-Fixing-thrift-tests-v2.patch, 0001-Fixing-thrift-tests.patch, 0002-HBASE-5217.-Reenable-the-thrift-tests-and-add-a-new-.patch, zzzz-hbase-posix4e #92 Console [Jenkins].pdf
>
>
> At some point we disabled tests for the thrift server. In addition, it looks like the getRegionInfo no longer functions. I'd like to reenable the tests and add one for getRegionInfo. I had to write this to test my changes in HBASE-2600 anyway. I figured I would break it out. We shouldn't commit it until we have fixed getting the regioninfo from the thriftserver.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5217) Reenable the thrift tests, and add
a new one for getRegionInfo
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247723#comment-13247723 ]
Hadoop QA commented on HBASE-5217:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12521584/0002-HBASE-5217-v4.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 4 new or modified tests.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1415//console
This message is automatically generated.
> Reenable the thrift tests, and add a new one for getRegionInfo
> --------------------------------------------------------------
>
> Key: HBASE-5217
> URL: https://issues.apache.org/jira/browse/HBASE-5217
> Project: HBase
> Issue Type: Improvement
> Reporter: Alex Newman
> Assignee: Alex Newman
> Priority: Minor
> Attachments: 0001-Fixing-thrift-tests-v2.patch, 0001-Fixing-thrift-tests.patch, 0002-HBASE-5217-v3.patch, 0002-HBASE-5217-v4.patch, 0002-HBASE-5217.-Reenable-the-thrift-tests-and-add-a-new-.patch, zzzz-hbase-posix4e #92 Console [Jenkins].pdf
>
>
> At some point we disabled tests for the thrift server. In addition, it looks like the getRegionInfo no longer functions. I'd like to reenable the tests and add one for getRegionInfo. I had to write this to test my changes in HBASE-2600 anyway. I figured I would break it out. We shouldn't commit it until we have fixed getting the regioninfo from the thriftserver.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5217) Reenable the thrift tests, and add
a new one for getRegionInfo
Posted by "Alex Newman (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247715#comment-13247715 ]
Alex Newman commented on HBASE-5217:
------------------------------------
done
> Reenable the thrift tests, and add a new one for getRegionInfo
> --------------------------------------------------------------
>
> Key: HBASE-5217
> URL: https://issues.apache.org/jira/browse/HBASE-5217
> Project: HBase
> Issue Type: Improvement
> Reporter: Alex Newman
> Assignee: Alex Newman
> Priority: Minor
> Attachments: 0001-Fixing-thrift-tests-v2.patch, 0001-Fixing-thrift-tests.patch, 0002-HBASE-5217-v3.patch, 0002-HBASE-5217-v4.patch, 0002-HBASE-5217.-Reenable-the-thrift-tests-and-add-a-new-.patch, zzzz-hbase-posix4e #92 Console [Jenkins].pdf
>
>
> At some point we disabled tests for the thrift server. In addition, it looks like the getRegionInfo no longer functions. I'd like to reenable the tests and add one for getRegionInfo. I had to write this to test my changes in HBASE-2600 anyway. I figured I would break it out. We shouldn't commit it until we have fixed getting the regioninfo from the thriftserver.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5217) Reenable the thrift tests, and add
a new one for getRegionInfo
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13247688#comment-13247688 ]
stack commented on HBASE-5217:
------------------------------
Attach a patch w/ --no-prefix Alex... jenkins don't know how to apply a/src... paths.
> Reenable the thrift tests, and add a new one for getRegionInfo
> --------------------------------------------------------------
>
> Key: HBASE-5217
> URL: https://issues.apache.org/jira/browse/HBASE-5217
> Project: HBase
> Issue Type: Improvement
> Reporter: Alex Newman
> Assignee: Alex Newman
> Priority: Minor
> Attachments: 0001-Fixing-thrift-tests-v2.patch, 0001-Fixing-thrift-tests.patch, 0002-HBASE-5217-v3.patch, 0002-HBASE-5217.-Reenable-the-thrift-tests-and-add-a-new-.patch, zzzz-hbase-posix4e #92 Console [Jenkins].pdf
>
>
> At some point we disabled tests for the thrift server. In addition, it looks like the getRegionInfo no longer functions. I'd like to reenable the tests and add one for getRegionInfo. I had to write this to test my changes in HBASE-2600 anyway. I figured I would break it out. We shouldn't commit it until we have fixed getting the regioninfo from the thriftserver.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5217) Reenable the thrift tests, and add
a new one for getRegionInfo
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13187946#comment-13187946 ]
Hadoop QA commented on HBASE-5217:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12510886/zzzz-hbase-posix4e+%2392+Console+%5BJenkins%5D.pdf
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/796//console
This message is automatically generated.
> Reenable the thrift tests, and add a new one for getRegionInfo
> --------------------------------------------------------------
>
> Key: HBASE-5217
> URL: https://issues.apache.org/jira/browse/HBASE-5217
> Project: HBase
> Issue Type: Improvement
> Reporter: Alex Newman
> Assignee: Alex Newman
> Priority: Minor
> Attachments: 0001-Fixing-thrift-tests-v2.patch, 0001-Fixing-thrift-tests.patch, zzzz-hbase-posix4e #92 Console [Jenkins].pdf
>
>
> At some point we disabled tests for the thrift server. In addition, it looks like the getRegionInfo no longer functions. I'd like to reenable the tests and add one for getRegionInfo. I had to write this to test my changes in HBASE-2600 anyway. I figured I would break it out. We shouldn't commit it until we have fixed getting the regioninfo from the thriftserver.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5217) Reenable the thrift tests, and add a
new one for getRegionInfo
Posted by "Alex Newman (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Newman updated HBASE-5217:
-------------------------------
Description: At some point we disabled tests for the thrift server. In addition, it looks like the getRegionInfo no longer functions. I'd like to reenable the tests and add one for getRegionInfo. I had to write this to test my changes in HBASE-2600 anyway. I figured I would break it out. We shouldn't commit it until we have fixed getting the regioninfo from the thriftserver. (was: At some point we disabled tests for the thrift server. In addition, it looks like the getRegionInfo no longer functions. I'd like to reenable the tests and add one for getRegionInfo.)
> Reenable the thrift tests, and add a new one for getRegionInfo
> --------------------------------------------------------------
>
> Key: HBASE-5217
> URL: https://issues.apache.org/jira/browse/HBASE-5217
> Project: HBase
> Issue Type: Improvement
> Reporter: Alex Newman
> Assignee: Alex Newman
> Priority: Minor
> Attachments: 0001-Fixing-thrift-tests.patch
>
>
> At some point we disabled tests for the thrift server. In addition, it looks like the getRegionInfo no longer functions. I'd like to reenable the tests and add one for getRegionInfo. I had to write this to test my changes in HBASE-2600 anyway. I figured I would break it out. We shouldn't commit it until we have fixed getting the regioninfo from the thriftserver.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5217) Reenable the thrift tests, and add
a new one for getRegionInfo
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13187910#comment-13187910 ]
jiraposter@reviews.apache.org commented on HBASE-5217:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3514/
-----------------------------------------------------------
Review request for hbase.
Summary
-------
At some point we disabled tests for the thrift server. In addition, it looks like the getRegionInfo no longer functions. I'd like to reenable the tests and add one for getRegionInfo.
This addresses bug HBASE-5217.
https://issues.apache.org/jira/browse/HBASE-5217
Diffs
-----
src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java 12247d0
Diff: https://reviews.apache.org/r/3514/diff
Testing
-------
Ran the tests with my changes in HBASE-2600 to test.
Thanks,
Alex
> Reenable the thrift tests, and add a new one for getRegionInfo
> --------------------------------------------------------------
>
> Key: HBASE-5217
> URL: https://issues.apache.org/jira/browse/HBASE-5217
> Project: HBase
> Issue Type: Improvement
> Reporter: Alex Newman
> Assignee: Alex Newman
> Priority: Minor
> Attachments: 0001-Fixing-thrift-tests.patch
>
>
> At some point we disabled tests for the thrift server. In addition, it looks like the getRegionInfo no longer functions. I'd like to reenable the tests and add one for getRegionInfo. I had to write this to test my changes in HBASE-2600 anyway. I figured I would break it out. We shouldn't commit it until we have fixed getting the regioninfo from the thriftserver.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira