[GitHub] [drill] dzamo commented on a change in pull request #2351: DRILL-1282: Move parquet to use v2 format as default

[GitBox <gi...@apache.org>]

dzamo commented on a change in pull request #2351:
URL: https://github.com/apache/drill/pull/2351#discussion_r751937946



##########
File path: exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java
##########
@@ -963,6 +963,17 @@ private void compareParquetInt96Converters(String selection, String table) throw
     }
   }
 
+  @Test
+  public void testTPCHReadWriteFormatV2() throws Exception {
+    try {
+      alterSession(ExecConstants.PARQUET_WRITER_FORMAT_VERSION, "parquet_2_0");

Review comment:
       @vdiravka I discussed the default format version with @vvysotskyi who said that v2 does not have wide adoption.  I then checked Apache Spark and found that, indeed, reading v2 will not work without a non-default setting there.  So it was conceded that v1 should remain the default, in spite of the title of the old Jira ticket.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org