You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by sebb <se...@gmail.com> on 2010/01/17 03:51:18 UTC
[DBCP] Missing test cases - get rid of suite() and TestAll classes?
Just done a comparison of the tests run by Ant and Maven with the
number of Test*.java files and found several discrepancies, including
one test that was not being run by either:
TestDelegatingCallableStatement (that was my fault - oops!).
Seems to me that these discrepancies arose because of the practise of
listing all the tests by name, rather than including Test* and then
excluding any files that are abstract or don't contain test cases.
I think it would be a lot simpler to get rid of the TestAll.java files
and get rid of the suite() methods (unless a particular class needs to
run tests in a particular order).
This would make it easier to maintain the Maven and Ant builds.
WDYT?
S
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [DBCP] Missing test cases - get rid of suite() and TestAll classes?
Posted by Jörg Schaible <jo...@gmx.de>.
sebb wrote:
> Just done a comparison of the tests run by Ant and Maven with the
> number of Test*.java files and found several discrepancies, including
> one test that was not being run by either:
> TestDelegatingCallableStatement (that was my fault - oops!).
>
> Seems to me that these discrepancies arose because of the practise of
> listing all the tests by name, rather than including Test* and then
> excluding any files that are abstract or don't contain test cases.
>
> I think it would be a lot simpler to get rid of the TestAll.java files
> and get rid of the suite() methods (unless a particular class needs to
> run tests in a particular order).
>
> This would make it easier to maintain the Maven and Ant builds.
>
> WDYT?
+1
- Jörg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [DBCP] Missing test cases - get rid of suite() and TestAll classes?
Posted by Phil Steitz <ph...@gmail.com>.
sebb wrote:
> Just done a comparison of the tests run by Ant and Maven with the
> number of Test*.java files and found several discrepancies, including
> one test that was not being run by either:
> TestDelegatingCallableStatement (that was my fault - oops!).
>
> Seems to me that these discrepancies arose because of the practise of
> listing all the tests by name, rather than including Test* and then
> excluding any files that are abstract or don't contain test cases.
>
> I think it would be a lot simpler to get rid of the TestAll.java files
> and get rid of the suite() methods (unless a particular class needs to
> run tests in a particular order).
>
> This would make it easier to maintain the Maven and Ant builds.
>
> WDYT?
>
> S
+1
Phil
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org