You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/03/06 00:58:05 UTC
[GitHub] [incubator-doris] morningman opened a new pull request #5473: [Bug] Fix bug that data lost when doing backup job
morningman opened a new pull request #5473:
URL: https://github.com/apache/incubator-doris/pull/5473
## Proposed changes
Backup job may delete the tablet of existing table, which cause data lost.
## Types of changes
- [x] Bugfix (non-breaking change which fixes an issue)
## Checklist
- [x] I have created an issue on (Fix #5471 ) and described the bug/feature there in detail
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #5473: [Bug] Fix bug that data lost when doing backup job
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #5473:
URL: https://github.com/apache/incubator-doris/pull/5473
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yangzhg commented on a change in pull request #5473: [Bug] Fix bug that data lost when doing backup job
Posted by GitBox <gi...@apache.org>.
yangzhg commented on a change in pull request #5473:
URL: https://github.com/apache/incubator-doris/pull/5473#discussion_r588804740
##########
File path: fe/fe-core/src/main/java/org/apache/doris/catalog/Catalog.java
##########
@@ -3324,7 +3324,8 @@ public void dropPartition(Database db, OlapTable olapTable, DropPartitionClause
}
}
}
- olapTable.dropPartition(db.getId(), partitionName, clause.isForceDrop());
+ olapTable.dropPartition(db.getId(), partitionName, clause.isForceDrop(),
+ clause.isForceDrop() /* If force, then drop tablet too, if not, keey the tablet too.*/);
Review comment:
```
+ clause.isForceDrop() /* If force, then drop tablet too, if not, keep the tablet.*/);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yangzhg commented on a change in pull request #5473: [Bug] Fix bug that data lost when doing backup job
Posted by GitBox <gi...@apache.org>.
yangzhg commented on a change in pull request #5473:
URL: https://github.com/apache/incubator-doris/pull/5473#discussion_r589119203
##########
File path: be/src/tools/CMakeLists.txt
##########
@@ -26,7 +26,7 @@ add_executable(meta_tool
)
# This permits libraries loaded by dlopen to link to the symbols in the program.
-# set_target_properties(doris_be PROPERTIES LINK_FLAGS -pthread)
+set_target_properties(palo_be PROPERTIES ENABLE_EXPORTS 1)
Review comment:
should be meta_tool
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org