You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/12/05 12:04:28 UTC

[GitHub] [pulsar] 315157973 commented on a change in pull request #13112: [C++]Fix libcurl miss auth header when broker return 307

315157973 commented on a change in pull request #13112:
URL: https://github.com/apache/pulsar/pull/13112#discussion_r762552229



##########
File path: pulsar-client-cpp/include/pulsar/c/client_configuration.h
##########
@@ -25,7 +25,13 @@
 extern "C" {
 #endif
 
-typedef enum { pulsar_DEBUG = 0, pulsar_INFO = 1, pulsar_WARN = 2, pulsar_ERROR = 3 } pulsar_logger_level_t;
+typedef enum
+{
+    pulsar_DEBUG = 0,
+    pulsar_INFO = 1,
+    pulsar_WARN = 2,
+    pulsar_ERROR = 3
+} pulsar_logger_level_t;

Review comment:
       Are these changes necessary? Don't format your code if you don't have to

##########
File path: pulsar-client-cpp/lib/lz4/lz4.h
##########
@@ -402,4 +402,4 @@ int LZ4_decompress_safe_withPrefix64k(const char *src, char *dst, int compressed
 LZ4_DEPRECATED("use LZ4_decompress_fast_usingDict() instead")
 
 int LZ4_decompress_fast_withPrefix64k(const char *src, char *dst, int originalSize);
-}
\ No newline at end of file
+}  // namespace pulsar

Review comment:
       Please don't comment like this




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org